[Qemu-devel] Re: [PATCH v3 3/7] target-i386: Don't use SoftFloat uint64 type

[Juan Quintela <quintela@redhat.com>]

Andreas Färber <andreas.faerber@web.de> wrote:
> softfloat.h's uint64 type has least-width semantics,
> which seems unintended here since uint64_t is used in helpers.
>
> v3:
> * Split off.

Acked-by: Juan Quintela <quintela@redhat.com>

Some days I feel the urgency of removing all the typealiases of
softfloat.h :(


> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> ---
>  target-i386/cpu.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 06e40f3..f0c07cd 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -737,10 +737,10 @@ typedef struct CPUX86State {
>         user */
>      struct DeviceState *apic_state;
>  
> -    uint64 mcg_cap;
> -    uint64 mcg_status;
> -    uint64 mcg_ctl;
> -    uint64 mce_banks[MCE_BANKS_DEF*4];
> +    uint64_t mcg_cap;
> +    uint64_t mcg_status;
> +    uint64_t mcg_ctl;
> +    uint64_t mce_banks[MCE_BANKS_DEF*4];
>  
>      uint64_t tsc_aux;