From: Jakub Narebski <jnareb@gmail.com>
To: "Jürgen Kreileder" <jk@blackdown.de>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] Make feed title valid utf8
Date: Tue, 29 Nov 2011 11:48:39 -0800 (PST) [thread overview]
Message-ID: <m38vmylnfu.fsf@localhost.localdomain> (raw)
In-Reply-To: <CAKD0UuxFVtCRT+hqO5vkDRanaX3Gvwf9MAFqNUwAiFA+wEwxXg@mail.gmail.com>
Subject: gitweb: Make feed title valid utf8
Jürgen Kreileder <jk@blackdown.de> writes:
> gitweb doesn't properly handle UTF8 site names when generating feed titles.
>
> Signed-off-by: Juergen Kreileder <jk@blackdown.de>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..a2838c3 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7482,7 +7482,7 @@ sub git_feed {
> return if ($cgi->request_method() eq 'HEAD');
>
> # header variables
> - my $title = "$site_name - $project/$action";
> + my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
> my $feed_type = 'log';
> if (defined $hash) {
> $title .= " - '$hash'";
> --
Thanks. With the minor nit of prefixing subject with subsystem
designation, i.e. with "gitweb: " -- ACK.
--
Jakub Narębski
next prev parent reply other threads:[~2011-11-29 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 22:37 [PATCH] Make feed title valid utf8 Jürgen Kreileder
2011-11-29 19:48 ` Jakub Narebski [this message]
2011-11-29 20:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38vmylnfu.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jk@blackdown.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.