[PATCH] Make feed title valid utf8

[PATCH] Make feed title valid utf8

[Jürgen Kreileder]

gitweb doesn't properly handle UTF8 site names when generating feed titles.

Signed-off-by: Juergen Kreileder <jk@blackdown.de>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4f0c3bd..a2838c3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7482,7 +7482,7 @@ sub git_feed {
 	return if ($cgi->request_method() eq 'HEAD');

 	# header variables
-	my $title = "$site_name - $project/$action";
+	my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
 	my $feed_type = 'log';
 	if (defined $hash) {
 		$title .= " - '$hash'";
-- 
1.7.5.4

Re: [PATCH] Make feed title valid utf8

[Jakub Narebski]

Subject: gitweb: Make feed title valid utf8

Jürgen Kreileder <jk@blackdown.de> writes:

> gitweb doesn't properly handle UTF8 site names when generating feed titles.
> 
> Signed-off-by: Juergen Kreileder <jk@blackdown.de>
> ---
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..a2838c3 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7482,7 +7482,7 @@ sub git_feed {
>  	return if ($cgi->request_method() eq 'HEAD');
> 
>  	# header variables
> -	my $title = "$site_name - $project/$action";
> +	my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
>  	my $feed_type = 'log';
>  	if (defined $hash) {
>  		$title .= " - '$hash'";
> -- 

Thanks.  With the minor nit of prefixing subject with subsystem
designation, i.e. with "gitweb: " -- ACK.

-- 
Jakub Narębski

Re: [PATCH] Make feed title valid utf8

[Junio C Hamano]

Thanks for patches and reviews.

I am not keeping track of what is acked unconditionally, what is acked
with reservation i.e. "with this tweak on top", and what is rejected with
suggestion of an alternative, though. I hope I can expect to see a series
that is finished between you two to be resent for application after 1.7.8
ships.