* [PATCH] Make feed title valid utf8
@ 2011-11-27 22:37 Jürgen Kreileder
2011-11-29 19:48 ` Jakub Narebski
0 siblings, 1 reply; 3+ messages in thread
From: Jürgen Kreileder @ 2011-11-27 22:37 UTC (permalink / raw)
To: git
gitweb doesn't properly handle UTF8 site names when generating feed titles.
Signed-off-by: Juergen Kreileder <jk@blackdown.de>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4f0c3bd..a2838c3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -7482,7 +7482,7 @@ sub git_feed {
return if ($cgi->request_method() eq 'HEAD');
# header variables
- my $title = "$site_name - $project/$action";
+ my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
my $feed_type = 'log';
if (defined $hash) {
$title .= " - '$hash'";
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Make feed title valid utf8
2011-11-27 22:37 [PATCH] Make feed title valid utf8 Jürgen Kreileder
@ 2011-11-29 19:48 ` Jakub Narebski
2011-11-29 20:11 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Narebski @ 2011-11-29 19:48 UTC (permalink / raw)
To: Jürgen Kreileder; +Cc: git, Jakub Narebski
Subject: gitweb: Make feed title valid utf8
Jürgen Kreileder <jk@blackdown.de> writes:
> gitweb doesn't properly handle UTF8 site names when generating feed titles.
>
> Signed-off-by: Juergen Kreileder <jk@blackdown.de>
> ---
> gitweb/gitweb.perl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 4f0c3bd..a2838c3 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7482,7 +7482,7 @@ sub git_feed {
> return if ($cgi->request_method() eq 'HEAD');
>
> # header variables
> - my $title = "$site_name - $project/$action";
> + my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action";
> my $feed_type = 'log';
> if (defined $hash) {
> $title .= " - '$hash'";
> --
Thanks. With the minor nit of prefixing subject with subsystem
designation, i.e. with "gitweb: " -- ACK.
--
Jakub Narębski
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Make feed title valid utf8
2011-11-29 19:48 ` Jakub Narebski
@ 2011-11-29 20:11 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2011-11-29 20:11 UTC (permalink / raw)
To: Jakub Narebski; +Cc: Jürgen Kreileder, git
Thanks for patches and reviews.
I am not keeping track of what is acked unconditionally, what is acked
with reservation i.e. "with this tweak on top", and what is rejected with
suggestion of an alternative, though. I hope I can expect to see a series
that is finished between you two to be resent for application after 1.7.8
ships.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-29 20:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-27 22:37 [PATCH] Make feed title valid utf8 Jürgen Kreileder
2011-11-29 19:48 ` Jakub Narebski
2011-11-29 20:11 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.