From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: ixp4xx: move indirect I/O into common-pci.c
Date: Mon, 15 Feb 2016 08:07:52 +0100 [thread overview]
Message-ID: <m3egcebgdz.fsf@t19.piap.pl> (raw)
In-Reply-To: <1454689262-613421-3-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:50 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The pointer comparison in is_pci_memory() confuses gcc, so it
> starts throwing bogus warnings about the use of possibly uninitialized
> variables:
>
> drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
> arch/arm/include/asm/io.h:101:2: error: 'px_is' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/crypto/ixp4xx_crypto.c: In function 'aead_perform':
> drivers/crypto/ixp4xx_crypto.c:1072:5: error: 'lastlen' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The code is that gets warned about is correct, and we should not warn
> about this. Moving the code into a .c file makes the object files
> smaller and avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-ixp4xx/common-pci.c | 98 ++++++++++++++++++++++++++++++++++
> arch/arm/mach-ixp4xx/include/mach/io.h | 95 +++-----------------------------
> 2 files changed, 104 insertions(+), 89 deletions(-)
Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
WARNING: multiple messages have this Message-ID (diff)
From: khalasa@piap.pl (Krzysztof Hałasa)
To: Arnd Bergmann <arnd@arndb.de>
Cc: Imre Kaloz <kaloz@openwrt.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: ixp4xx: move indirect I/O into common-pci.c
Date: Mon, 15 Feb 2016 08:07:52 +0100 [thread overview]
Message-ID: <m3egcebgdz.fsf@t19.piap.pl> (raw)
In-Reply-To: <1454689262-613421-3-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:50 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The pointer comparison in is_pci_memory() confuses gcc, so it
> starts throwing bogus warnings about the use of possibly uninitialized
> variables:
>
> drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
> arch/arm/include/asm/io.h:101:2: error: 'px_is' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/crypto/ixp4xx_crypto.c: In function 'aead_perform':
> drivers/crypto/ixp4xx_crypto.c:1072:5: error: 'lastlen' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The code is that gets warned about is correct, and we should not warn
> about this. Moving the code into a .c file makes the object files
> smaller and avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-ixp4xx/common-pci.c | 98 ++++++++++++++++++++++++++++++++++
> arch/arm/mach-ixp4xx/include/mach/io.h | 95 +++-----------------------------
> 2 files changed, 104 insertions(+), 89 deletions(-)
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-02-15 7:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 16:20 [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read, write}s{b, w, l} Arnd Bergmann
2016-02-05 16:20 ` [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read,write}s{b,w,l} Arnd Bergmann
2016-02-05 16:20 ` [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing Arnd Bergmann
2016-02-05 16:20 ` Arnd Bergmann
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-05 16:20 ` [PATCH 3/3] ARM: ixp4xx: move indirect I/O into common-pci.c Arnd Bergmann
2016-02-05 16:20 ` Arnd Bergmann
2016-02-15 7:07 ` Krzysztof Hałasa [this message]
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-15 7:05 ` [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read, write}s{b, w, l} Krzysztof Hałasa
2016-02-15 7:05 ` [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read,write}s{b,w,l} Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3egcebgdz.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.