From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read, write}s{b, w, l}
Date: Mon, 15 Feb 2016 08:05:54 +0100 [thread overview]
Message-ID: <m3mvr2bgh9.fsf@t19.piap.pl> (raw)
In-Reply-To: <1454689262-613421-1-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:48 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> ixp4xx defines the arguments to its __indirect_writesb() and other
> functions as pointers to fixed-size data. This is not necessarily
> wrong, and it works most of the time, but it causes warnings in
> at least one driver:
>
> drivers/net/ethernet/smsc/smc91x.c: In function 'smc_rcv':
> drivers/net/ethernet/smsc/smc91x.c:495:21: error: passing argument 2 of '__indirect_readsw' from incompatible pointer type [-Werror=incompatible-pointer-types]
> SMC_PULL_DATA(lp, data, packet_len - 4);
>
> All other definitions of the same functions pass void pointers,
> so doing the same here avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-ixp4xx/include/mach/io.h | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
WARNING: multiple messages have this Message-ID (diff)
From: khalasa@piap.pl (Krzysztof Hałasa)
To: Arnd Bergmann <arnd@arndb.de>
Cc: Imre Kaloz <kaloz@openwrt.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read,write}s{b,w,l}
Date: Mon, 15 Feb 2016 08:05:54 +0100 [thread overview]
Message-ID: <m3mvr2bgh9.fsf@t19.piap.pl> (raw)
In-Reply-To: <1454689262-613421-1-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:48 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> ixp4xx defines the arguments to its __indirect_writesb() and other
> functions as pointers to fixed-size data. This is not necessarily
> wrong, and it works most of the time, but it causes warnings in
> at least one driver:
>
> drivers/net/ethernet/smsc/smc91x.c: In function 'smc_rcv':
> drivers/net/ethernet/smsc/smc91x.c:495:21: error: passing argument 2 of '__indirect_readsw' from incompatible pointer type [-Werror=incompatible-pointer-types]
> SMC_PULL_DATA(lp, data, packet_len - 4);
>
> All other definitions of the same functions pass void pointers,
> so doing the same here avoids the warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-ixp4xx/include/mach/io.h | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-02-15 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 16:20 [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read, write}s{b, w, l} Arnd Bergmann
2016-02-05 16:20 ` [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read,write}s{b,w,l} Arnd Bergmann
2016-02-05 16:20 ` [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing Arnd Bergmann
2016-02-05 16:20 ` Arnd Bergmann
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-05 16:20 ` [PATCH 3/3] ARM: ixp4xx: move indirect I/O into common-pci.c Arnd Bergmann
2016-02-05 16:20 ` Arnd Bergmann
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-15 7:07 ` Krzysztof Hałasa
2016-02-15 7:05 ` Krzysztof Hałasa [this message]
2016-02-15 7:05 ` [PATCH 1/3] ARM: ixp4xx: use normal prototype for {read,write}s{b,w,l} Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mvr2bgh9.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.