From: Andreas Schwab <schwab@suse.de>
To: Anup Patel <anup@brainfault.org>
Cc: Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Palmer Dabbelt <palmer@sifive.com>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <atish.patra@wdc.com>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] tty/serial: emit CR before NL in RISC-V SBL console
Date: Thu, 10 Jan 2019 16:26:46 +0100 [thread overview]
Message-ID: <mvm7efcedop.fsf@suse.de> (raw)
In-Reply-To: <CAAhSdy3-SaP7RBbgx7kZgkkxeN2W-Ue8QDFXkOgFG5GiAg52-g@mail.gmail.com> (Anup Patel's message of "Thu, 10 Jan 2019 20:46:51 +0530")
On Jan 10 2019, Anup Patel <anup@brainfault.org> wrote:
> Instead of doing '\n' handling here, we should do it in BBL or
> OpenSBI (i.e. SBI runtime firmware) otherwise all users of
> SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD,
> FreeRTOS, U-Boot S-mode, etc) will endup having '\n'
> handling.
I don't think the serial driver should do NLCR handling on its own,
without being instructed by the tty layer. Since the earlycon does not
have a tty layer, it needs to handle it explicitly.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Anup Patel <anup@brainfault.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <atish.patra@wdc.com>,
Christoph Hellwig <hch@infradead.org>,
Rob Herring <robh@kernel.org>,
linux-riscv@lists.infradead.org,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty/serial: emit CR before NL in RISC-V SBL console
Date: Thu, 10 Jan 2019 16:26:46 +0100 [thread overview]
Message-ID: <mvm7efcedop.fsf@suse.de> (raw)
In-Reply-To: <CAAhSdy3-SaP7RBbgx7kZgkkxeN2W-Ue8QDFXkOgFG5GiAg52-g@mail.gmail.com> (Anup Patel's message of "Thu, 10 Jan 2019 20:46:51 +0530")
On Jan 10 2019, Anup Patel <anup@brainfault.org> wrote:
> Instead of doing '\n' handling here, we should do it in BBL or
> OpenSBI (i.e. SBI runtime firmware) otherwise all users of
> SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD,
> FreeRTOS, U-Boot S-mode, etc) will endup having '\n'
> handling.
I don't think the serial driver should do NLCR handling on its own,
without being instructed by the tty layer. Since the earlycon does not
have a tty layer, it needs to handle it explicitly.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@suse.de>
To: Anup Patel <anup@brainfault.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <atish.patra@wdc.com>,
Christoph Hellwig <hch@infradead.org>,
Rob Herring <robh@kernel.org>,
linux-riscv@lists.infradead.org,
"linux-kernel\@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty/serial: emit CR before NL in RISC-V SBL console
Date: Thu, 10 Jan 2019 16:26:46 +0100 [thread overview]
Message-ID: <mvm7efcedop.fsf@suse.de> (raw)
In-Reply-To: <CAAhSdy3-SaP7RBbgx7kZgkkxeN2W-Ue8QDFXkOgFG5GiAg52-g@mail.gmail.com> (Anup Patel's message of "Thu, 10 Jan 2019 20:46:51 +0530")
On Jan 10 2019, Anup Patel <anup@brainfault.org> wrote:
> Instead of doing '\n' handling here, we should do it in BBL or
> OpenSBI (i.e. SBI runtime firmware) otherwise all users of
> SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD,
> FreeRTOS, U-Boot S-mode, etc) will endup having '\n'
> handling.
I don't think the serial driver should do NLCR handling on its own,
without being instructed by the tty layer. Since the earlycon does not
have a tty layer, it needs to handle it explicitly.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-01-10 15:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 13:55 [PATCH 0/3] RISC-V SBI earlycon Anup Patel
2018-12-04 13:55 ` Anup Patel
2018-12-04 13:55 ` [PATCH 1/3] tty/serial: Add RISC-V SBI earlycon support Anup Patel
2018-12-04 13:55 ` Anup Patel
2018-12-05 9:58 ` Greg Kroah-Hartman
2018-12-05 9:58 ` Greg Kroah-Hartman
2018-12-07 18:45 ` Palmer Dabbelt
2018-12-07 18:45 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2019-01-10 14:07 ` [PATCH] tty/serial: emit CR before NL in RISC-V SBL console Andreas Schwab
2019-01-10 14:07 ` Andreas Schwab
2019-01-10 15:16 ` Anup Patel
2019-01-10 15:16 ` Anup Patel
2019-01-10 15:26 ` Andreas Schwab [this message]
2019-01-10 15:26 ` Andreas Schwab
2019-01-10 15:26 ` Andreas Schwab
2019-01-10 16:17 ` Anup Patel
2019-01-10 16:17 ` Anup Patel
2019-01-10 17:11 ` [PATCH] tty/serial: use uart_console_write in the RISC-V SBL early console Andreas Schwab
2019-01-10 17:11 ` Andreas Schwab
2019-01-10 17:11 ` Andreas Schwab
2019-01-11 11:13 ` Anup Patel
2019-01-11 11:13 ` Anup Patel
2019-01-23 23:58 ` Palmer Dabbelt
2019-01-23 23:58 ` Palmer Dabbelt
2019-01-15 13:59 ` Christoph Hellwig
2019-01-15 13:59 ` Christoph Hellwig
2019-01-10 20:54 ` [PATCH] tty/serial: emit CR before NL in RISC-V SBL console Palmer Dabbelt
2019-01-10 20:54 ` Palmer Dabbelt
2018-12-04 13:55 ` [PATCH 2/3] RISC-V: defconfig: Enable RISC-V SBI earlycon support Anup Patel
2018-12-04 13:55 ` Anup Patel
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-04 13:55 ` [PATCH 3/3] RISC-V: Remove EARLY_PRINTK support Anup Patel
2018-12-04 13:55 ` Anup Patel
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` [PATCH 0/3] RISC-V SBI earlycon Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2019-03-25 16:23 ` Andreas Schwab
2019-03-25 16:23 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvm7efcedop.fsf@suse.de \
--to=schwab@suse.de \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.