* Re: [PATCH] Bluetooth: Increase HCI reset timeout in hci_dev_do_close
From: Gustavo Padovan @ 2011-10-31 19:23 UTC (permalink / raw)
To: Szymon Janc; +Cc: linux-bluetooth
In-Reply-To: <1318885549-14784-2-git-send-email-szymon@janc.net.pl>
Hi Szymon,
* Szymon Janc <szymon@janc.net.pl> [2011-10-17 23:05:49 +0200]:
> Signed-off-by: Szymon Janc <szymon@janc.net.pl>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to the bluetooth tree, thanks.
Gustavo
^ permalink raw reply
* Re: [PATCH v2] Bluetooth: Use miliseconds for L2CAP channel timeouts
From: Gustavo Padovan @ 2011-10-31 19:22 UTC (permalink / raw)
To: Andrzej Kaczmarek; +Cc: linux-bluetooth, ulrik.lauren, henrik.possung
In-Reply-To: <1319095026-12517-1-git-send-email-andrzej.kaczmarek@tieto.com>
Hi Andrzej,
* Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com> [2011-10-20 09:17:06 +0200]:
> Timers set by __set_chan_timer() should use miliseconds instead of
> jiffies. Commit 942ecc9c4643db5ce071562e0a23f99464d6b461 updated
> l2cap_set_timer() so it expects timeout to be specified in msecs
> instead of jiffies. This makes timeouts unreliable when CONFIG_HZ
> is not set to 1000.
>
> Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
> ---
> include/net/bluetooth/l2cap.h | 7 +++++--
> net/bluetooth/l2cap_core.c | 16 ++++++++--------
> 2 files changed, 13 insertions(+), 10 deletions(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
^ permalink raw reply
* [Qemu-devel] [PATCH v2 4/4] cocoa: Close sheet after image file selection
From: Andreas Färber @ 2011-10-31 19:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber, Juan Pineda
In-Reply-To: <1320088682-12958-1-git-send-email-andreas.faerber@web.de>
If no disk image is specified, the Cocoa frontend displays a modal sheet
to let the user select an image file to boot from.
This sheet is never closed and it permanently obscures the emulator window.
Close it after obtaining the file name in case the user did select a file.
Otherwise we exit immediately, so no need to close then.
Signed-off-by: Juan Pineda <juan@logician.com>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
ui/cocoa.m | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index d9e4e3d..0711205 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -811,6 +811,8 @@ QemuCocoaView *cocoaView;
char **argv = (char**)malloc( sizeof(char*)*3 );
+ [sheet close];
+
asprintf(&argv[0], "%s", bin);
asprintf(&argv[1], "-hda");
asprintf(&argv[2], "%s", img);
--
1.7.0.3
^ permalink raw reply related
* [Qemu-devel] [PATCH v2 3/4] vl.c: Guard against GThread double-initialization
From: Andreas Färber @ 2011-10-31 19:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber
In-Reply-To: <1320088682-12958-1-git-send-email-andreas.faerber@web.de>
GThread-ERROR **: GThread system may only be initialized once.
aborting...
Making the g_thread_init() call in vl.c conditional resolves an abort on
Mac OS X, where coroutine-gthread.c seems to call it before vl.c.
Reported-by: Juan Pineda <juan@logician.com>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Daniel P. Berrange <berrange@redhat.com>
---
vl.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index 1ddb17b..46b2909 100644
--- a/vl.c
+++ b/vl.c
@@ -2185,7 +2185,9 @@ int main(int argc, char **argv, char **envp)
error_set_progname(argv[0]);
g_mem_set_vtable(&mem_trace);
- g_thread_init(NULL);
+ if (!g_thread_supported()) {
+ g_thread_init(NULL);
+ }
runstate_init();
--
1.7.0.3
^ permalink raw reply related
* Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind
From: Anthony Liguori @ 2011-10-31 19:19 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel, Avi Kivity
In-Reply-To: <4EAEF0FB.9030802@weilnetz.de>
On 10/31/2011 02:03 PM, Stefan Weil wrote:
> Am 31.10.2011 19:13, schrieb Anthony Liguori:
>> On 10/30/2011 07:07 AM, Stefan Weil wrote:
>>> Valgrind is a tool which can automatically detect many kinds of bugs.
>>>
>>> Running QEMU on Valgrind with x86_64 hosts was not possible because
>>> Valgrind aborts when memalign is called with an alignment larger than
>>> 1 MiB. QEMU normally uses 2 MiB on Linux x86_64.
>>>
>>> Now the alignment is reduced to the page size when QEMU is running on
>>> Valgrind.
>>>
>>> valgrind.h is a copy from Valgrind svn trunk r12226 with trailing
>>> whitespace stripped but otherwise unmodified, so it still raises lots
>>> of errors when checked with scripts/checkpatch.pl.
>>>
>>> It is included here to avoid a dependency on Valgrind.
>>>
>>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>>
>> How about we just fix valgrind?
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> Do you think that Valgrind will be fixed before tests of QEMU 1.0 start?
> I don't, and I think that using Valgrind should be part of these tests!
>
> I'd add the patch now. As soon as Valgrind is fixed, it can be reverted.
> Or we add another patch with the Valgrind hack from libvirt.
I definitely don't want to pull in a valgrind header. The LD_PRELOAD check
seems a bit ugly but I'd rather carry that as an intermediate solution.
Regards,
Anthony Liguori
>
> Regards,
> Stefan Weil
>
>
^ permalink raw reply
* [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin
From: Andreas Färber @ 2011-10-31 19:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Andreas Färber, Juan Pineda
In-Reply-To: <1320088682-12958-1-git-send-email-andreas.faerber@web.de>
In file included from ./bswap.h:7,
from ./qemu-common.h:106,
from ./qemu-aio.h:17,
from ./Block.h:4,
from /System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:28,
from /System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/CarbonCore.h:218,
from /System/Library/Frameworks/CoreServices.framework/Frameworks/AE.framework/Headers/AE.h:20,
from /System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:21,
from /System/Library/Frameworks/Foundation.framework/Headers/NSURLError.h:17,
from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:81,
from /System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12,
from ui/cocoa.m:25:
/Users/andreas/QEMU/qemu/fpu/softfloat.h:60: error: conflicting types for ‘uint16’
/System/Library/Frameworks/Security.framework/Headers/cssmconfig.h:73: error: previous declaration of ‘uint16’ was here
make: *** [ui/cocoa.o] Error 1
Apple's FSEvents.h has #include <Block.h>, which wants
/usr/include/Block.h but due to case-insensitive file system and
include path jungle gets QEMU's ./block.h, which in turn includes
softfloat.h indirectly.
Therefore work around the conflict in softfloat.h itself
by renaming specifically uint16 on Darwin to qemu_uint16.
This fixes the build until we have a more general solution.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Juan Pineda <juan@logician.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
fpu/softfloat.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fpu/softfloat.h b/fpu/softfloat.h
index 07c2929..5320945 100644
--- a/fpu/softfloat.h
+++ b/fpu/softfloat.h
@@ -54,6 +54,9 @@ these four paragraphs for those parts of this code that are retained.
| to the same as `int'.
*----------------------------------------------------------------------------*/
typedef uint8_t flag;
+#ifdef __APPLE__
+#define uint16 qemu_uint16
+#endif
typedef uint8_t uint8;
typedef int8_t int8;
#ifndef _AIX
--
1.7.0.3
^ permalink raw reply related
* [Qemu-devel] [PATCH v2 1/4] MAINTAINERS: Add Cocoa maintainer
From: Andreas Färber @ 2011-10-31 19:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber, Anthony Liguori
In-Reply-To: <1320088682-12958-1-git-send-email-andreas.faerber@web.de>
Degrade cocoa.m from Maintained to Odd Fixes.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>
---
MAINTAINERS | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2b4c5d7..c08951c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -446,6 +446,11 @@ M: Anthony Liguori <aliguori@us.ibm.com>
S: Maintained
F: ui/
+Cocoa graphics
+M: Andreas Färber <andreas.faerber@web.de>
+S: Odd Fixes
+F: ui/cocoa.m
+
Main loop
M: Anthony Liguori <aliguori@us.ibm.com>
S: Supported
--
1.7.0.3
^ permalink raw reply related
* [Qemu-devel] [PATCH v2 0/4] Cocoa patches for 1.0
From: Andreas Färber @ 2011-10-31 19:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber
Hello,
Here's an updated series, including a runtime abort fix and a GUI bugfix.
Note: Patch 3/4 touches generic code.
Regards,
Andreas
Andreas Färber (4):
MAINTAINERS: Add Cocoa maintainer
softfloat: Avoid uint16 type conflict on Darwin
vl.c: Guard against GThread double-initialization
cocoa: Close sheet after image file selection
MAINTAINERS | 5 +++++
fpu/softfloat.h | 3 +++
ui/cocoa.m | 2 ++
vl.c | 4 +++-
4 files changed, 13 insertions(+), 1 deletions(-)
^ permalink raw reply
* Re: [PATCH 1/2] add device entry for Broadcom Valentine combo card
From: Gustavo Padovan @ 2011-10-31 19:18 UTC (permalink / raw)
To: Cho, Yu-Chen; +Cc: marcel, linux-bluetooth, linux-kernel, acho, jlee, oneukum
In-Reply-To: <2eb6d1b761a3fddea28294959bde7e9c7ef88043.1319086508.git.acho@suse.com>
Hi Yu-Chen,
* Cho, Yu-Chen <acho@suse.com> [2011-10-20 12:58:29 +0800]:
> This device declares itself to be vendor specific
> It therefore needs to be added to the device table
> to make btusb bind.
It would be good to have the output of usb-devices for this specific device in
the commit message.
Gustavo
^ permalink raw reply
* Re: [Qemu-devel] [PATCH] linux-user: add binfmt wrapper for argv[0] handling
From: Riku Voipio @ 2011-10-31 19:16 UTC (permalink / raw)
To: Alexander Graf; +Cc: vagrant, J.Schauer, qemu-devel Developers, Reinhard Max
In-Reply-To: <B6080630-C4FC-4AA6-95FC-59EF6A6F8D57@suse.de>
On Sat, Oct 29, 2011 at 08:08:39PM +0200, Alexander Graf wrote:
> > When using qemu's linux-user binaries through binfmt, argv[0] gets lost
> > along the execution because qemu only gets passed in the full file name
> > to the executable while argv[0] can be something completely different.
> >
> > This breaks in some subtile situations, such as the grep and make test
> > suites.
> >
> > This patch adds a wrapper binary called qemu-$TARGET-binfmt that can be
> > used with binfmt's P flag which passes the full path _and_ argv[0] to
> > the binfmt handler.
> >
> > The binary would be smart enough to be versatile and only exist in the
> > system once, creating the qemu binary path names from its own argv[0].
> > However, this seemed like it didn't fit the make system too well, so
> > we're currently creating a new binary for each target archictecture.
> >
> > CC: Reinhard Max <max@suse.de>
> > Signed-off-by: Alexander Graf <agraf@suse.de>
> Ping?
Last time a wrapper for binfmt was suggested on this list, it was shot down
since people didn't want to add extra binary to the chroot. But your point
is valid, without proper argv[0] things break sometimes. For the same reason
scratchbox has a wrapper binary instead of calling qemu directly...
Riku
^ permalink raw reply
* Re: [PATCH 00/16] more mac68k fixes and cleanup
From: Geert Uytterhoeven @ 2011-10-31 19:16 UTC (permalink / raw)
To: Finn Thain; +Cc: linux-m68k
In-Reply-To: <CAMuHMdUGjity+yvTyShmTLF3qtw0b=DqB5cjtDgec3p_vJG=fA@mail.gmail.com>
On Mon, Oct 31, 2011 at 19:35, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> I suppose that after all of the renaming recently this series will need
>> to be rebased (?)
>
> "git am" is smart enough to detect that drivers/net/ got restructured.
Doh, s/am/rebase/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Reference has invalid format: check maybe a bit to harsh?
From: Peter Oberndorfer @ 2011-10-31 19:14 UTC (permalink / raw)
To: git; +Cc: Michael Haggerty
Hi,
i am using the next branch for testing and i noticed the following:
about any git command i execute in a certain repo dies with
fatal: Reference has invalid format:
'refs/patches/obd_development/blah:_various_improvements_remote_debugging'
This is probably caused by
dce4bab6567de7c458b334e029e3dedcab5f2648 add_ref(): verify that the refname is
formatted correctly
The invalid refs(about 30, loose and packed) containing a ':' were created by
stgit a long time ago(Dec 2006)
Personally i do not care too much, i patched my git to not die at this point
but to only display a error.
-> The invalid refs are not accessible, but the rest of the repo still works.
But i'm just wondering if dieing when seeing a single invalid ref might be a
bit too harsh since no git tools can be used anymore on this repo at all.
Small side note:
It seems t1402-check-ref-format.sh contains not test
for the invalid ref char ':' yet.
(i do not know if it is tested somewhere else...)
Thanks,
Greetings Peter
^ permalink raw reply
* Re: [libvirt] [RFC PATCH v3 3/4] qemu: pass virConnectPtr into Domain{Attach, Detach}*
From: Eric Blake @ 2011-10-31 19:14 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: Josh Durgin, libvir-list, ceph-devel
In-Reply-To: <20111027083324.GC20878@redhat.com>
On 10/27/2011 02:33 AM, Daniel P. Berrange wrote:
> On Thu, Oct 20, 2011 at 11:01:26AM -0700, Josh Durgin wrote:
>> From: Sage Weil<sage@newdream.net>
>>
>> The qemu RBD driver needs access to the conn in order to get the secret
>> needed for connecting to the ceph cluster.
>>
>> Signed-off-by: Sage Weil<sage@newdream.net>
>> ---
>> src/qemu/qemu_command.c | 5 +++--
>> src/qemu/qemu_command.h | 3 ++-
>> src/qemu/qemu_driver.c | 17 ++++++++---------
>> src/qemu/qemu_hotplug.c | 15 +++++++++------
>> src/qemu/qemu_hotplug.h | 9 ++++++---
>> 5 files changed, 28 insertions(+), 21 deletions(-)
>
> Trivial, ACK
Now pushed.
--
Eric Blake eblake@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
^ permalink raw reply
* [PATCH] vfs: Export fallocate facility to kernel modules
From: Thieu Le @ 2011-10-31 19:14 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, Thieu Le
Export fallocate facility so layered file systems such as ecryptfs can
take advantage of this feature. One example of the need for fallocate
is by ecryptfs. ecryptfs has recently switched to a writeback cache
model so its dirty pages are not written to the lower file system
immediately. In order to ensure that space is available when the page
is later written, ecryptfs can efficiently preallocate that space using
vfs_fallocate().
vfs_fallocate() does not perform all of the checkings of do_fallocate()
because those checks are done higher in the stack. Checking of offset and
len are done by rw_verify_area() and generic_write_checks(). These
functions are called by VFS before ecryptfs invokes vfs_fallocate() in its
ecryptfs_write_end() function. And since ecryptfs directly opens the lower
file, it ensures that the file is opened with the proper flags and mode.
Signed-off-by: Thieu Le <thieule@chromium.org>
---
fs/open.c | 14 ++++++++++----
include/linux/fs.h | 2 ++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index f711921..8a4ba20 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -214,6 +214,15 @@ SYSCALL_ALIAS(sys_ftruncate64, SyS_ftruncate64);
#endif /* BITS_PER_LONG == 32 */
+int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
+{
+ if (!file->f_op->fallocate)
+ return -EOPNOTSUPP;
+
+ return file->f_op->fallocate(file, mode, offset, len);
+}
+EXPORT_SYMBOL(vfs_fallocate);
+
int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
{
struct inode *inode = file->f_path.dentry->d_inode;
@@ -263,10 +272,7 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0))
return -EFBIG;
- if (!file->f_op->fallocate)
- return -EOPNOTSUPP;
-
- return file->f_op->fallocate(file, mode, offset, len);
+ return vfs_fallocate(file, mode, offset, len);
}
SYSCALL_DEFINE(fallocate)(int fd, int mode, loff_t offset, loff_t len)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 277f497..c0e1225 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1504,6 +1504,8 @@ extern int vfs_link(struct dentry *, struct inode *, struct dentry *);
extern int vfs_rmdir(struct inode *, struct dentry *);
extern int vfs_unlink(struct inode *, struct dentry *);
extern int vfs_rename(struct inode *, struct dentry *, struct inode *, struct dentry *);
+extern int vfs_fallocate(struct file *file, int mode, loff_t offset,
+ loff_t len);
/*
* VFS dentry helper functions.
--
1.7.3.1
^ permalink raw reply related
* [PATCH 3/3] MSVC: Remove unneeded header stubs
From: Vincent van Ravesteijn @ 2011-10-31 19:12 UTC (permalink / raw)
To: git; +Cc: kusmabite, ramsay, msysgit, gitster, Vincent van Ravesteijn
In-Reply-To: <1320088364-25916-1-git-send-email-vfr@lyx.org>
These headers are no longer needed since they are no longer
unnecessarily included in git-compat-util.h.
Signed-off-by: Vincent van Ravesteijn <vfr@lyx.org>
---
compat/vcbuild/include/arpa/inet.h | 1 -
compat/vcbuild/include/grp.h | 1 -
compat/vcbuild/include/inttypes.h | 1 -
compat/vcbuild/include/netdb.h | 1 -
compat/vcbuild/include/netinet/in.h | 1 -
compat/vcbuild/include/netinet/tcp.h | 1 -
compat/vcbuild/include/pwd.h | 1 -
compat/vcbuild/include/sys/ioctl.h | 1 -
compat/vcbuild/include/sys/select.h | 1 -
compat/vcbuild/include/sys/socket.h | 1 -
compat/vcbuild/include/sys/wait.h | 1 -
compat/vcbuild/include/termios.h | 1 -
12 files changed, 0 insertions(+), 12 deletions(-)
delete mode 100644 compat/vcbuild/include/arpa/inet.h
delete mode 100644 compat/vcbuild/include/grp.h
delete mode 100644 compat/vcbuild/include/inttypes.h
delete mode 100644 compat/vcbuild/include/netdb.h
delete mode 100644 compat/vcbuild/include/netinet/in.h
delete mode 100644 compat/vcbuild/include/netinet/tcp.h
delete mode 100644 compat/vcbuild/include/pwd.h
delete mode 100644 compat/vcbuild/include/sys/ioctl.h
delete mode 100644 compat/vcbuild/include/sys/select.h
delete mode 100644 compat/vcbuild/include/sys/socket.h
delete mode 100644 compat/vcbuild/include/sys/wait.h
delete mode 100644 compat/vcbuild/include/termios.h
diff --git a/compat/vcbuild/include/arpa/inet.h b/compat/vcbuild/include/arpa/inet.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/arpa/inet.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/grp.h b/compat/vcbuild/include/grp.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/grp.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/inttypes.h b/compat/vcbuild/include/inttypes.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/inttypes.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/netdb.h b/compat/vcbuild/include/netdb.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/netdb.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/netinet/in.h b/compat/vcbuild/include/netinet/in.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/netinet/in.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/netinet/tcp.h b/compat/vcbuild/include/netinet/tcp.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/netinet/tcp.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/pwd.h b/compat/vcbuild/include/pwd.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/pwd.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/sys/ioctl.h b/compat/vcbuild/include/sys/ioctl.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/sys/ioctl.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/sys/select.h b/compat/vcbuild/include/sys/select.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/sys/select.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/sys/socket.h b/compat/vcbuild/include/sys/socket.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/sys/socket.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/sys/wait.h b/compat/vcbuild/include/sys/wait.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/sys/wait.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
diff --git a/compat/vcbuild/include/termios.h b/compat/vcbuild/include/termios.h
deleted file mode 100644
index 0d8552a..0000000
--- a/compat/vcbuild/include/termios.h
+++ /dev/null
@@ -1 +0,0 @@
-/* Intentionally empty file to support building git with MSVC */
--
1.7.4.1
^ permalink raw reply related
* [PATCH 2/3] Compile fix for MSVC: Include <io.h>
From: Vincent van Ravesteijn @ 2011-10-31 19:12 UTC (permalink / raw)
To: git; +Cc: kusmabite, ramsay, msysgit, gitster, Vincent van Ravesteijn
In-Reply-To: <1320088364-25916-1-git-send-email-vfr@lyx.org>
This include is needed for _commit(..) which is used in mingw.h.
Signed-off-by: Vincent van Ravesteijn <vfr@lyx.org>
---
compat/msvc.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/compat/msvc.h b/compat/msvc.h
index a33b01c..aa4b563 100644
--- a/compat/msvc.h
+++ b/compat/msvc.h
@@ -4,6 +4,7 @@
#include <direct.h>
#include <process.h>
#include <malloc.h>
+#include <io.h>
/* porting function */
#define inline __inline
--
1.7.4.1
^ permalink raw reply related
* [PATCH 1/3] Compile fix for MSVC: Do not include sys/resources.h
From: Vincent van Ravesteijn @ 2011-10-31 19:12 UTC (permalink / raw)
To: git; +Cc: kusmabite, ramsay, msysgit, gitster, Vincent van Ravesteijn
In-Reply-To: <1320088364-25916-1-git-send-email-vfr@lyx.org>
Do not include header files when compiling with MSVC that do not
exist and which are also not included when compiling with MINGW.
A direct consequence is that git can be compiled again with MSVC
because the missing "sys/resources.h" is no longer included.
Instead of current
#ifndef mingw32 is the only one that is strange
... everything for systems that is not strange ...
#else
... include mingw specific tweaks ...
#endif
#ifdef msvc is also strange
... include msvc specific tweaks ...
#endif
it turns things around and says what it wants to achieve in a more direct
way, i.e.
#if mingw32
#include "compat/mingw.h"
#elif msvc
#include "compat/msvc.h"
#else
... all the others ...
#endif
which makes it look simpler.
Signed-off-by: Vincent van Ravesteijn <vfr@lyx.org>
Helped-by: Junio C Hamano <gitster@pobox.com>
---
git-compat-util.h | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 5ef8ff7..53186da 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -116,7 +116,12 @@
#else
#include <poll.h>
#endif
-#ifndef __MINGW32__
+#if defined(__MINGW32__)
+/* pull in Windows compatibility stuff */
+#include "compat/mingw.h"
+#elif defined(_MSC_VER)
+#include "compat/msvc.h"
+#else
#include <sys/wait.h>
#include <sys/resource.h>
#include <sys/socket.h>
@@ -145,12 +150,6 @@
#include <grp.h>
#define _ALL_SOURCE 1
#endif
-#else /* __MINGW32__ */
-/* pull in Windows compatibility stuff */
-#include "compat/mingw.h"
-#endif /* __MINGW32__ */
-#ifdef _MSC_VER
-#include "compat/msvc.h"
#endif
#ifndef NO_LIBGEN_H
--
1.7.4.1
^ permalink raw reply related
* [PATCHv2] Compile fix for MSVC
From: Vincent van Ravesteijn @ 2011-10-31 19:12 UTC (permalink / raw)
To: git; +Cc: kusmabite, ramsay, msysgit, gitster
This is a re-roll of the patch series sent to the list
on 21-10-2011.
This time the lines are not wrapped and the commit messages
are updated with changes from me and Junio.
[PATCH 1/3] Compile fix for MSVC: Do not include sys/resources.h
[PATCH 2/3] Compile fix for MSVC: Include <io.h>
[PATCH 3/3] MSVC: Remove unneeded header stubs
^ permalink raw reply
* [U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit
From: Simon Glass @ 2011-10-31 19:11 UTC (permalink / raw)
To: u-boot
In-Reply-To: <1320022463-26410-1-git-send-email-vapier@gentoo.org>
On Sun, Oct 30, 2011 at 5:54 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> If we move the local funcs to the top of the file, and use the
> __maybe_unused define, we can drop a lot of ugly ifdef logic and
> duplicated prototypes.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
This is much cleaner - is the correct style to put attribute tags on
the previous line?
Acked-by: Simon Glass <sjg@chromium.org>
> ---
> ?common/cmd_bdinfo.c | ? 89 ++++++++++++++++++--------------------------------
> ?1 files changed, 32 insertions(+), 57 deletions(-)
>
^ permalink raw reply
* [Qemu-devel] KVM call agenda for November 1st
From: Juan Quintela @ 2011-10-31 19:09 UTC (permalink / raw)
To: KVM devel mailing list, qemu-devel
Hi
Please send in any agenda items you are interested in covering.
Thanks, Juan.
^ permalink raw reply
* KVM call agenda for November 1st
From: Juan Quintela @ 2011-10-31 19:09 UTC (permalink / raw)
To: KVM devel mailing list, qemu-devel
Hi
Please send in any agenda items you are interested in covering.
Thanks, Juan.
^ permalink raw reply
* [Qemu-devel] KVM call agenda for November 1st
From: Juan Quintela @ 2011-10-31 19:09 UTC (permalink / raw)
To: KVM devel mailing list, qemu-devel
Hi
Please send in any agenda items you are interested in covering.
Thanks, Juan.
PD. Tomorrow is a Spanish holiday, so I would not attend the call.
^ permalink raw reply
* KVM call agenda for November 1st
From: Juan Quintela @ 2011-10-31 19:09 UTC (permalink / raw)
To: KVM devel mailing list, qemu-devel
Hi
Please send in any agenda items you are interested in covering.
Thanks, Juan.
PD. Tomorrow is a Spanish holiday, so I would not attend the call.
^ permalink raw reply
* [PATCH 02/17] freezer: don't unnecessarily set PF_NOFREEZE explicitly
From: Tejun Heo @ 2011-10-31 19:05 UTC (permalink / raw)
To: rjw, paul, linux-kernel, linux-pm
Cc: arnd, oleg, matthltc, Tejun Heo, Marcel Holtmann, wwang
In-Reply-To: <1320087928-32307-1-git-send-email-tj@kernel.org>
Some drivers set PF_NOFREEZE in their kthread functions which is
completely unnecessary and racy - some part of freezer code doesn't
consider cases where PF_NOFREEZE is set asynchronous to freezer
operations.
In general, there's no reason to allow setting PF_NOFREEZE explicitly.
Remove them and change the documentation to note that setting
PF_NOFREEZE directly isn't allowed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: "Gustavo F. Padovan" <padovan@profusion.mobi>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: wwang <wei_wang@realsil.com.cn>
---
Documentation/power/freezing-of-tasks.txt | 2 +-
drivers/bluetooth/btmrvl_main.c | 2 --
drivers/mfd/twl4030-irq.c | 3 ---
drivers/mfd/twl6030-irq.c | 2 --
drivers/staging/rts_pstor/rtsx.c | 2 --
5 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/Documentation/power/freezing-of-tasks.txt b/Documentation/power/freezing-of-tasks.txt
index 38b5724..710c965 100644
--- a/Documentation/power/freezing-of-tasks.txt
+++ b/Documentation/power/freezing-of-tasks.txt
@@ -67,7 +67,7 @@ III. Which kernel threads are freezable?
Kernel threads are not freezable by default. However, a kernel thread may clear
PF_NOFREEZE for itself by calling set_freezable() (the resetting of PF_NOFREEZE
-directly is strongly discouraged). From this point it is regarded as freezable
+directly is not allowed). From this point it is regarded as freezable
and must call try_to_freeze() in a suitable place.
IV. Why do we do that?
diff --git a/drivers/bluetooth/btmrvl_main.c b/drivers/bluetooth/btmrvl_main.c
index 548d1d9..57312d4 100644
--- a/drivers/bluetooth/btmrvl_main.c
+++ b/drivers/bluetooth/btmrvl_main.c
@@ -473,8 +473,6 @@ static int btmrvl_service_main_thread(void *data)
init_waitqueue_entry(&wait, current);
- current->flags |= PF_NOFREEZE;
-
for (;;) {
add_wait_queue(&thread->wait_q, &wait);
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 8a7ee31..6aae831 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -289,9 +289,6 @@ static int twl4030_irq_thread(void *data)
static unsigned i2c_errors;
static const unsigned max_i2c_errors = 100;
-
- current->flags |= PF_NOFREEZE;
-
while (!kthread_should_stop()) {
int ret;
int module_irq;
diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index eb3b5f8..6fd7795 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -96,8 +96,6 @@ static int twl6030_irq_thread(void *data)
static const unsigned max_i2c_errors = 100;
int ret;
- current->flags |= PF_NOFREEZE;
-
while (!kthread_should_stop()) {
int i;
union {
diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c
index 480b0ed..8a7803c 100644
--- a/drivers/staging/rts_pstor/rtsx.c
+++ b/drivers/staging/rts_pstor/rtsx.c
@@ -466,8 +466,6 @@ static int rtsx_control_thread(void *__dev)
struct rtsx_chip *chip = dev->chip;
struct Scsi_Host *host = rtsx_to_host(dev);
- current->flags |= PF_NOFREEZE;
-
for (;;) {
if (wait_for_completion_interruptible(&dev->cmnd_ready))
break;
--
1.7.3.1
^ permalink raw reply related
* Re: bigalloc and max file size
From: Andreas Dilger @ 2011-10-31 19:09 UTC (permalink / raw)
To: Sunil Mushran
Cc: Tao Ma, Theodore Tso, linux-ext4 development, Alex Zhuravlev,
hao.bigrat@gmail.com
In-Reply-To: <4EAEEEB6.8010102@oracle.com>
On 2011-10-31, at 12:53 PM, Sunil Mushran wrote:
> On 10/31/2011 03:27 AM, Tao Ma wrote:
>> OK, so let me explain why the big cluster length works.
>>
>> In the new bigalloc case if chunk size=64k, and with the linux-3.0
>> source, every file will be allocated a chunk, but they aren't contiguous
>> if we only write the 1st 4k bytes. In this case, writeback and the block
>> layer below can't merge all the requests sent by ext4. And in our test
>> case, the total io will be around 20000. While with the cluster size, we
>> have to zero the whole cluster. From the upper point of view. we have to
>> write more bytes. But from the block layer, the write is contiguous and
>> it can merge them to be a big one. In our test, it will only do around
>> 2000 ios. So it helps the test case.
>
> Am I missing something but you cannot zero the entire cluster because
> block_write_full_page() drops pages past i_size.
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=5693486bad2bc2ac585a2c24f7e2f3964b478df9
With ext4_ext_zeroout->blkdev_issue_zeroout() it submits the zeroing
request directly to the block layer (with cloned ZERO_PAGE pages) and
skips the VM entirely.
Cheers, Andreas
--
Andreas Dilger
Principal Engineer
Whamcloud, Inc.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.