All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Imre Kaloz" <kaloz@openwrt.org>
To: cooloney@gmail.com, rpurdie@rpsys.net, Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, Matthew.Fatheree@belkin.com,
	linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver
Date: Fri, 09 Jan 2015 13:46:10 +0100	[thread overview]
Message-ID: <op.xr64e8gt2s3iss@ecaz> (raw)
In-Reply-To: <1420763178-10115-3-git-send-email-andrew@lunn.ch>

Hi Andrew,

On Fri, 09 Jan 2015 01:26:18 +0100, Andrew Lunn <andrew@lunn.ch> wrote:

> The TLC59116 is an I2C bus controlled 16-channel LED driver.  Each LED
> output has its own 8-bit fixed-frequency PWM controller to control the
> brightness of the LED.
>
> This is based on a driver from Belkin, but has been extensively
> rewritten.
>
<snip>

> +config LEDS_TLC59116
> +	tristate "LED driver for TLC59116F controllers"
> +	depends on LEDS_CLASS && I2C

I think you need "select REGMAP_I2C" as well.

> +	help
> +	  This option enables support for Texas Instruments TLC59116F
> +	  LED controller.
> +
>  config LEDS_MAX8997
>  	tristate "LED support for MAX8997 PMIC"
>  	depends on LEDS_CLASS && MFD_MAX8997



Imre

WARNING: multiple messages have this Message-ID (diff)
From: kaloz@openwrt.org (Imre Kaloz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] leds: tlc59116: Driver for the TI 16 Channel i2c LED driver
Date: Fri, 09 Jan 2015 13:46:10 +0100	[thread overview]
Message-ID: <op.xr64e8gt2s3iss@ecaz> (raw)
In-Reply-To: <1420763178-10115-3-git-send-email-andrew@lunn.ch>

Hi Andrew,

On Fri, 09 Jan 2015 01:26:18 +0100, Andrew Lunn <andrew@lunn.ch> wrote:

> The TLC59116 is an I2C bus controlled 16-channel LED driver.  Each LED
> output has its own 8-bit fixed-frequency PWM controller to control the
> brightness of the LED.
>
> This is based on a driver from Belkin, but has been extensively
> rewritten.
>
<snip>

> +config LEDS_TLC59116
> +	tristate "LED driver for TLC59116F controllers"
> +	depends on LEDS_CLASS && I2C

I think you need "select REGMAP_I2C" as well.

> +	help
> +	  This option enables support for Texas Instruments TLC59116F
> +	  LED controller.
> +
>  config LEDS_MAX8997
>  	tristate "LED support for MAX8997 PMIC"
>  	depends on LEDS_CLASS && MFD_MAX8997



Imre

  parent reply	other threads:[~2015-01-09 12:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09  0:26 [PATCH 0/2] Driver for TI tlc59116 16 Channel i2c LED driver Andrew Lunn
2015-01-09  0:26 ` Andrew Lunn
2015-01-09  0:26 ` [PATCH 1/2] leds: tlc59116: Document binding for the TI " Andrew Lunn
2015-01-09  0:26   ` Andrew Lunn
2015-01-09  1:02   ` Bryan Wu
2015-01-09  1:02     ` Bryan Wu
2015-01-09  1:34     ` Andrew Lunn
2015-01-09  1:34       ` Andrew Lunn
     [not found] ` <1420763178-10115-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2015-01-09  0:26   ` [PATCH 2/2] leds: tlc59116: Driver " Andrew Lunn
2015-01-09  0:26     ` Andrew Lunn
     [not found]     ` <1420763178-10115-3-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2015-01-09  0:36       ` Varka Bhadram
2015-01-09  0:36         ` Varka Bhadram
2015-01-09  1:42         ` Andrew Lunn
2015-01-09  1:42           ` Andrew Lunn
2015-01-09  1:26     ` Bryan Wu
2015-01-09  1:26       ` Bryan Wu
2015-01-09  1:38       ` Andrew Lunn
2015-01-09  1:38         ` Andrew Lunn
2015-01-09 12:46     ` Imre Kaloz [this message]
2015-01-09 12:46       ` Imre Kaloz
2015-01-09 13:58       ` Andrew Lunn
2015-01-09 13:58         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.xr64e8gt2s3iss@ecaz \
    --to=kaloz@openwrt.org \
    --cc=Matthew.Fatheree@belkin.com \
    --cc=andrew@lunn.ch \
    --cc=cooloney@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.