All of lore.kernel.org
 help / color / mirror / Atom feed
From: kaloz@openwrt.org (Imre Kaloz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Date: Tue, 21 Jun 2016 14:22:05 +0200	[thread overview]
Message-ID: <op.yjepy3mr2s3iss@ecaz> (raw)
In-Reply-To: <1466509358-25498-1-git-send-email-zajec5@gmail.com>

Is there any reason you are not handling this properly as a regulator with  
usb-nop-xceiv?


Imre

On Tue, 21 Jun 2016 13:42:38 +0200, Rafa? Mi?ecki <zajec5@gmail.com> wrote:

> There is one GPIO controlling power for both USB ports.
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> ---
>  arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts  
> b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> index a22ed14..a76486b 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> @@ -104,3 +104,11 @@
>  &uart0 {
>  	status = "okay";
>  };
> +
> +&usb2 {
> +	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&usb3 {
> +	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};

WARNING: multiple messages have this Message-ID (diff)
From: "Imre Kaloz" <kaloz@openwrt.org>
To: "Florian Fainelli" <f.fainelli@gmail.com>,
	"Rafał Miłecki" <zajec5@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Hauke Mehrtens <hauke@hauke-m.de>,
	Russell King <linux@armlinux.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:BROADCOM BCM5301X ARM ARCHITECTURE"
	<bcm-kernel-feedback-list@broadcom.com>,
	Kumar Gala <galak@codeaurora.org>,
	"open list:BROADCOM BCM5301X ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Date: Tue, 21 Jun 2016 14:22:05 +0200	[thread overview]
Message-ID: <op.yjepy3mr2s3iss@ecaz> (raw)
In-Reply-To: <1466509358-25498-1-git-send-email-zajec5@gmail.com>

Is there any reason you are not handling this properly as a regulator with  
usb-nop-xceiv?


Imre

On Tue, 21 Jun 2016 13:42:38 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:

> There is one GPIO controlling power for both USB ports.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
>  arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts  
> b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> index a22ed14..a76486b 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> @@ -104,3 +104,11 @@
>  &uart0 {
>  	status = "okay";
>  };
> +
> +&usb2 {
> +	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&usb3 {
> +	vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};

  reply	other threads:[~2016-06-21 12:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21 11:42 [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki
2016-06-21 11:42 ` Rafał Miłecki
2016-06-21 11:42 ` Rafał Miłecki
2016-06-21 12:22 ` Imre Kaloz [this message]
2016-06-21 12:22   ` Imre Kaloz
2016-06-21 12:26   ` Rafał Miłecki
2016-06-21 12:26     ` Rafał Miłecki
2016-06-21 12:26     ` Rafał Miłecki
2016-06-21 14:29     ` Imre Kaloz
2016-06-21 14:29       ` Imre Kaloz
2016-06-21 14:29       ` Imre Kaloz
2016-06-21 15:23       ` Rafał Miłecki
2016-06-21 15:23         ` Rafał Miłecki
2016-06-21 15:23         ` Rafał Miłecki
2016-06-22 10:21         ` Imre Kaloz
2016-06-22 10:21           ` Imre Kaloz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.yjepy3mr2s3iss@ecaz \
    --to=kaloz@openwrt.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.