From: kaloz@openwrt.org (Imre Kaloz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Date: Wed, 22 Jun 2016 12:21:03 +0200 [thread overview]
Message-ID: <op.yjge1dkz2s3iss@ecaz> (raw)
In-Reply-To: <CACna6ryrABjF3ie8uE6_q-pfNjhQaGbRhNR9jWMEPKwaUt88hQ@mail.gmail.com>
On Tue, 21 Jun 2016 17:23:18 +0200, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> On 21 June 2016 at 16:29, Imre Kaloz <kaloz@openwrt.org> wrote:
>> On Tue, 21 Jun 2016 14:26:11 +0200, Rafa? Mi?ecki <zajec5@gmail.com>
>> wrote:
>>
>>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>>>>
>>>> Is there any reason you are not handling this properly as a regulator
>>>> with
>>>> usb-nop-xceiv?
>>>
>>>
>>> We can't use USB NOP PHY as we need a specific PHY driver for
>>> Broadcom's
>>> USB.
>>
>>
>> I see. That shouldn't stop you from addressing the regulator part, tho
>> ;)
>
> How? Be more specific please.
>
Instead of blindly enabling a GPIO, you should define that GPIO line as a
fixed regulator and make the USB phy driver handle it. Take a look at
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7776ab70d75ff9857343e44e428744d81c30ce1b
for example.
Imre
WARNING: multiple messages have this Message-ID (diff)
From: "Imre Kaloz" <kaloz@openwrt.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Hauke Mehrtens <hauke@hauke-m.de>,
Russell King <linux@armlinux.org.uk>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:BROADCOM BCM5301X ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Kumar Gala <galak@codeaurora.org>,
"open list:BROADCOM BCM5301X ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
Date: Wed, 22 Jun 2016 12:21:03 +0200 [thread overview]
Message-ID: <op.yjge1dkz2s3iss@ecaz> (raw)
In-Reply-To: <CACna6ryrABjF3ie8uE6_q-pfNjhQaGbRhNR9jWMEPKwaUt88hQ@mail.gmail.com>
On Tue, 21 Jun 2016 17:23:18 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 21 June 2016 at 16:29, Imre Kaloz <kaloz@openwrt.org> wrote:
>> On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com>
>> wrote:
>>
>>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>>>>
>>>> Is there any reason you are not handling this properly as a regulator
>>>> with
>>>> usb-nop-xceiv?
>>>
>>>
>>> We can't use USB NOP PHY as we need a specific PHY driver for
>>> Broadcom's
>>> USB.
>>
>>
>> I see. That shouldn't stop you from addressing the regulator part, tho
>> ;)
>
> How? Be more specific please.
>
Instead of blindly enabling a GPIO, you should define that GPIO line as a
fixed regulator and make the USB phy driver handle it. Take a look at
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7776ab70d75ff9857343e44e428744d81c30ce1b
for example.
Imre
next prev parent reply other threads:[~2016-06-22 10:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 11:42 [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki
2016-06-21 11:42 ` Rafał Miłecki
2016-06-21 11:42 ` Rafał Miłecki
2016-06-21 12:22 ` Imre Kaloz
2016-06-21 12:22 ` Imre Kaloz
2016-06-21 12:26 ` Rafał Miłecki
2016-06-21 12:26 ` Rafał Miłecki
2016-06-21 12:26 ` Rafał Miłecki
2016-06-21 14:29 ` Imre Kaloz
2016-06-21 14:29 ` Imre Kaloz
2016-06-21 14:29 ` Imre Kaloz
2016-06-21 15:23 ` Rafał Miłecki
2016-06-21 15:23 ` Rafał Miłecki
2016-06-21 15:23 ` Rafał Miłecki
2016-06-22 10:21 ` Imre Kaloz [this message]
2016-06-22 10:21 ` Imre Kaloz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.yjge1dkz2s3iss@ecaz \
--to=kaloz@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.