From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Hiroaki Fuse <Hiroaki_Fuse@hq.scei.sony.co.jp>
Subject: Re: Too verbose compat_ioctl messages?
Date: 06 Jul 2007 20:14:39 +0200 [thread overview]
Message-ID: <p737ipd1jsg.fsf@bingen.suse.de> (raw)
In-Reply-To: <468E6E33.3040000@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
>
> For one thing, it looks like we're returning the wrong thing (EINVAL
> rather than ENOTTY) across the board. This was unfortunately a common
> misunderstanding with non-tty-related ioctls in the early days of Linux.
ENOTTY is so excessively misnamed that it is actually surprising
anybody ever got that "right" (for very small values of right i guess)
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Hiroaki Fuse <Hiroaki_Fuse@hq.scei.sony.co.jp>
Subject: Re: Too verbose compat_ioctl messages?
Date: 06 Jul 2007 20:14:39 +0200 [thread overview]
Message-ID: <p737ipd1jsg.fsf@bingen.suse.de> (raw)
In-Reply-To: <468E6E33.3040000@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
>
> For one thing, it looks like we're returning the wrong thing (EINVAL
> rather than ENOTTY) across the board. This was unfortunately a common
> misunderstanding with non-tty-related ioctls in the early days of Linux.
ENOTTY is so excessively misnamed that it is actually surprising
anybody ever got that "right" (for very small values of right i guess)
-Andi
next prev parent reply other threads:[~2007-07-06 17:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 12:47 Too verbose compat_ioctl messages? Geert Uytterhoeven
2007-07-06 12:57 ` Andreas Schwab
2007-07-06 12:57 ` Andreas Schwab
2007-07-06 15:49 ` Geert Uytterhoeven
2007-07-06 15:49 ` Geert Uytterhoeven
2007-07-06 15:52 ` [PATCH] compat32: ignore the LOOP_CLR_FD ioctl Geert Uytterhoeven
2007-07-06 15:52 ` Geert Uytterhoeven
2007-07-06 16:30 ` Too verbose compat_ioctl messages? H. Peter Anvin
2007-07-06 16:30 ` H. Peter Anvin
2007-07-06 18:14 ` Andi Kleen [this message]
2007-07-06 18:14 ` Andi Kleen
2007-07-06 17:48 ` H. Peter Anvin
2007-07-06 17:48 ` H. Peter Anvin
2007-07-06 18:33 ` Jeremy Fitzhardinge
2007-07-06 18:33 ` Jeremy Fitzhardinge
2007-07-06 18:36 ` H. Peter Anvin
2007-07-06 18:36 ` H. Peter Anvin
2007-07-06 18:40 ` Jeremy Fitzhardinge
2007-07-06 18:40 ` Jeremy Fitzhardinge
2007-07-06 19:04 ` Andi Kleen
2007-07-06 19:04 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737ipd1jsg.fsf@bingen.suse.de \
--to=andi@firstfloor.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=Hiroaki_Fuse@hq.scei.sony.co.jp \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.