* [PATCH] setup: fix grammar in code comment
@ 2026-11-21 16:49 Ophir Bleicher via GitGitGadget
2026-11-21 17:27 ` D. Ben Knoble
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ophir Bleicher via GitGitGadget @ 2026-11-21 16:49 UTC (permalink / raw)
To: git; +Cc: Ophir Bleicher, Ophir Bleicher
From: Ophir Bleicher <ophirble@gmail.com>
Fix a grammar problem in line 271 of setup.c:
will only complain about an inexisting file.
Change it to 'non-existing'.
Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
setup: fix grammar in code comment
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v1
Pull-Request: https://github.com/git/git/pull/2500
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index cedc031c54..140f1926c4 100644
--- a/setup.c
+++ b/setup.c
@@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
* diagnosis when dying upon finding that "name" is not a pathname.
* If set to 1, the diagnosis will try to diagnose "name" as an
* invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
- * will only complain about an inexisting file.
+ * will only complain about a non-existing file.
*
* This function is typically called to check that a "file or rev"
* argument is unambiguous. In this case, the caller will want
base-commit: f7de81456940dd6f3274e461149bba12965de609
--
gitgitgadget
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] setup: fix grammar in code comment
2026-11-21 16:49 [PATCH] setup: fix grammar in code comment Ophir Bleicher via GitGitGadget
@ 2026-11-21 17:27 ` D. Ben Knoble
2026-11-21 17:29 ` Ophir Bleicher
2026-11-21 17:33 ` [PATCH v2] setup: fix incorrect word " Ophir Bleicher via GitGitGadget
2026-11-21 17:35 ` [PATCH v3] " Ophir Bleicher via GitGitGadget
2 siblings, 1 reply; 5+ messages in thread
From: D. Ben Knoble @ 2026-11-21 17:27 UTC (permalink / raw)
To: Ophir Bleicher via GitGitGadget; +Cc: git, Ophir Bleicher
On Sat, Nov 21, 2026 at 11:49 AM Ophir Bleicher via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Ophir Bleicher <ophirble@gmail.com>
>
> Fix a grammar problem in line 271 of setup.c:
Is it a grammatical error? I think it's simply the wrong word.
> will only complain about an inexisting file.
What a strange little word: it comes from "inexist", which does *not*
mean "does not exist" but rather "exist within"!
https://en.wiktionary.org/wiki/inexist#English
> Change it to 'non-existing'.
I think "non-existent" (or "missing" or "not found") would be more common here.
> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
> ---
> setup: fix grammar in code comment
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v1
> Pull-Request: https://github.com/git/git/pull/2500
>
> setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/setup.c b/setup.c
> index cedc031c54..140f1926c4 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
> * diagnosis when dying upon finding that "name" is not a pathname.
> * If set to 1, the diagnosis will try to diagnose "name" as an
> * invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
> - * will only complain about an inexisting file.
> + * will only complain about a non-existing file.
> *
> * This function is typically called to check that a "file or rev"
> * argument is unambiguous. In this case, the caller will want
>
> base-commit: f7de81456940dd6f3274e461149bba12965de609
> --
> gitgitgadget
>
--
D. Ben Knoble
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] setup: fix grammar in code comment
2026-11-21 17:27 ` D. Ben Knoble
@ 2026-11-21 17:29 ` Ophir Bleicher
0 siblings, 0 replies; 5+ messages in thread
From: Ophir Bleicher @ 2026-11-21 17:29 UTC (permalink / raw)
To: D. Ben Knoble; +Cc: Ophir Bleicher via GitGitGadget, git
OK, I’ll submit another patch...
> On 21 Nov 2026, at 19:27, D. Ben Knoble <ben.knoble@gmail.com> wrote:
>
> On Sat, Nov 21, 2026 at 11:49 AM Ophir Bleicher via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Ophir Bleicher <ophirble@gmail.com>
>>
>> Fix a grammar problem in line 271 of setup.c:
>
> Is it a grammatical error? I think it's simply the wrong word.
>
>> will only complain about an inexisting file.
>
> What a strange little word: it comes from "inexist", which does *not*
> mean "does not exist" but rather "exist within"!
>
> https://en.wiktionary.org/wiki/inexist#English
>
>> Change it to 'non-existing'.
>
> I think "non-existent" (or "missing" or "not found") would be more common here.
>
>> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
>> ---
>> setup: fix grammar in code comment
>>
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v1
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v1
>> Pull-Request: https://github.com/git/git/pull/2500
>>
>> setup.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/setup.c b/setup.c
>> index cedc031c54..140f1926c4 100644
>> --- a/setup.c
>> +++ b/setup.c
>> @@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
>> * diagnosis when dying upon finding that "name" is not a pathname.
>> * If set to 1, the diagnosis will try to diagnose "name" as an
>> * invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
>> - * will only complain about an inexisting file.
>> + * will only complain about a non-existing file.
>> *
>> * This function is typically called to check that a "file or rev"
>> * argument is unambiguous. In this case, the caller will want
>>
>> base-commit: f7de81456940dd6f3274e461149bba12965de609
>> --
>> gitgitgadget
>>
>
>
> --
> D. Ben Knoble
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] setup: fix incorrect word in code comment
2026-11-21 16:49 [PATCH] setup: fix grammar in code comment Ophir Bleicher via GitGitGadget
2026-11-21 17:27 ` D. Ben Knoble
@ 2026-11-21 17:33 ` Ophir Bleicher via GitGitGadget
2026-11-21 17:35 ` [PATCH v3] " Ophir Bleicher via GitGitGadget
2 siblings, 0 replies; 5+ messages in thread
From: Ophir Bleicher via GitGitGadget @ 2026-11-21 17:33 UTC (permalink / raw)
To: git; +Cc: Ophir Bleicher, Ophir Bleicher
From: Ophir Bleicher <ophirble@gmail.com>
Fix an incorrect word problem in line 271 of setup.c:
will only complain about an inexisting file.
Change it to 'non-existent'.
Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
setup: fix incorrect word in code comment
Changes since v1:
* Update commit message from grammar to incorrect word
* Change word to non-existent instead of non-existing
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v2
Pull-Request: https://github.com/git/git/pull/2500
Range-diff vs v1:
1: 6cc8123ca4 ! 1: 3b7539bd5f setup: fix grammar in code comment
@@ Metadata
Author: Ophir Bleicher <ophirble@gmail.com>
## Commit message ##
- setup: fix grammar in code comment
+ setup: fix incorrect word in code comment
- Fix a grammar problem in line 271 of setup.c:
+ Fix an incorrect word problem in line 271 of setup.c:
will only complain about an inexisting file.
- Change it to 'non-existing'.
+ Change it to 'non-existent'.
Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index cedc031c54..140f1926c4 100644
--- a/setup.c
+++ b/setup.c
@@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
* diagnosis when dying upon finding that "name" is not a pathname.
* If set to 1, the diagnosis will try to diagnose "name" as an
* invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
- * will only complain about an inexisting file.
+ * will only complain about a non-existing file.
*
* This function is typically called to check that a "file or rev"
* argument is unambiguous. In this case, the caller will want
base-commit: f7de81456940dd6f3274e461149bba12965de609
--
gitgitgadget
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v3] setup: fix incorrect word in code comment
2026-11-21 16:49 [PATCH] setup: fix grammar in code comment Ophir Bleicher via GitGitGadget
2026-11-21 17:27 ` D. Ben Knoble
2026-11-21 17:33 ` [PATCH v2] setup: fix incorrect word " Ophir Bleicher via GitGitGadget
@ 2026-11-21 17:35 ` Ophir Bleicher via GitGitGadget
2 siblings, 0 replies; 5+ messages in thread
From: Ophir Bleicher via GitGitGadget @ 2026-11-21 17:35 UTC (permalink / raw)
To: git; +Cc: Ophir Bleicher, Ophir Bleicher
From: Ophir Bleicher <ophirble@gmail.com>
Fix an incorrect word problem in line 271 of setup.c:
will only complain about an inexisting file.
Change it to 'non-existent'.
Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
setup: fix incorrect word in code comment
Changes since v1:
* Update commit message from grammar to incorrect word
* Change word to non-existent instead of non-existing Changes since v2:
* Really change word to non-existent instead of non-existing
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v3
Pull-Request: https://github.com/git/git/pull/2500
Range-diff vs v2:
1: 3b7539bd5f ! 1: 2158470090 setup: fix incorrect word in code comment
@@ setup.c: static int looks_like_pathspec(const char *arg)
* If set to 1, the diagnosis will try to diagnose "name" as an
* invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
- * will only complain about an inexisting file.
-+ * will only complain about a non-existing file.
++ * will only complain about a non-existent file.
*
* This function is typically called to check that a "file or rev"
* argument is unambiguous. In this case, the caller will want
setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.c b/setup.c
index cedc031c54..3aaa1b65b2 100644
--- a/setup.c
+++ b/setup.c
@@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
* diagnosis when dying upon finding that "name" is not a pathname.
* If set to 1, the diagnosis will try to diagnose "name" as an
* invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
- * will only complain about an inexisting file.
+ * will only complain about a non-existent file.
*
* This function is typically called to check that a "file or rev"
* argument is unambiguous. In this case, the caller will want
base-commit: f7de81456940dd6f3274e461149bba12965de609
--
gitgitgadget
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-21 17:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 16:49 [PATCH] setup: fix grammar in code comment Ophir Bleicher via GitGitGadget
2026-11-21 17:27 ` D. Ben Knoble
2026-11-21 17:29 ` Ophir Bleicher
2026-11-21 17:33 ` [PATCH v2] setup: fix incorrect word " Ophir Bleicher via GitGitGadget
2026-11-21 17:35 ` [PATCH v3] " Ophir Bleicher via GitGitGadget
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.