All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Meng Tang <tangmeng@uniontech.com>,
	alsa-devel@alsa-project.org, tiwai@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement
Date: Mon, 28 Feb 2022 17:02:54 +0100	[thread overview]
Message-ID: <s5ha6ebrnbl.wl-tiwai@suse.de> (raw)
In-Reply-To: <e5c1ba2f7db29b78066d12dab812b7a1c0a37a81.camel@perches.com>

On Mon, 28 Feb 2022 06:20:45 +0100,
Joe Perches wrote:
> 
> On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote:
> > Return the result from file->f_op->open() directly instead of
> > taking this in another redundant variable. Make the typical
> > return the last statement, return early and reduce the indentation
> > too.
> > 
> > Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> Hi Meng Tang.
> 
> For the next time: it's not necessary (or even good) to add a sign-off
> for another person unless they specifically authorize one.
> 
> You wrote and are submitting these changes, I merely gave you simple
> suggestions as to how you could improve them.

Joe, would you like to drop your S-o-b lines from those two patches?
Or shall I keep them?


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Meng Tang <tangmeng@uniontech.com>,
	perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement
Date: Mon, 28 Feb 2022 17:02:54 +0100	[thread overview]
Message-ID: <s5ha6ebrnbl.wl-tiwai@suse.de> (raw)
In-Reply-To: <e5c1ba2f7db29b78066d12dab812b7a1c0a37a81.camel@perches.com>

On Mon, 28 Feb 2022 06:20:45 +0100,
Joe Perches wrote:
> 
> On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote:
> > Return the result from file->f_op->open() directly instead of
> > taking this in another redundant variable. Make the typical
> > return the last statement, return early and reduce the indentation
> > too.
> > 
> > Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> Hi Meng Tang.
> 
> For the next time: it's not necessary (or even good) to add a sign-off
> for another person unless they specifically authorize one.
> 
> You wrote and are submitting these changes, I merely gave you simple
> suggestions as to how you could improve them.

Joe, would you like to drop your S-o-b lines from those two patches?
Or shall I keep them?


thanks,

Takashi

  parent reply	other threads:[~2022-02-28 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  5:02 [PATCH v4 1/2] ALSA: core: remove initialise static variables to 0 Meng Tang
2022-02-28  5:02 ` Meng Tang
2022-02-28  5:02 ` [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement Meng Tang
2022-02-28  5:02   ` Meng Tang
2022-02-28  5:20   ` Joe Perches
2022-02-28  5:35     ` tangmeng
2022-02-28 16:02     ` Takashi Iwai [this message]
2022-02-28 16:02       ` Takashi Iwai
2022-02-28 16:39       ` Joe Perches
2022-02-28 16:39         ` Joe Perches
2022-02-28 16:57         ` Takashi Iwai
2022-02-28 16:57           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha6ebrnbl.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tangmeng@uniontech.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.