[ALSA PATCH] 1.0.9b+

[ALSA PATCH] 1.0.9b+

[Jaroslav Kysela]

Linus, please do an update from:

  rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git

The GNU patch is available at:

  ftp://ftp.alsa-project.org/pub/kernel-patches/alsa-git-2005-07-28.patch.gz

Additional notes:

  Mostly cleanups and added the Sparc DBRI driver.

The following files will be updated:

 sound/pcmcia/vx/vx_entry.c                      |  375 ---
 sound/pcmcia/vx/vxp440.c                        |   14 
 Documentation/sound/alsa/ALSA-Configuration.txt |   44 
 include/sound/core.h                            |   37 
 include/sound/driver.h                          |    2 
 include/sound/emu10k1.h                         |    1 
 include/sound/version.h                         |    4 
 sound/arm/Kconfig                               |   14 
 sound/arm/Makefile                              |    8 
 sound/arm/pxa2xx-ac97.c                         |  410 +++
 sound/arm/pxa2xx-pcm.c                          |  367 +++
 sound/arm/pxa2xx-pcm.h                          |   29 
 sound/core/device.c                             |   15 
 sound/core/info.c                               |    5 
 sound/core/memalloc.c                           |    3 
 sound/core/memory.c                             |    8 
 sound/core/seq/Makefile                         |    2 
 sound/core/seq/instr/ainstr_gf1.c               |    3 
 sound/core/seq/instr/ainstr_iw.c                |    8 
 sound/core/seq/seq_midi.c                       |   16 
 sound/core/wrappers.c                           |    2 
 sound/drivers/vx/vx_uer.c                       |   46 
 sound/i2c/other/ak4114.c                        |    1 
 sound/isa/gus/gus_main.c                        |    2 
 sound/isa/wavefront/wavefront_fx.c              |   34 
 sound/pci/ac97/ac97_codec.c                     |   25 
 sound/pci/ac97/ac97_patch.c                     |    3 
 sound/pci/ali5451/ali5451.c                     |    4 
 sound/pci/atiixp_modem.c                        |    1 
 sound/pci/cmipci.c                              |    9 
 sound/pci/cs46xx/cs46xx_lib.c                   |   15 
 sound/pci/emu10k1/emu10k1.c                     |   10 
 sound/pci/emu10k1/emu10k1_main.c                |  133 -
 sound/pci/emu10k1/p16v.c                        |   20 
 sound/pci/ens1370.c                             |   22 
 sound/pci/es1968.c                              |   14 
 sound/pci/hda/hda_codec.h                       |    3 
 sound/pci/hda/hda_intel.c                       |    6 
 sound/pci/hda/patch_cmedia.c                    |    5 
 sound/pci/hda/patch_realtek.c                   |   28 
 sound/pci/hda/patch_sigmatel.c                  |  810 +++++--
 sound/pci/intel8x0.c                            |   16 
 sound/pci/maestro3.c                            |   26 
 sound/pci/mixart/mixart.c                       |    4 
 sound/pci/rme9652/hdsp.c                        |   68 
 sound/pci/trident/trident_main.c                |    4 
 sound/pci/via82xx.c                             |   16 
 sound/pci/via82xx_modem.c                       |   13 
 sound/pci/ymfpci/ymfpci_main.c                  |    6 
 sound/pcmcia/Kconfig                            |   15 
 sound/pcmcia/vx/Makefile                        |    7 
 sound/pcmcia/vx/vxpocket.c                      |  437 +++
 sound/pcmcia/vx/vxpocket.h                      |   27 
 sound/ppc/awacs.c                               |    6 
 sound/ppc/pmac.h                                |    5 
 sound/ppc/tumbler.c                             |   16 
 sound/sparc/Kconfig                             |   22 
 sound/sparc/Makefile                            |    4 
 sound/sparc/dbri.c                              | 2729 ++++++++++++++++++++++++
 sound/usb/usbaudio.c                            |  105 
 sound/usb/usbaudio.h                            |   38 
 sound/usb/usbmidi.c                             |   21 
 sound/usb/usbquirks.h                           |   29 
 sound/usb/usx2y/usX2Yhwdep.c                    |    3 
 sound/usb/usx2y/usx2yhwdeppcm.c                 |    6 
 65 files changed, 5059 insertions(+), 1122 deletions(-)

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SUSE Labs

Re: [ALSA PATCH] 1.0.9b+

[Andrew Morton]

Jaroslav Kysela <perex@suse.cz> wrote:
>
> Linus, please do an update from:
> 
>    rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> 
> ...
>   65 files changed, 5059 insertions(+), 1122 deletions(-)

The git-alsa.patch in -mm which I obtain from
master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
hasn't been tested in -mm at approximately the -rc4 stage.

We need to become much better at this.

Re: [ALSA PATCH] 1.0.9b+

[Lee Revell]

On Thu, 2005-07-28 at 10:25 -0700, Andrew Morton wrote:
> Jaroslav Kysela <perex@suse.cz> wrote:
> >
> > Linus, please do an update from:
> > 
> >    rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> > 
> > ...
> >   65 files changed, 5059 insertions(+), 1122 deletions(-)
> 
> The git-alsa.patch in -mm which I obtain from
> master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
> empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
> hasn't been tested in -mm at approximately the -rc4 stage.
> 

Lots of people install ALSA independently from the kernel (like all the
audio oriented distro users), probably a lot more than run -mm, so it's
not completely unreviewed.

Lee

Re: [ALSA PATCH] 1.0.9b+

[Andrew Morton]

Lee Revell <rlrevell@joe-job.com> wrote:
>
> On Thu, 2005-07-28 at 10:25 -0700, Andrew Morton wrote:
> > Jaroslav Kysela <perex@suse.cz> wrote:
> > >
> > > Linus, please do an update from:
> > > 
> > >    rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> > > 
> > > ...
> > >   65 files changed, 5059 insertions(+), 1122 deletions(-)
> > 
> > The git-alsa.patch in -mm which I obtain from
> > master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
> > empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
> > hasn't been tested in -mm at approximately the -rc4 stage.
> > 
> 
> Lots of people install ALSA independently from the kernel (like all the
> audio oriented distro users),

In the past week?

> so it's not completely unreviewed.

tested != reviewed.

Re: [ALSA PATCH] 1.0.9b+

[Dave Jones]

On Thu, Jul 28, 2005 at 03:06:02PM -0400, Lee Revell wrote:

 > > The git-alsa.patch in -mm which I obtain from
 > > master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
 > > empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
 > > hasn't been tested in -mm at approximately the -rc4 stage.
 > 
 > Lots of people install ALSA independently from the kernel (like all the
 > audio oriented distro users), probably a lot more than run -mm, so it's
 > not completely unreviewed.

There's a big difference between 'unreviewed' and 'untested'.
With drivers that support n variants of a piece of hardware,
hearing back that a driver works fine from someone isn't really
worth anything if the changes break for all the other users
of that driver that have a different variant, which haven't tested it yet.

We have a testing/review process in place, attempts to short-circuit
it should be prevented. Especially from a subsystem that
historically has had a number of issues wrt regressions each release.

		Dave

Re: [ALSA PATCH] 1.0.9b+

[Alistair John Strachan]

On Thursday 28 Jul 2005 18:25, Andrew Morton wrote:
> Jaroslav Kysela <perex@suse.cz> wrote:
> > Linus, please do an update from:
> >
> >    rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> >
> > ...
> >   65 files changed, 5059 insertions(+), 1122 deletions(-)
>
> The git-alsa.patch in -mm which I obtain from
> master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
> empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
> hasn't been tested in -mm at approximately the -rc4 stage.

~2800 lines of which is a new driver.

It'd be nice if ALSA's release schedule for "stable" versus "rc" could match 
the kernel's. For example, 2.6.12 shipped with 1.0.9rc2.

Maybe "rc" ALSA should only be accepted in rc1, by rc4 you hope they can wrap 
things up and give you a stable version number? Okay, generally in-tree 
version numbers don't count for much, but I think ALSA is a big exception 
because it's maintained pretty much out of tree.

Not so much of an issue this time around, but I don't think new drivers or 
rewrites (even if they are reasonably separate) should be going in a late -rc 
kernel.

Just my two pence.

-- 
Cheers,
Alistair.

'No sense being pessimistic, it probably wouldn't work anyway.'
Third year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

Re: [ALSA PATCH] 1.0.9b+

[Andrew Morton]

Alistair John Strachan <s0348365@sms.ed.ac.uk> wrote:
>
> On Thursday 28 Jul 2005 18:25, Andrew Morton wrote:
> > Jaroslav Kysela <perex@suse.cz> wrote:
> > > Linus, please do an update from:
> > >
> > >    rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> > >
> > > ...
> > >   65 files changed, 5059 insertions(+), 1122 deletions(-)
> >
> > The git-alsa.patch in -mm which I obtain from
> > master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
> > empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
> > hasn't been tested in -mm at approximately the -rc4 stage.
> 
> ~2800 lines of which is a new driver.
> 
> It'd be nice if ALSA's release schedule for "stable" versus "rc" could match 
> the kernel's. For example, 2.6.12 shipped with 1.0.9rc2.
> 
> Maybe "rc" ALSA should only be accepted in rc1, by rc4 you hope they can wrap 
> things up and give you a stable version number? Okay, generally in-tree 
> version numbers don't count for much, but I think ALSA is a big exception 
> because it's maintained pretty much out of tree.
> 
> Not so much of an issue this time around, but I don't think new drivers or 
> rewrites (even if they are reasonably separate) should be going in a late -rc 
> kernel.
> 

Independent of all that, there remains the problem that I was not obtaining
all this new code from
master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git.

Is there some different tree which I should be pulling from?

Re: [ALSA PATCH] 1.0.9b+

[Jaroslav Kysela]

On Thu, 28 Jul 2005, Andrew Morton wrote:

> Jaroslav Kysela <perex@suse.cz> wrote:
> >
> > Linus, please do an update from:
> > 
> >    rsync://rsync.kernel.org/pub/scm/linux/kernel/git/perex/alsa.git
> > 
> > ...
> >   65 files changed, 5059 insertions(+), 1122 deletions(-)
> 
> The git-alsa.patch in -mm which I obtain from
> master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
> empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
> hasn't been tested in -mm at approximately the -rc4 stage.
> 
> We need to become much better at this.

Yes, sure. I wanted to sync more early, but I had some trouble with 
cogito. Now things settled a bit, so I'll start with regular updates.

Note that most of lines are from new Sparc and ARM drivers. Other changes 
are mostly small bugfixes, cleanups and new hardware ID additions. The all 
changes goes through all ALSA developers (our CVS server sends us whole 
diffs back), so all of them review/verify new code and can fix it ASAP. It 
works quite well.

						Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SUSE Labs

Re: [ALSA PATCH] 1.0.9b+

[Takashi Iwai]

At Thu, 28 Jul 2005 17:07:38 -0400,
Dave Jones wrote:
> 
> On Thu, Jul 28, 2005 at 03:06:02PM -0400, Lee Revell wrote:
> 
>  > > The git-alsa.patch in -mm which I obtain from
>  > > master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is
>  > > empty.  So we're now wanting to merge 4,000 lines of unreviewed code which
>  > > hasn't been tested in -mm at approximately the -rc4 stage.
>  > 
>  > Lots of people install ALSA independently from the kernel (like all the
>  > audio oriented distro users), probably a lot more than run -mm, so it's
>  > not completely unreviewed.
> 
> There's a big difference between 'unreviewed' and 'untested'.
> With drivers that support n variants of a piece of hardware,
> hearing back that a driver works fine from someone isn't really
> worth anything if the changes break for all the other users
> of that driver that have a different variant, which haven't tested it yet.
> 
> We have a testing/review process in place, attempts to short-circuit
> it should be prevented. Especially from a subsystem that
> historically has had a number of issues wrt regressions each release.

Oh, I missed your talk in OLS ;)

Basically I agree with the argument above.  Some hardware-specific
regressions are very hard to find only from review.  The famous
problem with ThinkPad in the last update was such a kind.  More tests
in a bigger place like mm tree would be required, indeed.

Unfortunately, the sync between ALSA and mm tree didn't work well
because of troubles with git/cogito at this time.  The sync process
shall be improved from now on.  So, please consider this as an
exception.


Takashi

Re: [ALSA PATCH] 1.0.9b+

[Daniel Egger]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

On 29.07.2005, at 09:39, Jaroslav Kysela wrote:

> Note that most of lines are from new Sparc and ARM drivers. Other  
> changes
> are mostly small bugfixes, cleanups and new hardware ID additions.  
> The all
> changes goes through all ALSA developers (our CVS server sends us  
> whole
> diffs back), so all of them review/verify new code and can fix it  
> ASAP. It
> works quite well.

FWIW the current ALSA patch against 2.6.12 works much better than
the original version for my Asus W3V with Intel HDA ALC880 in the sense
that there's a possibility to prevent crashing the kernel when loading
the module. However apart from the ID fixes this involves disabling the
autodetection code and hardcoding the correct type in the realtek code.

As it stands the code seems to be really buggy and I'd love to test the
driver after someone wiser than me in this area reviewed and fixed the
code.

Servus,
       Daniel


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 186 bytes --]

Re: [ALSA PATCH] 1.0.9b+

[Takashi Iwai]

At Sat, 30 Jul 2005 15:42:33 +0200,
Daniel Egger wrote:
> 
> On 29.07.2005, at 09:39, Jaroslav Kysela wrote:
> 
> > Note that most of lines are from new Sparc and ARM drivers. Other  
> > changes
> > are mostly small bugfixes, cleanups and new hardware ID additions.  
> > The all
> > changes goes through all ALSA developers (our CVS server sends us  
> > whole
> > diffs back), so all of them review/verify new code and can fix it  
> > ASAP. It
> > works quite well.
> 
> FWIW the current ALSA patch against 2.6.12 works much better than
> the original version for my Asus W3V with Intel HDA ALC880 in the sense
> that there's a possibility to prevent crashing the kernel when loading
> the module. However apart from the ID fixes this involves disabling the
> autodetection code and hardcoding the correct type in the realtek code.
> 
> As it stands the code seems to be really buggy and I'd love to test the
> driver after someone wiser than me in this area reviewed and fixed the
> code.

The oops was fixed by this update...


Takashi