All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Cc: guennadi.liakhovetski@linux.intel.com,
	alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com,
	linux-kernel@vger.kernel.org,
	pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
	hui.wang@canonical.com, kai.heng.feng@canonical.com,
	rppt@kernel.org
Subject: Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable
Date: Mon, 25 Jan 2021 09:01:02 +0100	[thread overview]
Message-ID: <s5hczxt5ttt.wl-tiwai@suse.de> (raw)
In-Reply-To: <1611559047-106928-1-git-send-email-abaci-bugfix@linux.alibaba.com>

On Mon, 25 Jan 2021 08:17:27 +0100,
Jiapeng Zhong wrote:
> 
> Fix the following coccicheck warnings:
> 
> ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>

Thanks, applied now.

But if you have some more similar changes, please try to convert at
once instead of submitting each change infrequently.  It's getting
annoying now, as the change itself hardly helps improving the
readability or code quality in general, although there is no strong
reason to object it.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Cc: perex@perex.cz, tiwai@suse.com, kai.vehmanen@linux.intel.com,
	pierre-louis.bossart@linux.intel.com,
	guennadi.liakhovetski@linux.intel.com,
	kai.heng.feng@canonical.com, rppt@kernel.org,
	hui.wang@canonical.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable
Date: Mon, 25 Jan 2021 09:01:02 +0100	[thread overview]
Message-ID: <s5hczxt5ttt.wl-tiwai@suse.de> (raw)
In-Reply-To: <1611559047-106928-1-git-send-email-abaci-bugfix@linux.alibaba.com>

On Mon, 25 Jan 2021 08:17:27 +0100,
Jiapeng Zhong wrote:
> 
> Fix the following coccicheck warnings:
> 
> ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>

Thanks, applied now.

But if you have some more similar changes, please try to convert at
once instead of submitting each change infrequently.  It's getting
annoying now, as the change itself hardly helps improving the
readability or code quality in general, although there is no strong
reason to object it.


Takashi

  reply	other threads:[~2021-01-25  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25  7:17 [PATCH] ALSA: hda: Assign boolean values to a bool variable Jiapeng Zhong
2021-01-25  7:17 ` Jiapeng Zhong
2021-01-25  8:01 ` Takashi Iwai [this message]
2021-01-25  8:01   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hczxt5ttt.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=abaci-bugfix@linux.alibaba.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=guennadi.liakhovetski@linux.intel.com \
    --cc=hui.wang@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rppt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.