[PATCH] AD1985 mixer settings

[PATCH] AD1985 mixer settings

[Clemens Ladisch]

The AD1985's "ADI compatibility mode" changes the meaning of some
mixer controls to be more useful. In this case, it makes the Master
Volume control behave correctly.


Index: alsa-kernel/pci/ac97/ac97_patch.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_patch.c,v
retrieving revision 1.18
diff -u -r1.18 ac97_patch.c
--- alsa-kernel/pci/ac97/ac97_patch.c	30 Jul 2003 10:54:03 -0000	1.18
+++ alsa-kernel/pci/ac97/ac97_patch.c	20 Aug 2003 06:59:16 -0000
@@ -768,7 +768,8 @@
 	misc = snd_ac97_read(ac97, AC97_AD_MISC);
 	/* switch front/surround line-out/hp-out */
 	/* center/LFE, surround in High-Z mode */
+	/* ADI compatibility mode */
-	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x1c28);
+	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x5c20);
 	return 0;
 }





-------------------------------------------------------
This SF.net email is sponsored by Dice.com.
Did you know that Dice has over 25,000 tech jobs available today? From
careers in IT to Engineering to Tech Sales, Dice has tech jobs from the
best hiring companies. http://www.dice.com/index.epl?rel_code=104

Re: [PATCH] AD1985 mixer settings

[Thierry Vignaud]

Clemens Ladisch <clemens@ladisch.de> writes:

> Index: alsa-kernel/pci/ac97/ac97_patch.c
> ===================================================================
> RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_patch.c,v
> retrieving revision 1.18
> diff -u -r1.18 ac97_patch.c
> --- alsa-kernel/pci/ac97/ac97_patch.c	30 Jul 2003 10:54:03 -0000	1.18
> +++ alsa-kernel/pci/ac97/ac97_patch.c	20 Aug 2003 06:59:16 -0000
> @@ -768,7 +768,8 @@
>  	misc = snd_ac97_read(ac97, AC97_AD_MISC);
>  	/* switch front/surround line-out/hp-out */
>  	/* center/LFE, surround in High-Z mode */
> +	/* ADI compatibility mode */
> -	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x1c28);
> +	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x5c20);
>  	return 0;
>  }

wouldn't a BIT_FEATURE_X & BIT_FEATURE_Y be more readable than raw
constants ?



-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0

Re: [PATCH] AD1985 mixer settings

[Takashi Iwai]

At Sun, 24 Aug 2003 00:29:07 +0200,
Thierry Vignaud wrote:
> 
> Clemens Ladisch <clemens@ladisch.de> writes:
> 
> > Index: alsa-kernel/pci/ac97/ac97_patch.c
> > ===================================================================
> > RCS file: /cvsroot/alsa/alsa-kernel/pci/ac97/ac97_patch.c,v
> > retrieving revision 1.18
> > diff -u -r1.18 ac97_patch.c
> > --- alsa-kernel/pci/ac97/ac97_patch.c	30 Jul 2003 10:54:03 -0000	1.18
> > +++ alsa-kernel/pci/ac97/ac97_patch.c	20 Aug 2003 06:59:16 -0000
> > @@ -768,7 +768,8 @@
> >  	misc = snd_ac97_read(ac97, AC97_AD_MISC);
> >  	/* switch front/surround line-out/hp-out */
> >  	/* center/LFE, surround in High-Z mode */
> > +	/* ADI compatibility mode */
> > -	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x1c28);
> > +	snd_ac97_write_cache(ac97, AC97_AD_MISC, misc | 0x5c20);
> >  	return 0;
> >  }
> 
> wouldn't a BIT_FEATURE_X & BIT_FEATURE_Y be more readable than raw
> constants ?

yeah, of course :)
i'll try to fix them now.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0

Re: [PATCH] AD1985 mixer settings

[Takashi Iwai]

At Wed, 20 Aug 2003 09:26:52 +0200 (METDST),
Clemens Ladisch wrote:
> 
> 
> The AD1985's "ADI compatibility mode" changes the meaning of some
> mixer controls to be more useful. In this case, it makes the Master
> Volume control behave correctly.

i didn't set this bit before, for keeping the compatibility with
others.  but after reconsideration, i agree that it will make more
sense.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0