EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Chris Rankin]

Hi,

I have just installed the latest ALSA-CVS and I have
noticed a few oddities:

First, these modules are suddenly being compiled. I
don't know why:

snd-emu8000-synth.o
snd-gus-synth.o
snd-trident-synth.o

This is my /etc/astate/driver_args:

# cat /etc/asound/driver_args 
--with-kernel=/home/chris/linux-2.4.20
--with-moddir=/lib/modules/2.4.20/kernel/drivers/sound
--with-oss=yes
--with-sequencer=yes
--with-cards=intel8x0,emu10k1,dummy

More importantly, playing WAV files via my SB Live!
using aplay is making a nasty, loud "click" sound
right at the end. It didn't used to do this. Any idea
which change is causing it, please?

Cheers,
Chris


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Takashi Iwai]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

At Thu, 30 Jan 2003 00:11:00 +0000 (GMT),
Chris Rankin wrote:
> 
> Hi,
> 
> I have just installed the latest ALSA-CVS and I have
> noticed a few oddities:
> 
> First, these modules are suddenly being compiled. I
> don't know why:
> 
> snd-emu8000-synth.o
> snd-gus-synth.o
> snd-trident-synth.o

because of the last changes of Makefiles...
will be fixed soon.

> More importantly, playing WAV files via my SB Live!
> using aplay is making a nasty, loud "click" sound
> right at the end. It didn't used to do this. Any idea
> which change is causing it, please?

does the attached patch have any influence?


Takashi

[-- Attachment #2: sgbuf-clear.dif --]
[-- Type: application/octet-stream, Size: 435 bytes --]

Index: alsa-driver/acore/pcm_sgbuf.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/acore/pcm_sgbuf.c,v
retrieving revision 1.7
diff -u -r1.7 pcm_sgbuf.c
--- alsa-driver/acore/pcm_sgbuf.c	27 Jan 2003 11:05:04 -0000	1.7
+++ alsa-driver/acore/pcm_sgbuf.c	30 Jan 2003 09:34:10 -0000
@@ -146,6 +146,7 @@
 #endif
 	}
 
+	memset(vmaddr, 0, size);
 	return vmaddr;
 
  _failed:

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Chris Rankin]

 --- Takashi Iwai <tiwai@suse.de> wrote:
> At Thu, 30 Jan 2003 00:11:00 +0000 (GMT),
> does the attached patch have any influence?

Nope, the clicks are still there.

Chris


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Takashi Iwai]

At Thu, 30 Jan 2003 23:13:24 +0000 (GMT),
Chris Rankin wrote:
> 
>  --- Takashi Iwai <tiwai@suse.de> wrote:
> > At Thu, 30 Jan 2003 00:11:00 +0000 (GMT),
> > does the attached patch have any influence?
> 
> Nope, the clicks are still there.

do you know which version (or date) the driver worked without clicks?
there have been not many changes for emu10k1 or pcm stuffs recently.


Takashi


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Chris Rankin]

 --- Takashi Iwai <tiwai@suse.de> wrote:
> do you know which version (or date) the driver
> worked without clicks?
> there have been not many changes for emu10k1 or pcm
> stuffs recently.

On a hunch, I downloaded the alsa-lib-0.9.0rc6 and
alsa-util-0.9.0rc6 packages and tried those against
the current CVS version of the kernel modules. There
is no nasty clicking sound using 0.9.0rc6 userspace.

Even more interesting:

alsa-lib 0.9.0rc6 + alsa-utils CVS => CLICK!
alsa-lib CVS + alsa-utils 0.9.0rc6 => No click.

I'm guessing that the problem lies in aplay.

Chris


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Takashi Iwai]

Hi Chris,

At Fri, 31 Jan 2003 19:56:51 +0000 (GMT),
Chris Rankin wrote:
> 
>  --- Takashi Iwai <tiwai@suse.de> wrote:
> > do you know which version (or date) the driver
> > worked without clicks?
> > there have been not many changes for emu10k1 or pcm
> > stuffs recently.
> 
> On a hunch, I downloaded the alsa-lib-0.9.0rc6 and
> alsa-util-0.9.0rc6 packages and tried those against
> the current CVS version of the kernel modules. There
> is no nasty clicking sound using 0.9.0rc6 userspace.
> 
> Even more interesting:
> 
> alsa-lib 0.9.0rc6 + alsa-utils CVS => CLICK!
> alsa-lib CVS + alsa-utils 0.9.0rc6 => No click.

wow, that's interesting.  thanks for tracking it down.

unfortuantely i cannot reproduce this problem with the combination of
alsa-lib CVS + alsa-utils CVS on my audigy.

is it possible that the behavior depends on the wav file to play?
if the file is not too big, could you send me the example wav file to
trigger this, so that i can test on my machine?


ciao,

Takashi


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Chris Rankin]

 --- Takashi Iwai <tiwai@suse.de> wrote:
> Hi Chris,
> 
> At Fri, 31 Jan 2003 19:56:51 +0000 (GMT),
> Chris Rankin wrote:
> > 
> >  --- Takashi Iwai <tiwai@suse.de> wrote:
> > > do you know which version (or date) the driver
> > > worked without clicks?
> > > there have been not many changes for emu10k1 or
> pcm
> > > stuffs recently.
> > 
> > On a hunch, I downloaded the alsa-lib-0.9.0rc6 and
> > alsa-util-0.9.0rc6 packages and tried those
> against
> > the current CVS version of the kernel modules.
> There
> > is no nasty clicking sound using 0.9.0rc6
> userspace.
> > 
> > Even more interesting:
> > 
> > alsa-lib 0.9.0rc6 + alsa-utils CVS => CLICK!
> > alsa-lib CVS + alsa-utils 0.9.0rc6 => No click.
> 
> wow, that's interesting.  thanks for tracking it
> down.
> 
> unfortuantely i cannot reproduce this problem with
> the combination of
> alsa-lib CVS + alsa-utils CVS on my audigy.
> 
> is it possible that the behavior depends on the wav
> file to play?
> if the file is not too big, could you send me the
> example wav file to
> trigger this, so that i can test on my machine?

Sure, although maybe you have them already? They're
the sounds from the Windows 95 sound schemes, such as
"Jungle: Windows start", "Jungle: Windows exit",
"Robotz: error" etc.

The *specific* change that causes the click is 1.156
in aplay.c. This change went in about 29th January.
However, having said that, I'm not entirely sure that
aplay 1.155 isn't chopping off the first little bit of
the WAV files either. And I tried using aplay with my
SoundScape driver last night, too (which hasn't
changed significantly for a very long time, and which
only glues the CS4321 and MPU-401 drivers together
anyway). With this sound card, I heard the WAV file
start playing then quickly RE-start playing... most
odd. It didn't used to do that, and the "click" sound
was also audible at the end with aplay.c 1.156 too.

Chris


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Takashi Iwai]

At Mon, 3 Feb 2003 13:38:15 +0000 (GMT),
Chris Rankin wrote:
> 
>  --- Takashi Iwai <tiwai@suse.de> wrote:
> > Hi Chris,
> > 
> > At Fri, 31 Jan 2003 19:56:51 +0000 (GMT),
> > Chris Rankin wrote:
> > > 
> > >  --- Takashi Iwai <tiwai@suse.de> wrote:
> > > > do you know which version (or date) the driver
> > > > worked without clicks?
> > > > there have been not many changes for emu10k1 or
> > pcm
> > > > stuffs recently.
> > > 
> > > On a hunch, I downloaded the alsa-lib-0.9.0rc6 and
> > > alsa-util-0.9.0rc6 packages and tried those
> > against
> > > the current CVS version of the kernel modules.
> > There
> > > is no nasty clicking sound using 0.9.0rc6
> > userspace.
> > > 
> > > Even more interesting:
> > > 
> > > alsa-lib 0.9.0rc6 + alsa-utils CVS => CLICK!
> > > alsa-lib CVS + alsa-utils 0.9.0rc6 => No click.
> > 
> > wow, that's interesting.  thanks for tracking it
> > down.
> > 
> > unfortuantely i cannot reproduce this problem with
> > the combination of
> > alsa-lib CVS + alsa-utils CVS on my audigy.
> > 
> > is it possible that the behavior depends on the wav
> > file to play?
> > if the file is not too big, could you send me the
> > example wav file to
> > trigger this, so that i can test on my machine?
> 
> Sure, although maybe you have them already? They're
> the sounds from the Windows 95 sound schemes, such as
> "Jungle: Windows start", "Jungle: Windows exit",
> "Robotz: error" etc.
> 
> The *specific* change that causes the click is 1.156
> in aplay.c. This change went in about 29th January.
> However, having said that, I'm not entirely sure that
> aplay 1.155 isn't chopping off the first little bit of
> the WAV files either. And I tried using aplay with my
> SoundScape driver last night, too (which hasn't
> changed significantly for a very long time, and which
> only glues the CS4321 and MPU-401 drivers together
> anyway). With this sound card, I heard the WAV file
> start playing then quickly RE-start playing... most
> odd. It didn't used to do that, and the "click" sound
> was also audible at the end with aplay.c 1.156 too.

could you try the latest cvs aplay.c?


thanks,

Takashi


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: EMU10K1 - CVS: nasty "click" at end of WAV files, and spurious extra modules.

[Chris Rankin]

 --- Takashi Iwai <tiwai@suse.de> wrote:
> could you try the latest cvs aplay.c?

That's solved the clicking problem. I'll need to
update the ALSA on my P120 to run further checks.
That's a Friday / weekend job.

Chris


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com