All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c
Date: Mon, 07 Feb 2022 17:10:19 +0100	[thread overview]
Message-ID: <s5hsfsuu07o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220207140617.341172-1-colin.i.king@gmail.com>

On Mon, 07 Feb 2022 15:06:17 +0100,
Colin Ian King wrote:
> 
> The variable c is being initialized in an outer for-loop and also
> re-initialized inside an inner for-loop. The first initialization
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

The code change looks OK, but when I apply your patch now, git-am
converts the Author address to your new @intel.com, and this
mismatches with the address in Signed-off-by.  Should I keep the
original gmail address, or would you fix up your Signed-off-by (and
From) for avoiding those inconsistency?


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: remove redundant assignment to variable c
Date: Mon, 07 Feb 2022 17:10:19 +0100	[thread overview]
Message-ID: <s5hsfsuu07o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220207140617.341172-1-colin.i.king@gmail.com>

On Mon, 07 Feb 2022 15:06:17 +0100,
Colin Ian King wrote:
> 
> The variable c is being initialized in an outer for-loop and also
> re-initialized inside an inner for-loop. The first initialization
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

The code change looks OK, but when I apply your patch now, git-am
converts the Author address to your new @intel.com, and this
mismatches with the address in Signed-off-by.  Should I keep the
original gmail address, or would you fix up your Signed-off-by (and
From) for avoiding those inconsistency?


thanks,

Takashi

  reply	other threads:[~2022-02-07 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 14:06 [PATCH] ALSA: usb-audio: remove redundant assignment to variable c Colin Ian King
2022-02-07 16:10 ` Takashi Iwai [this message]
2022-02-07 16:10   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hsfsuu07o.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=colin.i.king@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.