All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: alsa-devel@alsa-project.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword
Date: Wed, 08 Jul 2020 09:13:10 +0200	[thread overview]
Message-ID: <s5htuyibhtl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200707172847.GA27659@embeddedor>

On Tue, 07 Jul 2020 19:28:47 +0200,
Gustavo A. R. Silva wrote:
> --- a/sound/isa/msnd/msnd_pinnacle_mixer.c
> +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
> @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right)
>  	case MSND_MIXER_VOLUME:		/* master volume */
>  		writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft);
>  		writew(wRight, dev->SMA + SMA_wCurrMastVolRight);
> -		/* fall through */
> -
> +		fallthrough;
>  	case MSND_MIXER_AUX:			/* aux pot control */
>  		/* scaled by master volume */
>  		/* fall through */

Any reason to leave this?


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Jaroslav Kysela <perex@perex.cz>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword
Date: Wed, 08 Jul 2020 09:13:10 +0200	[thread overview]
Message-ID: <s5htuyibhtl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200707172847.GA27659@embeddedor>

On Tue, 07 Jul 2020 19:28:47 +0200,
Gustavo A. R. Silva wrote:
> --- a/sound/isa/msnd/msnd_pinnacle_mixer.c
> +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
> @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right)
>  	case MSND_MIXER_VOLUME:		/* master volume */
>  		writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft);
>  		writew(wRight, dev->SMA + SMA_wCurrMastVolRight);
> -		/* fall through */
> -
> +		fallthrough;
>  	case MSND_MIXER_AUX:			/* aux pot control */
>  		/* scaled by master volume */
>  		/* fall through */

Any reason to leave this?


thanks,

Takashi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword
Date: Wed, 08 Jul 2020 09:13:10 +0200	[thread overview]
Message-ID: <s5htuyibhtl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200707172847.GA27659@embeddedor>

On Tue, 07 Jul 2020 19:28:47 +0200,
Gustavo A. R. Silva wrote:
> --- a/sound/isa/msnd/msnd_pinnacle_mixer.c
> +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
> @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right)
>  	case MSND_MIXER_VOLUME:		/* master volume */
>  		writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft);
>  		writew(wRight, dev->SMA + SMA_wCurrMastVolRight);
> -		/* fall through */
> -
> +		fallthrough;
>  	case MSND_MIXER_AUX:			/* aux pot control */
>  		/* scaled by master volume */
>  		/* fall through */

Any reason to leave this?


thanks,

Takashi

  reply	other threads:[~2020-07-08  7:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 17:28 [PATCH] ALSA: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-07 17:28 ` Gustavo A. R. Silva
2020-07-07 17:28 ` Gustavo A. R. Silva
2020-07-08  7:13 ` Takashi Iwai [this message]
2020-07-08  7:13   ` Takashi Iwai
2020-07-08  7:13   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htuyibhtl.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=gustavoars@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.