All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: potential uninitialized return values
Date: Tue, 27 Mar 2018 15:21:20 +0200	[thread overview]
Message-ID: <s5htvt18xin.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180327130752.GA31841@mwanda>

On Tue, 27 Mar 2018 15:07:52 +0200,
Dan Carpenter wrote:
> 
> Smatch complains that "tmp" can be uninitialized if we do a zero size
> write.
> 
> Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, that's an oversight indeed.  Applied now.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: potential uninitialized return values
Date: Tue, 27 Mar 2018 13:21:20 +0000	[thread overview]
Message-ID: <s5htvt18xin.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180327130752.GA31841@mwanda>

On Tue, 27 Mar 2018 15:07:52 +0200,
Dan Carpenter wrote:
> 
> Smatch complains that "tmp" can be uninitialized if we do a zero size
> write.
> 
> Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, that's an oversight indeed.  Applied now.


Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: pcm: potential uninitialized return values
Date: Tue, 27 Mar 2018 15:21:20 +0200	[thread overview]
Message-ID: <s5htvt18xin.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180327130752.GA31841@mwanda>

On Tue, 27 Mar 2018 15:07:52 +0200,
Dan Carpenter wrote:
> 
> Smatch complains that "tmp" can be uninitialized if we do a zero size
> write.
> 
> Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, that's an oversight indeed.  Applied now.


Takashi

  reply	other threads:[~2018-03-27 13:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 13:07 [PATCH] ALSA: pcm: potential uninitialized return values Dan Carpenter
2018-03-27 13:07 ` Dan Carpenter
2018-03-27 13:07 ` Dan Carpenter
2018-03-27 13:21 ` Takashi Iwai [this message]
2018-03-27 13:21   ` Takashi Iwai
2018-03-27 13:21   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htvt18xin.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.