Re: btw

Re: btw

[mark]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On Tue, Oct 15, 2002 at 12:51:11PM +0200, Takashi Iwai wrote:
> At Mon, 14 Oct 2002 14:34:07 -0500,
> mark@undertone.org wrote:
> > 
> > I have got to stop spamming, you -- sincere apologies. Mixer apps will
> > start up, but it wont actually let me change any settings.
> 
> ok, could you show /etc/asound.state (suppose it works now :)
> it could be the mixer config problem.

Included. Seems like I should be able to read/write to the
device. Incidentally, with the code as it stands now (im guessing
because of that define invoked for testing), the mixer exhibits the
same exact behavior for the cs4281 card in my laptop. I can't change
any settings. I mean I can try to, and it seems to go "through" but
nothing changes.

> and, does aplay look as if working?
> i mean, the aplay starts and stops at the correct time length?
> please try to run "aplay -vv foo.wav".

It seems to "play" when i shove a wav into either pcmC1D0p or
pcmC1D0c.

> also, please check the status shown in /proc/asound/card0/stream0
> while running (playback or capture).

Included is the contents of the stream file while doing
so. Doesn't seem to be too revealing.

thanks,
-mark

[-- Attachment #2: asound.state --]
[-- Type: text/plain, Size: 8384 bytes --]

state.card0 {
	control.1 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Master Playback Switch'
		value false
	}
	control.2 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Master Playback Volume'
		value.0 0
		value.1 0
	}
	control.3 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Master Mono Playback Switch'
		value false
	}
	control.4 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Master Mono Playback Volume'
		value 0
	}
	control.5 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'PC Speaker Playback Switch'
		value false
	}
	control.6 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 15'
		iface MIXER
		name 'PC Speaker Playback Volume'
		value 0
	}
	control.7 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Phone Playback Switch'
		value false
	}
	control.8 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Phone Playback Volume'
		value 0
	}
	control.9 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Mic Playback Switch'
		value false
	}
	control.10 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Mic Playback Volume'
		value 0
	}
	control.11 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Mic Boost (+20dB)'
		value false
	}
	control.12 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Line Playback Switch'
		value false
	}
	control.13 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Line Playback Volume'
		value.0 0
		value.1 0
	}
	control.14 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'CD Playback Switch'
		value false
	}
	control.15 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'CD Playback Volume'
		value.0 0
		value.1 0
	}
	control.16 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Video Playback Switch'
		value false
	}
	control.17 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Video Playback Volume'
		value.0 0
		value.1 0
	}
	control.18 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Aux Playback Switch'
		value false
	}
	control.19 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Aux Playback Volume'
		value.0 0
		value.1 0
	}
	control.20 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'PCM Playback Switch'
		value false
	}
	control.21 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'PCM Playback Volume'
		value.0 0
		value.1 0
	}
	control.22 {
		comment.access 'read write'
		comment.type ENUMERATED
		comment.item.0 Mic
		comment.item.1 CD
		comment.item.2 Video
		comment.item.3 Aux
		comment.item.4 Line
		comment.item.5 Mix
		comment.item.6 'Mix Mono'
		comment.item.7 Phone
		iface MIXER
		name 'Capture Source'
		value.0 Mic
		value.1 Mic
	}
	control.23 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Capture Switch'
		value false
	}
	control.24 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 15'
		iface MIXER
		name 'Capture Volume'
		value.0 0
		value.1 0
	}
	control.25 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name '3D Control - Switch'
		value false
	}
	control.26 {
		comment.access 'read write'
		comment.type ENUMERATED
		comment.item.0 Mix
		comment.item.1 Mic
		iface MIXER
		name 'Mono Output Select'
		value Mix
	}
	control.27 {
		comment.access 'read write'
		comment.type ENUMERATED
		comment.item.0 Mic1
		comment.item.1 Mic2
		iface MIXER
		name 'Mic Select'
		value Mic1
	}
	control.28 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 3'
		iface MIXER
		name '3D Control Sigmatel - Depth'
		value 0
	}
	control.29 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'External Amplifier Power Down'
		value false
	}
	control.30 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'Synth Playback Volume'
		value.0 0
		value.1 0
	}
	control.31 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 31'
		iface MIXER
		name 'PCM Stream Playback Volume'
		value.0 0
		value.1 0
	}
}
state.card1 {
	control.1 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'PCM Playback Switch'
		value false
	}
	control.2 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'PCM Playback Volume'
		value 0
	}
	control.3 {
		comment.access 'read write'
		comment.type ENUMERATED
		comment.item.0 PCM
		comment.item.1 'Input 1'
		iface MIXER
		name 'Digital In Playback Source'
		value PCM
	}
	control.4 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Digital In Switch'
		value false
	}
	control.5 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Digital In Volume'
		value 0
	}
	control.6 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Line Playback Switch'
		value false
	}
	control.7 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Line Playback Volume'
		value.0 0
		value.1 0
	}
	control.8 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Line Playback Volume'
		index 1
		value 0
	}
	control.9 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name '3D Stereo Extender Switch'
		value false
	}
	control.10 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Mic Playback Switch'
		value false
	}
	control.11 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Mic Playback Volume'
		value 0
	}
	control.12 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Up Down Switch'
		value false
	}
	control.13 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 1'
		iface MIXER
		name 'Up Down Mode Select'
		value 0
	}
	control.14 {
		comment.access 'read write'
		comment.type ENUMERATED
		comment.item.0 'Input 0'
		comment.item.1 Mic
		comment.item.2 Mixer
		iface MIXER
		name 'Capture Source'
		value 'Input 0'
	}
	control.15 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Capture Switch'
		value false
	}
	control.16 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Capture Volume'
		value 0
	}
	control.17 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Master Playback Switch'
		value false
	}
	control.18 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Master Playback Volume'
		value.0 0
		value.1 0
		value.2 0
		value.3 0
		value.4 0
		value.5 0
	}
	control.19 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 25600'
		iface MIXER
		name 'Master Playback Volume'
		index 1
		value 0
	}
	control.20 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 96'
		iface MIXER
		name 'Tone Control - Bass'
		value 0
	}
	control.21 {
		comment.access 'read write'
		comment.type INTEGER
		comment.range '0 - 96'
		iface MIXER
		name 'Tone Control - Treble'
		value 0
	}
	control.22 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Speaker Playback Switch'
		value false
	}
	control.23 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Digital Out Playback Switch'
		value false
	}
	control.24 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Digital Out1 Playback Switch'
		value false
	}
	control.25 {
		comment.access 'read write'
		comment.type BOOLEAN
		iface MIXER
		name 'Digital Out2 Playback Switch'
		value false
	}
}

[-- Attachment #3: stream0-while-playing.txt --]
[-- Type: text/plain, Size: 724 bytes --]

Creative Technology Ltd. : USB Audio

Playback:
  Status: Stop
  Interface 1
    Altset 1
    Format: S16_LE
    Channels: 2
    Endpoint: 2 OUT (ASYNC)
    Rates: 48000

Capture:
  Status: Stop
  Interface 2
    Altset 1
    Format: S16_LE
    Channels: 2
    Endpoint: 6 IN (ASYNC)
    Rates: 8000
  Interface 2
    Altset 2
    Format: S16_LE
    Channels: 2
    Endpoint: 6 IN (ASYNC)
    Rates: 16000
  Interface 2
    Altset 3
    Format: S16_LE
    Channels: 2
    Endpoint: 6 IN (ASYNC)
    Rates: 24000
  Interface 2
    Altset 4
    Format: S16_LE
    Channels: 2
    Endpoint: 6 IN (ASYNC)
    Rates: 32000
  Interface 2
    Altset 5
    Format: S16_LE
    Channels: 2
    Endpoint: 6 IN (ASYNC)
    Rates: 48000

Re: btw

[Takashi Iwai]

At Tue, 15 Oct 2002 12:57:50 -0500,
mark@undertone.org wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Tue, Oct 15, 2002 at 12:51:11PM +0200, Takashi Iwai wrote:
> > At Mon, 14 Oct 2002 14:34:07 -0500,
> > mark@undertone.org wrote:
> > > 
> > > I have got to stop spamming, you -- sincere apologies. Mixer apps will
> > > start up, but it wont actually let me change any settings.
> > 
> > ok, could you show /etc/asound.state (suppose it works now :)
> > it could be the mixer config problem.
> 
> Included. Seems like I should be able to read/write to the
> device. Incidentally, with the code as it stands now (im guessing
> because of that define invoked for testing), the mixer exhibits the
> same exact behavior for the cs4281 card in my laptop. I can't change
> any settings. I mean I can try to, and it seems to go "through" but
> nothing changes.

IIRC, there was a bug in the recent changes.
i think it's fixed now on cvs.  please try to update the cvs tree
again.

> 
> > and, does aplay look as if working?
> > i mean, the aplay starts and stops at the correct time length?
> > please try to run "aplay -vv foo.wav".
> 
> It seems to "play" when i shove a wav into either pcmC1D0p or
> pcmC1D0c.
 
do you mean "aplay -Dhw:1,0 foo.wav" and "arecord -Dhw:1,0 foo.wav" ?
(please don't access to the ALSA device files directly.)


> > also, please check the status shown in /proc/asound/card0/stream0
> > while running (playback or capture).
> 
> Included is the contents of the stream file while doing
> so. Doesn't seem to be too revealing.

hmm, strangely, now you got only one playback, although there were
more at the previous time.
which usb control module are you using?
for example, i found that the behavior of device is different between
usb-uhci and uhci modules...


ciao,

Takashi


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: btw

[mark]

On Wed, Oct 16, 2002 at 12:15:20PM +0200, Takashi Iwai wrote:
> IIRC, there was a bug in the recent changes.
> i think it's fixed now on cvs.  please try to update the cvs tree
> again.

Ok - done.

> > It seems to "play" when i shove a wav into either pcmC1D0p or
> > pcmC1D0c.
>  
> do you mean "aplay -Dhw:1,0 foo.wav" and "arecord -Dhw:1,0 foo.wav" ?
> (please don't access to the ALSA device files directly.)

Hmm. It simply cannot reference a hw device, or anything related to
it. You mentioned once before that due to how the usb mechanism works,
no hw device will or can exist. But it seems like thats what all the
utils want to use; indeed, its what you pointed at in the example
above:

atrophy:~# aplay -Dhw:1,0 foo.wav 
Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
aplay: set_params:785: Sample format non available
atrophy:~# aplay -c1 sexy.wav 
Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
  <<<< it ran for a bit here, seemed to be cool with it
Aborted...
atrophy:~# amixer -Dhw:1,0
ALSA lib conf.c:3816:(parse_args) Unknown parameter 1
ALSA lib conf.c:3938:(snd_config_expand) Parse arguments error: No such file or directory
ALSA lib control.c:601:(snd_ctl_open_noupdate) Invalid CTL hw:1,0
amixer: Mixer attach hw:1,0 error: No such file or directory
atrophy:~# ls -l /dev/snd
total 0
crw-rw-rw-    1 root     root     116,   0 Dec 31  1969 controlC0
crw-rw-rw-    1 root     root     116,  32 Dec 31  1969 controlC1
crw-rw-rw-    1 root     root     116,  64 Dec 31  1969 controlC2
crw-rw-rw-    1 root     root     116,  96 Dec 31  1969 controlC3
crw-rw-rw-    1 root     root     116, 128 Dec 31  1969 controlC4
crw-rw-rw-    1 root     root     116, 160 Dec 31  1969 controlC5
crw-rw-rw-    1 root     root     116, 192 Dec 31  1969 controlC6
crw-rw-rw-    1 root     root     116, 224 Dec 31  1969 controlC7
crw-rw-rw-    1 root     root     116,   4 Dec 31  1969 hwC0D0
crw-rw-rw-    1 root     root     116,   8 Dec 31  1969 midiC0D0
crw-rw-rw-    1 root     root     116,  24 Dec 31  1969 pcmC0D0c
crw-rw-rw-    1 root     root     116,  16 Dec 31  1969 pcmC0D0p
crw-rw-rw-    1 root     root     116,  56 Dec 31  1969 pcmC1D0c
crw-rw-rw-    1 root     root     116,  48 Dec 31  1969 pcmC1D0p
crw-rw-rw-    1 root     root     116,   1 Dec 31  1969 seq
crw-rw-rw-    1 root     root     116,  33 Dec 31  1969 timer

Is it possible that this is just a devfs thing with regards to the usb
driver?

> hmm, strangely, now you got only one playback, although there were
> more at the previous time.
> which usb control module are you using?
> for example, i found that the behavior of device is different between
> usb-uhci and uhci modules...

I compiled both controler modules and have tried using them
interchangably. Same result. There is no difference in the stream0
file - checked with a diff.

-mark


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: btw

[Takashi Iwai]

At Wed, 16 Oct 2002 14:40:55 -0500,
mark@undertone.org wrote:
> 
> atrophy:~# aplay -Dhw:1,0 foo.wav 
> Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
> aplay: set_params:785: Sample format non available
> atrophy:~# aplay -c1 sexy.wav 
> Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
>   <<<< it ran for a bit here, seemed to be cool with it
> Aborted...

ah, since 8000Hz 8 bit is not supported on this device.
please use plughw instead of hw, that is,

	% aplay -Dplughw:1,0 foo.wav

> atrophy:~# amixer -Dhw:1,0
> ALSA lib conf.c:3816:(parse_args) Unknown parameter 1
> ALSA lib conf.c:3938:(snd_config_expand) Parse arguments error: No such file or directory
> ALSA lib control.c:601:(snd_ctl_open_noupdate) Invalid CTL hw:1,0
> amixer: Mixer attach hw:1,0 error: No such file or directory

for the control (mixer) interface, no second zero, that is, use
'-Dhw:1'.  (btw, it's equitvalent "amixer -c 1").

> 
> > hmm, strangely, now you got only one playback, although there were
> > more at the previous time.
> > which usb control module are you using?
> > for example, i found that the behavior of device is different between
> > usb-uhci and uhci modules...
> 
> I compiled both controler modules and have tried using them
> interchangably. Same result. There is no difference in the stream0
> file - checked with a diff.

you can check this also via the output of 'lsusb -v'.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: btw

[mark]

On Thu, Oct 17, 2002 at 10:26:48AM +0200, Takashi Iwai wrote:
> ah, since 8000Hz 8 bit is not supported on this device.
> please use plughw instead of hw, that is,
> 
> 	% aplay -Dplughw:1,0 foo.wav

atrophy:~# aplay -Dplughw:1,0 foo.wav
Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
ALSA lib pcm_hw.c:428:(snd_pcm_hw_prepare) SNDRV_PCM_IOCTL_PREPARE failed: Invalid argument
aplay: set_params:813: Unable to install hw params:
ACCESS:  RW_INTERLEAVED
FORMAT:  U8
SUBFORMAT:  STD
SAMPLE_BITS: 8
FRAME_BITS: 8
CHANNELS: 1
RATE: 8000
PERIOD_TIME: (124988 124989)
PERIOD_SIZE: (999 1000)
PERIOD_BYTES: (999 1000)
PERIODS: (4 5)
BUFFER_TIME: 500000
BUFFER_SIZE: 4000
BUFFER_BYTES: 4000
TICK_TIME: 10000
atrophy:~# 

I've tried an entire array of different wav's in different formats,
all with similar debugging output.

I've also tried installing various modules and drivers in a vain and
blind attempt to just get it to play the stream. What "is supported"
natively by the driver?

> for the control (mixer) interface, no second zero, that is, use
> '-Dhw:1'.  (btw, it's equitvalent "amixer -c 1").

Yes, I've been able to mix the thing properly now. Thanks. Uh, I'm
guessing the code is the best place to actually get a decent
description why this is?

> > I compiled both controler modules and have tried using them
> > interchangably. Same result. There is no difference in the stream0
> > file - checked with a diff.
> 
> you can check this also via the output of 'lsusb -v'.

Only differences were fairly cosmetic:

atrophy:~/alsa# diff uhci usb-uhci 
15c15
<   iProduct                2 USB UHCI-alt Root Hub
---
>   iProduct                2 USB UHCI Root Hub
50c50
< Bus 001 Device 002: ID 041e:3000 Creative Labs 
---
> Bus 001 Device 005: ID 041e:3000 Creative Labs 

I had to disconnect my minihub and connect only the extigy by itself
in order to use the usb-uhci driver. I normally only use uhci, as I
need to use a usb mouse and the extigy, which requires a hub that
doesnt like usb-uhci.

Given the output above, I'm probably doing something rather silly
again with regards to some kind of random compatibility issue. I am
still running the mixer with the debug hack you put in.

-mark


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: btw

[Takashi Iwai]

At Thu, 17 Oct 2002 08:42:35 -0500,
mark@undertone.org wrote:
> 
> On Thu, Oct 17, 2002 at 10:26:48AM +0200, Takashi Iwai wrote:
> > ah, since 8000Hz 8 bit is not supported on this device.
> > please use plughw instead of hw, that is,
> > 
> > 	% aplay -Dplughw:1,0 foo.wav
> 
> atrophy:~# aplay -Dplughw:1,0 foo.wav
> Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
> ALSA lib pcm_hw.c:428:(snd_pcm_hw_prepare) SNDRV_PCM_IOCTL_PREPARE failed: Invalid argument
> aplay: set_params:813: Unable to install hw params:
> ACCESS:  RW_INTERLEAVED
> FORMAT:  U8
> SUBFORMAT:  STD
> SAMPLE_BITS: 8
> FRAME_BITS: 8
> CHANNELS: 1
> RATE: 8000
> PERIOD_TIME: (124988 124989)
> PERIOD_SIZE: (999 1000)
> PERIOD_BYTES: (999 1000)
> PERIODS: (4 5)
> BUFFER_TIME: 500000
> BUFFER_SIZE: 4000
> BUFFER_BYTES: 4000
> TICK_TIME: 10000
> atrophy:~# 
> 
> I've tried an entire array of different wav's in different formats,
> all with similar debugging output.
> 
> I've also tried installing various modules and drivers in a vain and
> blind attempt to just get it to play the stream. What "is supported"
> natively by the driver?
 
this is shown exactly in /proc/asound/card*/stream*.
iirc, the 48000Hz 16bit 2ch is the only supported format on extigy.
(there should be more, but they are likely not parsed correctly - see
 below.)

but anyway it's strange that the format above is not accepted by
plughw.  please check

- whether the files mathing with native format are ok.
- whether the file above with OSS emulation works (which converts
  inside the kernel).


> > for the control (mixer) interface, no second zero, that is, use
> > '-Dhw:1'.  (btw, it's equitvalent "amixer -c 1").
> 
> Yes, I've been able to mix the thing properly now. Thanks. Uh, I'm
> guessing the code is the best place to actually get a decent
> description why this is?
> 
> > > I compiled both controler modules and have tried using them
> > > interchangably. Same result. There is no difference in the stream0
> > > file - checked with a diff.
> > 
> > you can check this also via the output of 'lsusb -v'.
> 
> Only differences were fairly cosmetic:
> 
> atrophy:~/alsa# diff uhci usb-uhci 
> 15c15
> <   iProduct                2 USB UHCI-alt Root Hub
> ---
> >   iProduct                2 USB UHCI Root Hub
> 50c50
> < Bus 001 Device 002: ID 041e:3000 Creative Labs 
> ---
> > Bus 001 Device 005: ID 041e:3000 Creative Labs 
> 
> I had to disconnect my minihub and connect only the extigy by itself
> in order to use the usb-uhci driver. I normally only use uhci, as I
> need to use a usb mouse and the extigy, which requires a hub that
> doesnt like usb-uhci.
> 
> Given the output above, I'm probably doing something rather silly
> again with regards to some kind of random compatibility issue. I am
> still running the mixer with the debug hack you put in.

i'm not sure what's going on there, but the lsusb output once you sent
me contains much more supported formats.
and i experienced that the similar phenomenon happened on other
usb-audio devices - not the whole descriptors are parsed.
the behavior might be changed if you reboot.  sigh...

i guess it's likely a bug of usb controller modules.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: Re: btw

[mark]

In a bit of good news, although playing back streams dont really want
to work, if I use the line in on the card and shove in the output from
my onboard sound card, I actually get sound of the card now while it
is connected via usb to the laptop. Earlier, the only way to get sound
of the card while booted into linux was to disconnect it completely
and use it as a stand-alone device in the same manner. As a result, I
can test a couple of the mixer settings for you. I'm using alsamixer
for this, doing it by hand via amixer would take a while . . .

The first 4 master controls control front,back, and center-woofer. Not
sure about the exchange with the last two, I only have a 4.1 sound
system hooked up into the device. "Master 1" is a general master that
controls all sound. Bass and treble follow... The PCM interface I
can't test, due to the same earlier problems. Line and Line 1 seem to
do the same thing for me at the moment. I would guess that "line" is
for the specific line in 1/8 jack im using in the front of the unit,
and that "line 1" is a general control for all input lines... it didnt
control the mic though. Only the "Mic" control controls the mic. 

Now on to the "odd" stuff ... I cant test the digital in and outs. I
just don't have another optical audio device here. The "Speaker"
interface seems like a master mute button. All other interfaces, uh,
don't seem to do anything. If you can suggest better ways to test, I'm
all ears. I could do more extensive testing if you like, but uh hmm
not sure exactly how the logistics of that would work out in real
life, heh.

Still cant seem to control the CMSS functionality (fake surround
sound). When the sound card has the usb hooked into the machine, the
CMSS switch is "locked" into whatever state it was in before
communicating with the machine. If its any hint, it would appear as
though all the front-panel controls (except the power) are disabled
once the device is communicating via usb. This includes the CMSS
button and two software-controled gain knobs for the Mic and master
volume. I say software controled because there is no internal,
traditional "hardware" mechanism with the knobs, its just a physical
interface to the gain levels I can otherwise control via software.

-Mark

(I have a feeling that the pcm in/out works just fine and I'm not
using the alsa software properly . . )


On Thu, Oct 17, 2002 at 08:42:35AM -0500, mark@undertone.org wrote:
> On Thu, Oct 17, 2002 at 10:26:48AM +0200, Takashi Iwai wrote:
> > ah, since 8000Hz 8 bit is not supported on this device.
> > please use plughw instead of hw, that is,
> > 
> > 	% aplay -Dplughw:1,0 foo.wav
> 
> atrophy:~# aplay -Dplughw:1,0 foo.wav
> Playing raw data 'foo.wav' : Unsigned 8 bit, Rate 8000 Hz, Mono
> ALSA lib pcm_hw.c:428:(snd_pcm_hw_prepare) SNDRV_PCM_IOCTL_PREPARE failed: Invalid argument
> aplay: set_params:813: Unable to install hw params:
> ACCESS:  RW_INTERLEAVED
> FORMAT:  U8
> SUBFORMAT:  STD
> SAMPLE_BITS: 8
> FRAME_BITS: 8
> CHANNELS: 1
> RATE: 8000
> PERIOD_TIME: (124988 124989)
> PERIOD_SIZE: (999 1000)
> PERIOD_BYTES: (999 1000)
> PERIODS: (4 5)
> BUFFER_TIME: 500000
> BUFFER_SIZE: 4000
> BUFFER_BYTES: 4000
> TICK_TIME: 10000
> atrophy:~# 
> 
> I've tried an entire array of different wav's in different formats,
> all with similar debugging output.
> 
> I've also tried installing various modules and drivers in a vain and
> blind attempt to just get it to play the stream. What "is supported"
> natively by the driver?
> 
> > for the control (mixer) interface, no second zero, that is, use
> > '-Dhw:1'.  (btw, it's equitvalent "amixer -c 1").
> 
> Yes, I've been able to mix the thing properly now. Thanks. Uh, I'm
> guessing the code is the best place to actually get a decent
> description why this is?
> 
> > > I compiled both controler modules and have tried using them
> > > interchangably. Same result. There is no difference in the stream0
> > > file - checked with a diff.
> > 
> > you can check this also via the output of 'lsusb -v'.
> 
> Only differences were fairly cosmetic:
> 
> atrophy:~/alsa# diff uhci usb-uhci 
> 15c15
> <   iProduct                2 USB UHCI-alt Root Hub
> ---
> >   iProduct                2 USB UHCI Root Hub
> 50c50
> < Bus 001 Device 002: ID 041e:3000 Creative Labs 
> ---
> > Bus 001 Device 005: ID 041e:3000 Creative Labs 
> 
> I had to disconnect my minihub and connect only the extigy by itself
> in order to use the usb-uhci driver. I normally only use uhci, as I
> need to use a usb mouse and the extigy, which requires a hub that
> doesnt like usb-uhci.
> 
> Given the output above, I'm probably doing something rather silly
> again with regards to some kind of random compatibility issue. I am
> still running the mixer with the debug hack you put in.
> 
> -mark
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by: viaVerio will pay you up to
> $1,000 for every account that you consolidate with us.
> http://ad.doubleclick.net/clk;4749864;7604308;v?
> http://www.viaverio.com/consolidator/osdn.cfm
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: btw

[mark]

On Thu, Oct 17, 2002 at 04:30:17PM +0200, Takashi Iwai wrote:
> this is shown exactly in /proc/asound/card*/stream*.

Neat.

> iirc, the 48000Hz 16bit 2ch is the only supported format on extigy.
> (there should be more, but they are likely not parsed correctly - see
>  below.)

How very interesting. I immediately start wondering how it processes
3d audiofiles or surround sound off a dvd... left as an exersise for
myself I guess...

> but anyway it's strange that the format above is not accepted by
> plughw.  please check
> 
> - whether the files mathing with native format are ok.

Yup, seems to work fine. To continue the testing from before with this
newfound pcm stream, the only newfound knowledge is that the "pcm"
control seems to work.

> - whether the file above with OSS emulation works (which converts
>   inside the kernel).

Uh hmm doesn't seem to. I'm truthfully not sure of the most ideal way
to test this. I tested it by loading up the alsa-oss modules and using
some oss programs that reference /dev/dsp (which in this case gets
symlinked to sound/dsp).

> i'm not sure what's going on there, but the lsusb output once you sent
> me contains much more supported formats.
> and i experienced that the similar phenomenon happened on other
> usb-audio devices - not the whole descriptors are parsed.
> the behavior might be changed if you reboot.  sigh...

I've rebooted many times. Seems consistant.

> i guess it's likely a bug of usb controller modules.

Suck. With the work being put in, I wonder how hard it would be to
cajole Creative Labs to ship you a free extigy to play with, heh. Who
knows, they might even end up supplying some specs.

-mark


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: Re: btw

[Patrick Shirkey]

mark@undertone.org wrote:

>>Given the output above, I'm probably doing something rather silly
>>again with regards to some kind of random compatibility issue. I am
>>still running the mixer with the debug hack you put in.
>>

I was having some problems with my usb card which seemed related to the 
uhci controller and they went away when I upgraded the kernel. Are you 
using a kernel newer then 2.4.19?




-- 
Patrick Shirkey - Boost Hardware Ltd.
For the discerning hardware connoisseur
Http://www.boosthardware.com
Http://www.djcj.org - The Linux Audio Users guide
========================================

"Um...symbol_get and symbol_put... They're
kindof like does anyone remember like get_symbol
and put_symbol I think we used to have..."
- Rusty Russell in his talk on the module subsystem



-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: Re: btw

[Patrick Shirkey]

mark@undertone.org wrote:
> 
> (I have a feeling that the pcm in/out works just fine and I'm not
> using the alsa software properly . . )
> 

There is a quick toot for aplay/arecord

http://www.djcj.org/LAU/quicktoots/

-- 
Patrick Shirkey - Boost Hardware Ltd.
For the discerning hardware connoisseur
Http://www.boosthardware.com
Http://www.djcj.org - The Linux Audio Users guide
========================================

"Um...symbol_get and symbol_put... They're
kindof like does anyone remember like get_symbol
and put_symbol I think we used to have..."
- Rusty Russell in his talk on the module subsystem



-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: btw

[Takashi Iwai]

At Thu, 17 Oct 2002 10:20:42 -0500,
mark@undertone.org wrote:
> 
> > - whether the files mathing with native format are ok.
> 
> Yup, seems to work fine. To continue the testing from before with this
> newfound pcm stream, the only newfound knowledge is that the "pcm"
> control seems to work.

a good news!


> > - whether the file above with OSS emulation works (which converts
> >   inside the kernel).
> 
> Uh hmm doesn't seem to. I'm truthfully not sure of the most ideal way
> to test this. I tested it by loading up the alsa-oss modules and using
> some oss programs that reference /dev/dsp (which in this case gets
> symlinked to sound/dsp).
 
i guess you got some kernel messages when aplay fails, such like
"cannot set format: ..." ?  could you show the message?


> > i'm not sure what's going on there, but the lsusb output once you sent
> > me contains much more supported formats.
> > and i experienced that the similar phenomenon happened on other
> > usb-audio devices - not the whole descriptors are parsed.
> > the behavior might be changed if you reboot.  sigh...
> 
> I've rebooted many times. Seems consistant.

well, but you got once better results.
possibly this can be a bug of the usb-audio driver.
is the driver built with --with-debug=detect option?
if so, please show the kernel messages, and we get to know what
happened.


> > i guess it's likely a bug of usb controller modules.
> 
> Suck. With the work being put in, I wonder how hard it would be to
> cajole Creative Labs to ship you a free extigy to play with, heh. Who
> knows, they might even end up supplying some specs.

:)

Takashi


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: Re: btw

[Takashi Iwai]

At Thu, 17 Oct 2002 09:44:40 -0500,
mark@undertone.org wrote:
> 
> In a bit of good news, although playing back streams dont really want
> to work, if I use the line in on the card and shove in the output from
> my onboard sound card, I actually get sound of the card now while it
> is connected via usb to the laptop. Earlier, the only way to get sound
> of the card while booted into linux was to disconnect it completely
> and use it as a stand-alone device in the same manner. As a result, I
> can test a couple of the mixer settings for you. I'm using alsamixer
> for this, doing it by hand via amixer would take a while . . .
 
alsamixer is also fine.  it can do most of things what amixer can.

> The first 4 master controls control front,back, and center-woofer. Not
> sure about the exchange with the last two, I only have a 4.1 sound
> system hooked up into the device. "Master 1" is a general master that
> controls all sound. Bass and treble follow... The PCM interface I
> can't test, due to the same earlier problems. Line and Line 1 seem to
> do the same thing for me at the moment. I would guess that "line" is
> for the specific line in 1/8 jack im using in the front of the unit,
> and that "line 1" is a general control for all input lines... it didnt
> control the mic though. Only the "Mic" control controls the mic. 
 
if you build the module with --with-debug=detect option, there are
kernel messages at loading module about which control corresponds to
which usb mixer unit such like

	[10] FU [PCM Playback] ch = 2, val = 0/10

the first number is the unit id and the second is the type of unit,
and the third is the ALSA control name (i.e. the name of mixer
element).
when you compare these unit ids with the picture in usbmixer_maps.c,
you'll get more clues.

it would be appreciated if it can be clarified, which inputs/outputs
correspond to what, so on.


> Now on to the "odd" stuff ... I cant test the digital in and outs.

i guess this is because the corresponding descriptors are not parsed.
but digital out might be possible by some switches, e.g. "Digital Out"
"Digital Out1", "Digital Out2", etc.

> I just don't have another optical audio device here. The "Speaker"
> interface seems like a master mute button. All other interfaces, uh,
> don't seem to do anything. If you can suggest better ways to test, I'm
> all ears. I could do more extensive testing if you like, but uh hmm
> not sure exactly how the logistics of that would work out in real
> life, heh.

there are many unknown switches.  please take a look at
usbmixer_maps.c.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm

Re: Extigy testing

[mark]

After having been pretty busy at work the past few weeks, this morning
I decided to give this testing another shot. Last time I had been able
to dicern or notice any change at all when most of the switches were
fliped... this time amixer/alsamixer simply seg faults. On console the
kernel just gives me a "divide error: 0000". If I attempt to tempt
fate a second time, the machine crashes with a polite hang and no
messages.

There is a ton of info I could fiesably provide, although I'm not sure
what good it would do. If there is something specific you need or
would like, just say. As a reminder, I am running alsa with two
soundcards; an onboard cs4281 and the extigy. Running amixer/alsamixer
against the cs4281 works perfectly fine.

-Mark

On Thu, Oct 17, 2002 at 07:08:19PM +0200, Takashi Iwai wrote:
> At Thu, 17 Oct 2002 09:44:40 -0500,
> mark@undertone.org wrote:
> > 
> > In a bit of good news, although playing back streams dont really want
> > to work, if I use the line in on the card and shove in the output from
> > my onboard sound card, I actually get sound of the card now while it
> > is connected via usb to the laptop. Earlier, the only way to get sound
> > of the card while booted into linux was to disconnect it completely
> > and use it as a stand-alone device in the same manner. As a result, I
> > can test a couple of the mixer settings for you. I'm using alsamixer
> > for this, doing it by hand via amixer would take a while . . .
>  
> alsamixer is also fine.  it can do most of things what amixer can.
> 
> > The first 4 master controls control front,back, and center-woofer. Not
> > sure about the exchange with the last two, I only have a 4.1 sound
> > system hooked up into the device. "Master 1" is a general master that
> > controls all sound. Bass and treble follow... The PCM interface I
> > can't test, due to the same earlier problems. Line and Line 1 seem to
> > do the same thing for me at the moment. I would guess that "line" is
> > for the specific line in 1/8 jack im using in the front of the unit,
> > and that "line 1" is a general control for all input lines... it didnt
> > control the mic though. Only the "Mic" control controls the mic. 
>  
> if you build the module with --with-debug=detect option, there are
> kernel messages at loading module about which control corresponds to
> which usb mixer unit such like
> 
> 	[10] FU [PCM Playback] ch = 2, val = 0/10
> 
> the first number is the unit id and the second is the type of unit,
> and the third is the ALSA control name (i.e. the name of mixer
> element).
> when you compare these unit ids with the picture in usbmixer_maps.c,
> you'll get more clues.
> 
> it would be appreciated if it can be clarified, which inputs/outputs
> correspond to what, so on.
> 
> 
> > Now on to the "odd" stuff ... I cant test the digital in and outs.
> 
> i guess this is because the corresponding descriptors are not parsed.
> but digital out might be possible by some switches, e.g. "Digital Out"
> "Digital Out1", "Digital Out2", etc.
> 
> > I just don't have another optical audio device here. The "Speaker"
> > interface seems like a master mute button. All other interfaces, uh,
> > don't seem to do anything. If you can suggest better ways to test, I'm
> > all ears. I could do more extensive testing if you like, but uh hmm
> > not sure exactly how the logistics of that would work out in real
> > life, heh.
> 
> there are many unknown switches.  please take a look at
> usbmixer_maps.c.
> 
> 
> Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Extigy testing

[Jaroslav Kysela]

On Mon, 25 Nov 2002, mark@undertone.org wrote:

> After having been pretty busy at work the past few weeks, this morning
> I decided to give this testing another shot. Last time I had been able
> to dicern or notice any change at all when most of the switches were
> fliped... this time amixer/alsamixer simply seg faults. On console the
> kernel just gives me a "divide error: 0000". If I attempt to tempt
> fate a second time, the machine crashes with a polite hang and no
> messages.

Could you try this patch?

--- usbmixer.c  24 Nov 2002 10:35:39 -0000      1.11
+++ usbmixer.c  25 Nov 2002 13:50:23 -0000
@@ -599,6 +599,8 @@
                        if (get_ctl_value(cval, GET_RES, (cval->control << 8) | minchn, &cval->res) < 0)
                                cval->res = last_valid_res;
                }
+               if (cval->res == 0)
+                       cval->res = 1;
                cval->initialized = 1;
        }
        return 0;


						Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project, SuSE Labs



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Extigy testing

[mark]

Nope, doesn't work. I attempted to try and dork around with gdb, but
apparently gdb abilities need quite a bit more dusting off.

-mark

On Mon, Nov 25, 2002 at 02:50:13PM +0100, Jaroslav Kysela wrote:
> On Mon, 25 Nov 2002, mark@undertone.org wrote:
> 
> > After having been pretty busy at work the past few weeks, this morning
> > I decided to give this testing another shot. Last time I had been able
> > to dicern or notice any change at all when most of the switches were
> > fliped... this time amixer/alsamixer simply seg faults. On console the
> > kernel just gives me a "divide error: 0000". If I attempt to tempt
> > fate a second time, the machine crashes with a polite hang and no
> > messages.
> 
> Could you try this patch?
> 
> --- usbmixer.c  24 Nov 2002 10:35:39 -0000      1.11
> +++ usbmixer.c  25 Nov 2002 13:50:23 -0000
> @@ -599,6 +599,8 @@
>                         if (get_ctl_value(cval, GET_RES, (cval->control << 8) | minchn, &cval->res) < 0)
>                                 cval->res = last_valid_res;
>                 }
> +               if (cval->res == 0)
> +                       cval->res = 1;
>                 cval->initialized = 1;
>         }
>         return 0;


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: BTW

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 2849 bytes --]

On Wed, Oct 20, 2004 at 09:43:05PM -0700, David S. Miller wrote:

> Linus has the tcp_diag changes in his tree from Herbert.
> So you can work on the updated version of your netlink
> changes if you wish.

Here you go. Please note I know that code way too little in order to
determine if it fully fixes all cases.

Signed-off-by: Harald Welte <laforge@netfilter.org>

diff -Nru --exclude-from=/sunbeam/home/laforge/scripts/dontdiff linux-2.6.9-bk7/net/ipv4/tcp_diag.c linux-2.6.9-bk7-netlink_f_multi/net/ipv4/tcp_diag.c
--- linux-2.6.9-bk7/net/ipv4/tcp_diag.c	2004-10-22 18:18:52.000000000 +0200
+++ linux-2.6.9-bk7-netlink_f_multi/net/ipv4/tcp_diag.c	2004-10-22 19:50:43.000000000 +0200
@@ -108,7 +108,7 @@
 }
 
 static int tcpdiag_fill(struct sk_buff *skb, struct sock *sk,
-			int ext, u32 pid, u32 seq)
+			int ext, u32 pid, u32 seq, u16 nlmsg_flags)
 {
 	struct inet_opt *inet = inet_sk(sk);
 	struct tcp_opt *tp = tcp_sk(sk);
@@ -235,6 +235,7 @@
 	}
 
 	nlh->nlmsg_len = skb->tail - b;
+	nlh->nlmsg_flags = nlmsg_flags;
 	return skb->len;
 
 nlmsg_failure:
@@ -291,7 +292,7 @@
 
 	if (tcpdiag_fill(rep, sk, req->tcpdiag_ext,
 			 NETLINK_CB(in_skb).pid,
-			 nlh->nlmsg_seq) <= 0)
+			 nlh->nlmsg_seq, 0) <= 0)
 		BUG();
 
 	err = netlink_unicast(tcpnl, rep, NETLINK_CB(in_skb).pid, MSG_DONTWAIT);
@@ -497,7 +498,7 @@
 	}
 
 	return tcpdiag_fill(skb, sk, r->tcpdiag_ext, NETLINK_CB(cb->skb).pid,
-			    cb->nlh->nlmsg_seq);
+			    cb->nlh->nlmsg_seq, NLM_F_MULTI);
 }
 
 static int tcpdiag_fill_req(struct sk_buff *skb, struct sock *sk,
@@ -512,6 +513,7 @@
 
 	nlh = NLMSG_PUT(skb, pid, seq, TCPDIAG_GETSOCK, sizeof(*r));
 	r = NLMSG_DATA(nlh);
+	nlh->nlmsg_flags = NLM_F_MULTI;
 
 	r->tcpdiag_family = sk->sk_family;
 	r->tcpdiag_state = TCP_SYN_RECV;
diff -Nru --exclude-from=/sunbeam/home/laforge/scripts/dontdiff linux-2.6.9-bk7/net/xfrm/xfrm_user.c linux-2.6.9-bk7-netlink_f_multi/net/xfrm/xfrm_user.c
--- linux-2.6.9-bk7/net/xfrm/xfrm_user.c	2004-10-18 23:54:32.000000000 +0200
+++ linux-2.6.9-bk7-netlink_f_multi/net/xfrm/xfrm_user.c	2004-10-22 18:17:42.000000000 +0200
@@ -351,7 +351,10 @@
 	nlh = NLMSG_PUT(skb, NETLINK_CB(in_skb).pid,
 			sp->nlmsg_seq,
 			XFRM_MSG_NEWSA, sizeof(*p));
-	nlh->nlmsg_flags = 0;
+	if (NETLINK_CB(in_skb).pid && (count || sp->this_idx))
+		nlh->nlmsg_flags = NLM_F_MULTI;
+	else
+		nlh->nlmsg_flags = 0;
 
 	p = NLMSG_DATA(nlh);
 	copy_to_user_state(x, p);
-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: BTW

[Herbert Xu]

Harald Welte <laforge@netfilter.org> wrote:
>
> +++ linux-2.6.9-bk7-netlink_f_multi/net/ipv4/tcp_diag.c 2004-10-22 19:50:43.000000000 +0200
> @@ -108,7 +108,7 @@
> }
> 
> static int tcpdiag_fill(struct sk_buff *skb, struct sock *sk,
> -                       int ext, u32 pid, u32 seq)
> +                       int ext, u32 pid, u32 seq, u16 nlmsg_flags)
> {
>        struct inet_opt *inet = inet_sk(sk);
>        struct tcp_opt *tp = tcp_sk(sk);
> @@ -235,6 +235,7 @@
>        }
> 
>        nlh->nlmsg_len = skb->tail - b;
> +       nlh->nlmsg_flags = nlmsg_flags;

This doesn't set it for the tw sockets.  So just set it at the top
of the function instead.

The rest of the tcp_diag stuff looks good.

> @@ -351,7 +351,10 @@
>        nlh = NLMSG_PUT(skb, NETLINK_CB(in_skb).pid,
>                        sp->nlmsg_seq,
>                        XFRM_MSG_NEWSA, sizeof(*p));
> -       nlh->nlmsg_flags = 0;
> +       if (NETLINK_CB(in_skb).pid && (count || sp->this_idx))
> +               nlh->nlmsg_flags = NLM_F_MULTI;
> +       else
> +               nlh->nlmsg_flags = 0;

Yuck.  Please put this into xfrm_dump_info.

And it would be good to fix the other dumper in this file (xfrm_dump_policy)
as well.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt