Patch: YMF753 AC '97

Patch: YMF753 AC '97

[David Shust]

I've written a patches for the 0.9.0rc2 and 0.9.0rc3 ac97-codec driver in order to support the Yamaha YMF753. This chip is used in the Toshiba Satellite 5000. Support is provided for S/PDIF output, enhanced (wide) stereo, and the non-standard tone controls. All features appear to work.

Grab it here: www.shustring.net

I would be delighted to have this merged with the ALSA driver, provided that my copyright notice is left intact. It is only written to the console if and when the YMF753 is actually detected: ALSA AC'97 patch for Yamaha YMF753 (c) David Shust <dshust@shustring.com>

Is this an unreasonable request?

Regards,
David Shust


------------------------------------------------------------
Free, BeOS-friendly email accounts: http://BeMail.org/
BeOS News and Community: http://www.BeGroovy.com/


---------------------------------------------------------------------
Express yourself with a super cool email address from BigMailBox.com.
Hundreds of choices. It's free!
http://www.bigmailbox.com
---------------------------------------------------------------------


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Patch: YMF753 AC '97

[Clemens Ladisch]

David Shust wrote:
> I would be delighted to have this merged with the ALSA driver,
> provided that my copyright notice is left intact. It is only written
> to the console if and when the YMF753 is actually detected: ALSA AC'97
> patch for Yamaha YMF753 (c) David Shust <dshust@shustring.com>
>
> Is this an unreasonable request?

If by "unreasonable" you mean "unenforcable", the answer would be yes.
By the GPL, anybody is entitled to remove the printk and to redistribute
your code.

In practice, nobody would bother.  ;-)


Regards
Clemens



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Patch: YMF753 AC '97

[Takashi Iwai]

At Mon, 23 Sep 2002 21:28:09 -0700,
David Shust wrote:
> 
> I've written a patches for the 0.9.0rc2 and 0.9.0rc3 ac97-codec
> driver in order to support the Yamaha YMF753. This chip is used in
> the Toshiba Satellite 5000. Support is provided for S/PDIF output,
> enhanced (wide) stereo, and the non-standard tone controls. All
> features appear to work. 
> 
> Grab it here: www.shustring.net

thanks for your patch.
the patch looks good except for the module options for spdif.
since ac97_codec is a generic module, it's better to avoid such device
specific options.  isn't it detectable?

> I would be delighted to have this merged with the ALSA driver,
> provided that my copyright notice is left intact. It is only written
> to the console if and when the YMF753 is actually detected: ALSA
> AC'97 patch for Yamaha YMF753 (c) David Shust <dshust@shustring.com> 
> 
> Is this an unreasonable request?

we can keep it if you want, but please note that we don't print any
messages generally from the ALSA driver.


ciao,

Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Patch: YMF753 AC '97

[Jaroslav Kysela]

On Tue, 24 Sep 2002, Takashi Iwai wrote:

> At Mon, 23 Sep 2002 21:28:09 -0700,
> David Shust wrote:
> > 
> > I've written a patches for the 0.9.0rc2 and 0.9.0rc3 ac97-codec
> > driver in order to support the Yamaha YMF753. This chip is used in
> > the Toshiba Satellite 5000. Support is provided for S/PDIF output,
> > enhanced (wide) stereo, and the non-standard tone controls. All
> > features appear to work. 
> > 
> > Grab it here: www.shustring.net
> 
> thanks for your patch.
> the patch looks good except for the module options for spdif.
> since ac97_codec is a generic module, it's better to avoid such device
> specific options.  isn't it detectable?
> 
> > I would be delighted to have this merged with the ALSA driver,
> > provided that my copyright notice is left intact. It is only written
> > to the console if and when the YMF753 is actually detected: ALSA
> > AC'97 patch for Yamaha YMF753 (c) David Shust <dshust@shustring.com> 
> > 
> > Is this an unreasonable request?
> 
> we can keep it if you want, but please note that we don't print any
> messages generally from the ALSA driver.

Yes, it would be good to follow this policy for users who want to spend a 
few kilobytes of memory and auto-loading modules. We will be happy to 
include your copyright to the source comments.

						Jaroslav

-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project  http://www.alsa-project.org
SuSE Linux    http://www.suse.com



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf