Re: minor bug in make-install target

Re: minor bug in make-install target

[Jörn Nettingsmeier]

Takashi Iwai wrote:
> 
> Hi,
> 
> At Thu, 31 Jan 2002 10:53:24 +0100,
> Jörn Nettingsmeier wrote:
> >
> > hello jaroslav !
> >
> > i just found a minor bug in the make install target of alsa-driver:
> >
> > on my system, /usr/src is a link to /data1/src (which is another
> > disk).
> >
> > i have alsa sources on /usr/src/alsa-cvs/alsa-driver
> >
> > when i "make install" the kernel modules, i end up with
> > /lib/modules/<version>/kernel/sound/data1/src/alsa-cvs/alsa-driver/{acore,pci,synth}
> >
> > is it possible to fix the script so that it uses the correct paths
> > even when it's a link ?
> >
> > btw, i also tried a relative link (src -> ../data/src), but the
> > problem remains.
> >
> > moving the module tree by hand works for me, and it might not be
> > worth fixing when the stuff goes into the kernel anyway, but i
> > thought you might want to know.
> 
> I fixed on cvs.
> 
> now Rules.make guesses the destination directory from TREETOPDIR
> variable, which is exported from the toplevel Makefile, so that TOPDIR
> defined in each sub directory doesn't matter.
> 
> this mechanism seems working at least on my system.
> please give a try.

hi takashi !

sorry for the long delay. i have just checked out alsa-cvs again,
and the problem remains.
i still get
/lib/modules/2.4.18-pre9/kernel/sound/data1/src/alsa-cvs/alsa-driver/{pci,acore,synth}

regards,

jörn



-- 
Jörn Nettingsmeier     
home://Kurfürstenstr.49.45138.Essen.Germany      
phone://+49.201.491621
http://spunk.dnsalias.org
http://www.linuxdj.com/audio/lad/

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: minor bug in make-install target

[Takashi Iwai]

At Sun, 10 Feb 2002 12:59:12 +0100,
Jörn Nettingsmeier wrote:
> 
> Takashi Iwai wrote:
> > 
> > Hi,
> > 
> > At Thu, 31 Jan 2002 10:53:24 +0100,
> > Jörn Nettingsmeier wrote:
> > >
> > > hello jaroslav !
> > >
> > > i just found a minor bug in the make install target of alsa-driver:
> > >
> > > on my system, /usr/src is a link to /data1/src (which is another
> > > disk).
> > >
> > > i have alsa sources on /usr/src/alsa-cvs/alsa-driver
> > >
> > > when i "make install" the kernel modules, i end up with
> > > /lib/modules/<version>/kernel/sound/data1/src/alsa-cvs/alsa-driver/{acore,pci,synth}
> > >
> > > is it possible to fix the script so that it uses the correct paths
> > > even when it's a link ?
> > >
> > > btw, i also tried a relative link (src -> ../data/src), but the
> > > problem remains.
> > >
> > > moving the module tree by hand works for me, and it might not be
> > > worth fixing when the stuff goes into the kernel anyway, but i
> > > thought you might want to know.
> > 
> > I fixed on cvs.
> > 
> > now Rules.make guesses the destination directory from TREETOPDIR
> > variable, which is exported from the toplevel Makefile, so that TOPDIR
> > defined in each sub directory doesn't matter.
> > 
> > this mechanism seems working at least on my system.
> > please give a try.
> 
> hi takashi !
> 
> sorry for the long delay. i have just checked out alsa-cvs again,
> and the problem remains.
> i still get
> /lib/modules/2.4.18-pre9/kernel/sound/data1/src/alsa-cvs/alsa-driver/{pci,acore,synth}

please check whether your MAINSRCDIR is defined in Makefile.conf
correctly, in your case, /data1/src/alsa-cvs/alsa-driver.
the latest Rules.make reduces the path name according to this
variable.  it's possbile that the path name is different due to
symlinks..


Takashi

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: minor bug in make-install target

[Jörn Nettingsmeier]

Takashi Iwai wrote:
> 
> At Sun, 10 Feb 2002 12:59:12 +0100,
> Jörn Nettingsmeier wrote:
> >
> > Takashi Iwai wrote:
> > >
> > > Hi,
> > >
> > > At Thu, 31 Jan 2002 10:53:24 +0100,
> > > Jörn Nettingsmeier wrote:
> > > >
> > > > hello jaroslav !
> > > >
> > > > i just found a minor bug in the make install target of alsa-driver:
> > > >
> > > > on my system, /usr/src is a link to /data1/src (which is another
> > > > disk).
> > > >
> > > > i have alsa sources on /usr/src/alsa-cvs/alsa-driver
> > > >
> > > > when i "make install" the kernel modules, i end up with
> > > > /lib/modules/<version>/kernel/sound/data1/src/alsa-cvs/alsa-driver/{acore,pci,synth}
> > > >
> > > > is it possible to fix the script so that it uses the correct paths
> > > > even when it's a link ?
> > > >
> > > > btw, i also tried a relative link (src -> ../data/src), but the
> > > > problem remains.
> > > >
> > > > moving the module tree by hand works for me, and it might not be
> > > > worth fixing when the stuff goes into the kernel anyway, but i
> > > > thought you might want to know.
> > >
> > > I fixed on cvs.
> > >
> > > now Rules.make guesses the destination directory from TREETOPDIR
> > > variable, which is exported from the toplevel Makefile, so that TOPDIR
> > > defined in each sub directory doesn't matter.
> > >
> > > this mechanism seems working at least on my system.
> > > please give a try.
> >
> > hi takashi !
> >
> > sorry for the long delay. i have just checked out alsa-cvs again,
> > and the problem remains.
> > i still get
> > /lib/modules/2.4.18-pre9/kernel/sound/data1/src/alsa-cvs/alsa-driver/{pci,acore,synth}
> 
> please check whether your MAINSRCDIR is defined in Makefile.conf
> correctly, in your case, /data1/src/alsa-cvs/alsa-driver.
> the latest Rules.make reduces the path name according to this
> variable.  it's possbile that the path name is different due to
> symlinks..

i have
mainsrcdir      = .
MAINSRCDIR      = /usr/src/alsa-cvs/alsa-driver

that's probably because i go to that directory via cd
/usr/src/alsa-cvs/alsa-driver.
how come the makefile ever knows we are in /data1/src ?
pwd reports /usr/...
if the makefile were just dumb enough, it would never even realize
the symlink. but where does this extra piece of intelligence creep
in ?

i would expect the following behaviour:
cd /usr/src/alsa-cvs/alsadriver => MAINSRCDIR =
/usr/src/alsa-cvs/alsa-driver
or
cd /data1/src/alsa-cvs/alsadriver => MAINSRCDIR =
/data1/src/alsa-cvs/alsa-driver

in either case, all it has to do is 
cd MAINSRCDIR; cp -R pci acore synth
/lib/modules/some-uname-magic/kernel/sound


thanks for your help so far,

regards,


jörn







-- 
Jörn Nettingsmeier     
home://Kurfürstenstr.49.45138.Essen.Germany      
phone://+49.201.491621
http://spunk.dnsalias.org
http://www.linuxdj.com/audio/lad/

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: minor bug in make-install target

[Takashi Iwai]

[-- Attachment #1: Type: text/plain, Size: 2540 bytes --]

At Mon, 11 Feb 2002 15:27:11 +0100,
Jörn Nettingsmeier wrote:
> 
> Takashi Iwai wrote:
> > 
> > At Sun, 10 Feb 2002 12:59:12 +0100,
> > Jörn Nettingsmeier wrote:
> > >
> > > Takashi Iwai wrote:
> > > >
> > > > Hi,
> > > >
> > > > At Thu, 31 Jan 2002 10:53:24 +0100,
> > > > Jörn Nettingsmeier wrote:
> > > > >
> > > > > hello jaroslav !
> > > > >
> > > > > i just found a minor bug in the make install target of alsa-driver:
> > > > >
> > > > > on my system, /usr/src is a link to /data1/src (which is another
> > > > > disk).
> > > > >
> > > > > i have alsa sources on /usr/src/alsa-cvs/alsa-driver
> > > > >
> > > > > when i "make install" the kernel modules, i end up with
> > > > > /lib/modules/<version>/kernel/sound/data1/src/alsa-cvs/alsa-driver/{acore,pci,synth}
> > > > >
> > > > > is it possible to fix the script so that it uses the correct paths
> > > > > even when it's a link ?
> > > > >
> > > > > btw, i also tried a relative link (src -> ../data/src), but the
> > > > > problem remains.
> > > > >
> > > > > moving the module tree by hand works for me, and it might not be
> > > > > worth fixing when the stuff goes into the kernel anyway, but i
> > > > > thought you might want to know.
> > > >
> > > > I fixed on cvs.
> > > >
> > > > now Rules.make guesses the destination directory from TREETOPDIR
> > > > variable, which is exported from the toplevel Makefile, so that TOPDIR
> > > > defined in each sub directory doesn't matter.
> > > >
> > > > this mechanism seems working at least on my system.
> > > > please give a try.
> > >
> > > hi takashi !
> > >
> > > sorry for the long delay. i have just checked out alsa-cvs again,
> > > and the problem remains.
> > > i still get
> > > /lib/modules/2.4.18-pre9/kernel/sound/data1/src/alsa-cvs/alsa-driver/{pci,acore,synth}
> > 
> > please check whether your MAINSRCDIR is defined in Makefile.conf
> > correctly, in your case, /data1/src/alsa-cvs/alsa-driver.
> > the latest Rules.make reduces the path name according to this
> > variable.  it's possbile that the path name is different due to
> > symlinks..
> 
> i have
> mainsrcdir      = .
> MAINSRCDIR      = /usr/src/alsa-cvs/alsa-driver
> 
> that's probably because i go to that directory via cd
> /usr/src/alsa-cvs/alsa-driver.
> how come the makefile ever knows we are in /data1/src ?
> pwd reports /usr/...

is /data1/src is symlinked to /usr/src?
what says /bin/pwd instead of built-in pwd?

if this inconsistency really comes from the different pwd's, then the
attached patch might solve the problem...



Takashi

[-- Attachment #2: pwd-fix.dif --]
[-- Type: application/octet-stream, Size: 497 bytes --]

Index: alsa-driver/configure.in
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/configure.in,v
retrieving revision 1.53
diff -u -r1.53 configure.in
--- alsa-driver/configure.in	4 Feb 2002 13:46:40 -0000	1.53
+++ alsa-driver/configure.in	11 Feb 2002 15:04:24 -0000
@@ -27,7 +27,7 @@
 
 dnl Check for current directory
 AC_MSG_CHECKING(for current directory)
-SRCDIR=`pwd`
+SRCDIR=`/bin/pwd`
 AC_SUBST(SRCDIR)
 AC_MSG_RESULT($SRCDIR)
 

FIXED: minor bug in make-install target

[Jörn Nettingsmeier]

Takashi Iwai wrote:
> 
> > > > > At Thu, 31 Jan 2002 10:53:24 +0100,
> > > > > Jörn Nettingsmeier wrote:
> > > > > >
> > > > > > hello jaroslav !
> > > > > >
> > > > > > i just found a minor bug in the make install target of alsa-driver:
> > > > > >
> > > > > > on my system, /usr/src is a link to /data1/src (which is another
> > > > > > disk).
> > > > > >
> > > > > > i have alsa sources on /usr/src/alsa-cvs/alsa-driver
> > > > > >
> > > > > > when i "make install" the kernel modules, i end up with
> > > > > > /lib/modules/<version>/kernel/sound/data1/src/alsa-cvs/alsa-driver/{acore,pci,synth}

> > > please check whether your MAINSRCDIR is defined in Makefile.conf
> > > correctly, in your case, /data1/src/alsa-cvs/alsa-driver.
> > > the latest Rules.make reduces the path name according to this
> > > variable.  it's possbile that the path name is different due to
> > > symlinks..
> >
> > i have
> > mainsrcdir      = .
> > MAINSRCDIR      = /usr/src/alsa-cvs/alsa-driver
> >
> > that's probably because i go to that directory via cd
> > /usr/src/alsa-cvs/alsa-driver.
> > how come the makefile ever knows we are in /data1/src ?
> > pwd reports /usr/...
> 
> is /data1/src is symlinked to /usr/src? 

the other way round:
#ls -ld /usr/src
lrwxrwxrwx    1 root     root           13 Jan 31 10:49 /usr/src ->
../data1/src/

> what says /bin/pwd instead of built-in pwd?

ooooh shit !

nettings@kleineronkel:/usr/src > pwd
/usr/src
nettings@kleineronkel:/usr/src > /bin/pwd
/data1/src

i wasn't even aware that bash has a built-in pwd. good guess, watson
!

> if this inconsistency really comes from the different pwd's, then the
> attached patch might solve the problem...

it does indeed. thanks heaps !

best regards,

jörn



-- 
Jörn Nettingsmeier     
home://Kurfürstenstr.49.45138.Essen.Germany      
phone://+49.201.491621
http://spunk.dnsalias.org
http://www.linuxdj.com/audio/lad/

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel