[PATCH] rme32 segfault fix

[PATCH] rme32 segfault fix

[Martin Langer]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]


Hi,

looks like rme32 in halfduplex mode is broken for playback (since v1.0.6).
You will get a segfault without this patch :(

Changes:
- disables buffer prefill in halfduplex mode, which fixes segmentation fault
  of rme32 for playback in halfduplex mode

Signed-Off by Martin Langer <martin-langer@gmx.de>


martin



[-- Attachment #2: rme32-halfduplex-fix.patch --]
[-- Type: text/plain, Size: 416 bytes --]

--- alsa-kernel/pci/rme32.c.ORIGINAL	Sun Sep 19 21:39:28 2004
+++ alsa-kernel/pci/rme32.c	Sun Sep 19 21:40:04 2004
@@ -1123,7 +1123,7 @@
 	}
 	
 	/* prefill playback buffer */
-	if (cmd == SNDRV_PCM_TRIGGER_START) {
+	if ((cmd == SNDRV_PCM_TRIGGER_START) && (rme32->fullduplex_mode)) {
 		snd_pcm_group_for_each(pos, substream) {
 			s = snd_pcm_group_substream_entry(pos);
 			if (s == rme32->playback_substream) {

Re: [PATCH] rme32 segfault fix

[Takashi Iwai]

At Sun, 19 Sep 2004 22:10:18 +0200,
Martin Langer wrote:
> 
> Hi,
> 
> looks like rme32 in halfduplex mode is broken for playback (since v1.0.6).
> You will get a segfault without this patch :(

Applied.  Thanks!


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php