All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/scaler: Prune YUV420 modes against the max source width
@ 2026-10-08  4:18 Arun R Murthy
  2026-10-08  4:27 ` ✓ CI.KUnit: success for drm/i915/scaler: Prune YUV420 modes against the max source width (rev2) Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Arun R Murthy @ 2026-10-08  4:18 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: suraj.kandpal, stable, Arun R Murthy

skl_scaler_mode_valid() compares the mode's hdisplay against the pipe
scaler maximum source height instead of the maximum source width, so
single pipe YUV420 modes are pruned against the wrong limit.

Compare against max_w instead of max_h.

Fixes: 3347b55f2c6c ("drm/i915/xe3lpd: Prune modes for YUV420")
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/skl_scaler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 7994b983d509..7e65c4fffbc0 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -145,7 +145,7 @@ skl_scaler_mode_valid(struct intel_display *display,
 
 	if (num_joined_pipes < 2 && output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
 		skl_scaler_max_src_size(display, &max_w, &max_h);
-		if (mode->hdisplay > max_h)
+		if (mode->hdisplay > max_w)
 			return MODE_NO_420;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] drm/i915/scaler: Prune YUV420 modes against the max source width
@ 2026-10-07  7:06 Arun R Murthy
  2026-10-07  7:17 ` sashiko-bot
  2026-10-07  8:03 ` Kandpal, Suraj
  0 siblings, 2 replies; 11+ messages in thread
From: Arun R Murthy @ 2026-10-07  7:06 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: suraj.kandpal, ankit.k.nautiyal, Arun R Murthy

skl_scaler_mode_valid() compares the mode's hdisplay against the pipe
scaler maximum source height instead of the maximum source width, so
single pipe YUV420 modes are pruned against the wrong limit.

Commit 3347b55f2c6c ("drm/i915/xe3lpd: Prune modes for YUV420") intended
to reject modes whose hdisplay exceeds the scaler horizontal source
limit, since pipe scaling does not support YUV420 for a source width
above 4096. Comparing against max_h makes the check far too permissive
from display 12 onwards, where max_h is 8192, and too strict on display
11, where max_h is 4096 while the horizontal limit is 5120.

Compare against max_w instead.

Fixes: 3347b55f2c6c ("drm/i915/xe3lpd: Prune modes for YUV420")
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 drivers/gpu/drm/i915/display/skl_scaler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index 7994b983d509..7e65c4fffbc0 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -145,7 +145,7 @@ skl_scaler_mode_valid(struct intel_display *display,
 
 	if (num_joined_pipes < 2 && output_format == INTEL_OUTPUT_FORMAT_YCBCR420) {
 		skl_scaler_max_src_size(display, &max_w, &max_h);
-		if (mode->hdisplay > max_h)
+		if (mode->hdisplay > max_w)
 			return MODE_NO_420;
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-10-08 14:08 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-08  4:18 [PATCH] drm/i915/scaler: Prune YUV420 modes against the max source width Arun R Murthy
2026-10-08  4:27 ` ✓ CI.KUnit: success for drm/i915/scaler: Prune YUV420 modes against the max source width (rev2) Patchwork
2026-10-08  4:30 ` [PATCH] drm/i915/scaler: Prune YUV420 modes against the max source width sashiko-bot
2026-10-08  5:08 ` ✓ i915.CI.BAT: success for drm/i915/scaler: Prune YUV420 modes against the max source width (rev2) Patchwork
2026-10-08  5:11 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-08  6:26 ` ✓ Xe.CI.FULL: " Patchwork
2026-10-08  9:45 ` ✓ i915.CI.Full: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-10-07  7:06 [PATCH] drm/i915/scaler: Prune YUV420 modes against the max source width Arun R Murthy
2026-10-07  7:17 ` sashiko-bot
2026-10-07  8:03 ` Kandpal, Suraj
2026-10-08 14:07   ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.