* [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
@ 2026-10-08 10:23 ` Aaradhana Sahu
2026-10-09 10:30 ` Krzysztof Kozlowski
2026-10-08 10:23 ` [PATCH ath-next 02/17] wifi: ath12k: Refactor PCI operations and MSI config structure Aaradhana Sahu
` (15 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:23 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
Add Devicetree binding documentation for the Qualcomm QCN6432 IEEE 802.11be
wireless device.
QCN6432 is attached to the WCSS Q6 subsystem and is represented as an AHB
platform device, even though the Wi-Fi hardware interfaces over PCIe.
Document the compatible string and the resources, including the Q6 remote
processor phandle, MSI interrupts, SMEM states and memory regions.
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
.../bindings/net/wireless/qcom,qcn6432-wifi.yaml | 149 +++++++++++++++++++++
1 file changed, 149 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml
new file mode 100644
index 000000000000..97d8885333fa
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml
@@ -0,0 +1,149 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/qcom,qcn6432-wifi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies QCN6432 wireless device
+
+maintainers:
+ - Jeff Johnson <jjohnson@kernel.org>
+
+description: |
+ Qualcomm Technologies QCN6432 is an IEEE 802.11be Wi-Fi device
+ associated with the WCSS Q6 subsystem. The device is represented
+ as a platform device and uses MSI interrupts for its Copy Engine
+ (CE) and Data Path (DP) rings.
+
+properties:
+ compatible:
+ enum:
+ - qcom,qcn6432-wifi
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ items:
+ - description: Fatal interrupt
+ - description: Ready interrupt
+ - description: Spawn acknowledge interrupt
+ - description: Stop acknowledge interrupt
+ - description: UMAC reset interrupt
+
+ interrupt-names:
+ items:
+ - const: fatal
+ - const: ready
+ - const: spawn
+ - const: stop-ack
+ - const: umac-reset
+
+ memory-region:
+ items:
+ - description: Q6 memory region
+ - description: Combined firmware data memory region
+ - description: Multi Link Operation (MLO) Global memory region
+
+ memory-region-names:
+ items:
+ - const: q6-region
+ - const: data-region
+ - const: mlo-global-mem
+
+ msi-parent:
+ description: Phandle to the MSI controller.
+ maxItems: 1
+
+ qcom,calibration-variant:
+ $ref: /schemas/types.yaml#/definitions/string
+ description:
+ String to uniquely identify variant of the calibration data for designs
+ with colliding bus and device ids
+
+ qcom,rproc:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ Phandle to the Qualcomm Hexagon DSP (Q6 remote processor), which is
+ utilized for offloading Wi-Fi processing tasks. This Q6 remote processor
+ operates in conjunction with Wi-Fi.
+
+ qcom,smem-states:
+ $ref: /schemas/types.yaml#/definitions/phandle-array
+ description: States used by the AP to signal the remote processor
+ items:
+ - description: Shutdown WCSS PD
+ items:
+ - description: Phandle to the Shared Memory Point 2 Point device
+ handling the communication with a remote processor
+ - description: Single bit index to toggle in the value sent to
+ the remote processor
+ maximum: 31
+ - description: Stop WCSS PD
+ items:
+ - description: Phandle to the Shared Memory Point 2 Point device
+ handling the communication with a remote processor
+ - description: Single bit index to toggle in the value sent to
+ the remote processor
+ maximum: 31
+ - description: Spawn WCSS PD
+ items:
+ - description: Phandle to the Shared Memory Point 2 Point device
+ handling the communication with a remote processor
+ - description: Single bit index to toggle in the value sent to
+ the remote processor
+ maximum: 31
+
+ qcom,smem-state-names:
+ description:
+ Names of the states used by the AP to signal the remote processor
+ items:
+ - const: shutdown
+ - const: stop
+ - const: spawn
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-names
+ - memory-region
+ - memory-region-names
+ - msi-parent
+ - qcom,rproc
+ - qcom,smem-states
+ - qcom,smem-state-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ wifi@21e00000 {
+ compatible = "qcom,qcn6432-wifi";
+ reg = <0x21e00000 0x200000>;
+ interrupts-extended = <&smp2p_wcss_in 16 IRQ_TYPE_NONE>,
+ <&smp2p_wcss_in 17 IRQ_TYPE_NONE>,
+ <&smp2p_wcss_in 20 IRQ_TYPE_NONE>,
+ <&smp2p_wcss_in 19 IRQ_TYPE_NONE>,
+ <&intc GIC_SPI 33 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "fatal",
+ "ready",
+ "spawn",
+ "stop-ack",
+ "umac-reset";
+ memory-region = <&q6_region>, <&data_region>, <&mlo_mem>;
+ memory-region-names = "q6-region", "data-region", "mlo-global-mem";
+ msi-parent = <&v2m0>;
+ qcom,calibration-variant = "RDP442_1";
+ qcom,rproc = <&q6v5_wcss>;
+ qcom,smem-states = <&smp2p_wcss_out 16>,
+ <&smp2p_wcss_out 17>,
+ <&smp2p_wcss_out 18>;
+ qcom,smem-state-names = "shutdown",
+ "stop",
+ "spawn";
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation
2026-10-08 10:23 ` [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation Aaradhana Sahu
@ 2026-10-09 10:30 ` Krzysztof Kozlowski
2026-10-12 5:29 ` Aaradhana Sahu
0 siblings, 1 reply; 30+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-09 10:30 UTC (permalink / raw)
To: Aaradhana Sahu
Cc: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson, linux-wireless, devicetree, linux-kernel, ath12k
On Thu, Oct 08, 2026 at 03:53:57PM +0530, Aaradhana Sahu wrote:
> Add Devicetree binding documentation for the Qualcomm QCN6432 IEEE 802.11be
> wireless device.
>
> QCN6432 is attached to the WCSS Q6 subsystem and is represented as an AHB
> platform device, even though the Wi-Fi hardware interfaces over PCIe.
> Document the compatible string and the resources, including the Q6 remote
> processor phandle, MSI interrupts, SMEM states and memory regions.
>
> Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
> ---
> .../bindings/net/wireless/qcom,qcn6432-wifi.yaml | 149 +++++++++++++++++++++
> 1 file changed, 149 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml
> new file mode 100644
> index 000000000000..97d8885333fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml
> @@ -0,0 +1,149 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/qcom,qcn6432-wifi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies QCN6432 wireless device
> +
> +maintainers:
> + - Jeff Johnson <jjohnson@kernel.org>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Qualcomm Technologies QCN6432 is an IEEE 802.11be Wi-Fi device
> + associated with the WCSS Q6 subsystem. The device is represented
> + as a platform device and uses MSI interrupts for its Copy Engine
> + (CE) and Data Path (DP) rings.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,qcn6432-wifi
Is there qcn6432-something-else as well? Neither commit msg nor
description explain that.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation
2026-10-09 10:30 ` Krzysztof Kozlowski
@ 2026-10-12 5:29 ` Aaradhana Sahu
2026-10-12 5:56 ` Krzysztof Kozlowski
0 siblings, 1 reply; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-12 5:29 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson, linux-wireless, devicetree, linux-kernel, ath12k
On 10/9/2026 4:00 PM, Krzysztof Kozlowski wrote:
> On Thu, Oct 08, 2026 at 03:53:57PM +0530, Aaradhana Sahu wrote:
>> Add Devicetree binding documentation for the Qualcomm QCN6432 IEEE 802.11be
>> wireless device.
>>
>> QCN6432 is attached to the WCSS Q6 subsystem and is represented as an AHB
>> platform device, even though the Wi-Fi hardware interfaces over PCIe.
>> Document the compatible string and the resources, including the Q6 remote
>> processor phandle, MSI interrupts, SMEM states and memory regions.
>>
>> Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
>> ---
>> .../bindings/net/wireless/qcom,qcn6432-wifi.yaml | 149 +++++++++++++++++++++
>> 1 file changed, 149 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml
>> new file mode 100644
>> index 000000000000..97d8885333fa
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,qcn6432-wifi.yaml
>> @@ -0,0 +1,149 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/wireless/qcom,qcn6432-wifi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies QCN6432 wireless device
>> +
>> +maintainers:
>> + - Jeff Johnson <jjohnson@kernel.org>
>> +
>> +description: |
>
> Do not need '|' unless you need to preserve formatting.
>
Thanks for the review. I'll remove the unnecessary | from the description.
>> + Qualcomm Technologies QCN6432 is an IEEE 802.11be Wi-Fi device
>> + associated with the WCSS Q6 subsystem. The device is represented
>> + as a platform device and uses MSI interrupts for its Copy Engine
>> + (CE) and Data Path (DP) rings.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,qcn6432-wifi
>
> Is there qcn6432-something-else as well? Neither commit msg nor
> description explain that.
>
> Best regards,
> Krzysztof
>
QCN6432 is a Wi-Fi device supported by the ath12k driver, and there are no
other variants requiring a separate compatible string.
Hence, qcom,qcn6432-wifi is used to identify this device.
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation
2026-10-12 5:29 ` Aaradhana Sahu
@ 2026-10-12 5:56 ` Krzysztof Kozlowski
2026-10-12 6:43 ` Aaradhana Sahu
0 siblings, 1 reply; 30+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-12 5:56 UTC (permalink / raw)
To: Aaradhana Sahu
Cc: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson, linux-wireless, devicetree, linux-kernel, ath12k
On 12/10/2026 07:29, Aaradhana Sahu wrote:
>>> + Qualcomm Technologies QCN6432 is an IEEE 802.11be Wi-Fi device
>>> + associated with the WCSS Q6 subsystem. The device is represented
>>> + as a platform device and uses MSI interrupts for its Copy Engine
>>> + (CE) and Data Path (DP) rings.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,qcn6432-wifi
>>
>> Is there qcn6432-something-else as well? Neither commit msg nor
>> description explain that.
>>
>> Best regards,
>> Krzysztof
>>
>
> QCN6432 is a Wi-Fi device supported by the ath12k driver, and there are no
> other variants requiring a separate compatible string.
> Hence, qcom,qcn6432-wifi is used to identify this device.
Then it is qcom,qcn6432.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation
2026-10-12 5:56 ` Krzysztof Kozlowski
@ 2026-10-12 6:43 ` Aaradhana Sahu
0 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-12 6:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson, linux-wireless, devicetree, linux-kernel, ath12k
On 10/12/2026 11:26 AM, Krzysztof Kozlowski wrote:
> On 12/10/2026 07:29, Aaradhana Sahu wrote:
>>>> + Qualcomm Technologies QCN6432 is an IEEE 802.11be Wi-Fi device
>>>> + associated with the WCSS Q6 subsystem. The device is represented
>>>> + as a platform device and uses MSI interrupts for its Copy Engine
>>>> + (CE) and Data Path (DP) rings.
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + enum:
>>>> + - qcom,qcn6432-wifi
>>>
>>> Is there qcn6432-something-else as well? Neither commit msg nor
>>> description explain that.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> QCN6432 is a Wi-Fi device supported by the ath12k driver, and there are no
>> other variants requiring a separate compatible string.
>> Hence, qcom,qcn6432-wifi is used to identify this device.
>
> Then it is qcom,qcn6432.
>
>
> Best regards,
> Krzysztof
Thanks for the clarification. I'll update it to qcom,qcn6432 in the next version.
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH ath-next 02/17] wifi: ath12k: Refactor PCI operations and MSI config structure
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
2026-10-08 10:23 ` [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation Aaradhana Sahu
@ 2026-10-08 10:23 ` Aaradhana Sahu
2026-10-08 10:23 ` [PATCH ath-next 03/17] wifi: ath12k: Add hardware parameter for QCN6432 Aaradhana Sahu
` (14 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:23 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
QCN6432 is a PCIe-based device attached to the WCSS Q6 processor,
but it is registered as a platform (AHB) device. It uses AHB APIs
for probe and boot, while relying on PCI APIs for device setup and
register access.
To leverage the PCI API usage in QCN6432, refactor the existing PCI
operations and MSI configuration structures.
Move ATH12K_PCI_IRQ_CE0_OFFSET to ce.h from pci.c and ahb.h and rename
it to ATH12K_MSI_IRQ_CE0_OFFSET.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/ahb.h | 1 -
drivers/net/wireless/ath/ath12k/ce.h | 2 +
drivers/net/wireless/ath/ath12k/core.h | 9 +++++
drivers/net/wireless/ath/ath12k/pci.c | 60 +++++++++++++----------------
drivers/net/wireless/ath/ath12k/pci.h | 18 ++++++++-
drivers/net/wireless/ath/ath12k/wifi7/pci.c | 9 ++---
6 files changed, 56 insertions(+), 43 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/ahb.h b/drivers/net/wireless/ath/ath12k/ahb.h
index 46a4420d41bd..ecc4054f8742 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.h
+++ b/drivers/net/wireless/ath/ath12k/ahb.h
@@ -17,7 +17,6 @@
#define ATH12K_AHB_SMP2P_SMEM_SEQ_NO GENMASK(31, 16)
#define ATH12K_AHB_SMP2P_SMEM_VALUE_MASK 0xFFFFFFFF
#define ATH12K_PCI_CE_WAKE_IRQ 2
-#define ATH12K_PCI_IRQ_CE0_OFFSET 3
#define ATH12K_ROOTPD_READY_TIMEOUT (5 * HZ)
#define ATH12K_RPROC_AFTER_POWERUP QCOM_SSR_AFTER_POWERUP
#define ATH12K_AHB_FW_PREFIX "q6_fw"
diff --git a/drivers/net/wireless/ath/ath12k/ce.h b/drivers/net/wireless/ath/ath12k/ce.h
index 009cddf2d68d..cd913a885470 100644
--- a/drivers/net/wireless/ath/ath12k/ce.h
+++ b/drivers/net/wireless/ath/ath12k/ce.h
@@ -9,6 +9,8 @@
#define CE_COUNT_MAX 16
+#define ATH12K_MSI_IRQ_CE0_OFFSET 3
+
/* Byte swap data words */
#define CE_ATTR_BYTE_SWAP_DATA 2
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index 99d71dab7c04..993aa3f350aa 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -186,6 +186,10 @@ enum ath12k_smbios_cc_type {
ATH12K_SMBIOS_CC_WW = 2,
};
+enum ath12k_msi_supported_hw {
+ ATH12K_MSI_CONFIG_PCI,
+};
+
struct ath12k_smbios_bdf {
struct dmi_header hdr;
u8 features_disabled;
@@ -1152,6 +1156,11 @@ struct ath12k_base {
struct rhashtable *rhead_sta_addr;
struct rhashtable_params rhash_sta_addr_param;
+ struct {
+ const struct ath12k_msi_config *config;
+ u32 ep_base_data;
+ } msi;
+
/* must be last */
u8 drv_priv[] __aligned(sizeof(void *));
};
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index 12bbb75570f1..736e40492b41 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -22,14 +22,6 @@
#define ATH12K_PCI_BAR_NUM 0
#define ATH12K_PCI_DMA_MASK 36
-#define ATH12K_PCI_IRQ_CE0_OFFSET 3
-
-#define WINDOW_ENABLE_BIT 0x40000000
-#define WINDOW_VALUE_MASK GENMASK(24, 19)
-#define WINDOW_START 0x80000
-#define WINDOW_RANGE_MASK GENMASK(18, 0)
-#define WINDOW_STATIC_MASK GENMASK(31, 6)
-
/* BAR0 + 4k is always accessible, and no
* need to force wakeup.
* 4K - 32 = 0xFE0
@@ -313,7 +305,7 @@ static void ath12k_pci_sw_reset(struct ath12k_base *ab, bool power_on)
ath12k_mhi_set_mhictrl_reset(ab);
}
-static void ath12k_pci_free_ce_irq(struct ath12k_base *ab, int num_ce)
+void ath12k_pci_free_ce_irq(struct ath12k_base *ab, int num_ce)
{
int i, irq_idx;
@@ -321,12 +313,12 @@ static void ath12k_pci_free_ce_irq(struct ath12k_base *ab, int num_ce)
if (ath12k_ce_get_attr_flags(ab, i) & CE_ATTR_DIS_INTR)
continue;
- irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + i;
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + i;
free_irq(ab->irq_num[irq_idx], &ab->ce.ce_pipe[i]);
}
}
-static void ath12k_pci_free_ext_irq(struct ath12k_base *ab, int num_ext_irq_grp)
+void ath12k_pci_free_ext_irq(struct ath12k_base *ab, int num_ext_irq_grp)
{
int i, j;
@@ -358,7 +350,7 @@ static void ath12k_pci_ce_irq_enable(struct ath12k_base *ab, u16 ce_id)
if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
return;
- irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + ce_id;
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_id;
enable_irq(ab->irq_num[irq_idx]);
}
@@ -373,7 +365,7 @@ static void ath12k_pci_ce_irq_disable(struct ath12k_base *ab, u16 ce_id)
if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
return;
- irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + ce_id;
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_id;
disable_irq_nosync(ab->irq_num[irq_idx]);
}
@@ -390,7 +382,7 @@ static void ath12k_pci_ce_irqs_disable(struct ath12k_base *ab)
}
}
-static void ath12k_pci_sync_ce_irqs(struct ath12k_base *ab)
+void ath12k_pci_sync_ce_irqs(struct ath12k_base *ab)
{
int i;
int irq_idx;
@@ -399,15 +391,15 @@ static void ath12k_pci_sync_ce_irqs(struct ath12k_base *ab)
if (ath12k_ce_get_attr_flags(ab, i) & CE_ATTR_DIS_INTR)
continue;
- irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + i;
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + i;
synchronize_irq(ab->irq_num[irq_idx]);
}
}
-static void ath12k_pci_ce_workqueue(struct work_struct *work)
+void ath12k_pci_ce_workqueue(struct work_struct *work)
{
struct ath12k_ce_pipe *ce_pipe = from_work(ce_pipe, work, intr_wq);
- int irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + ce_pipe->pipe_num;
+ int irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_pipe->pipe_num;
ath12k_ce_per_engine_service(ce_pipe->ab, ce_pipe->pipe_num);
@@ -418,7 +410,7 @@ static irqreturn_t ath12k_pci_ce_interrupt_handler(int irq, void *arg)
{
struct ath12k_ce_pipe *ce_pipe = arg;
struct ath12k_base *ab = ce_pipe->ab;
- int irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + ce_pipe->pipe_num;
+ int irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_pipe->pipe_num;
if (!test_bit(ATH12K_FLAG_CE_IRQ_ENABLED, &ab->dev_flags))
return IRQ_HANDLED;
@@ -520,7 +512,7 @@ static int ath12k_pci_ext_grp_napi_poll(struct napi_struct *napi, int budget)
return work_done;
}
-static irqreturn_t ath12k_pci_ext_interrupt_handler(int irq, void *arg)
+irqreturn_t ath12k_pci_ext_interrupt_handler(int irq, void *arg)
{
struct ath12k_ext_irq_grp *irq_grp = arg;
struct ath12k_base *ab = irq_grp->ab;
@@ -551,7 +543,7 @@ static int ath12k_pci_ext_irq_config(struct ath12k_base *ab)
bool threaded_napi = false;
int irq;
- base_idx = ATH12K_PCI_IRQ_CE0_OFFSET + CE_COUNT_MAX;
+ base_idx = ATH12K_MSI_IRQ_CE0_OFFSET + CE_COUNT_MAX;
ret = ath12k_pci_get_user_msi_assignment(ab, "DP",
&num_vectors,
&user_base_data,
@@ -666,7 +658,7 @@ static int ath12k_pci_config_irq(struct ath12k_base *ab)
irq = ath12k_pci_get_msi_irq(ab->dev, msi_data);
ce_pipe = &ab->ce.ce_pipe[i];
- irq_idx = ATH12K_PCI_IRQ_CE0_OFFSET + i;
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + i;
INIT_WORK(&ce_pipe->intr_wq, ath12k_pci_ce_workqueue);
@@ -718,7 +710,7 @@ static void ath12k_pci_init_qmi_ce_config(struct ath12k_base *ab)
}
}
-static void ath12k_pci_ce_irqs_enable(struct ath12k_base *ab)
+void ath12k_pci_ce_irqs_enable(struct ath12k_base *ab)
{
int i;
@@ -759,7 +751,7 @@ static void ath12k_pci_msi_disable(struct ath12k_pci *ab_pci)
static int ath12k_pci_msi_alloc(struct ath12k_pci *ab_pci)
{
struct ath12k_base *ab = ab_pci->ab;
- const struct ath12k_msi_config *msi_config = ab_pci->msi_config;
+ const struct ath12k_msi_config *msi_config = ab->msi.config;
struct msi_desc *msi_desc;
int num_vectors;
int ret;
@@ -782,7 +774,7 @@ static int ath12k_pci_msi_alloc(struct ath12k_pci *ab_pci)
goto reset_msi_config;
}
clear_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags);
- ab_pci->msi_config = &msi_config_one_msi;
+ ab->msi.config = &msi_config_one_msi;
ab_pci->irq_flags = IRQF_SHARED | IRQF_NOBALANCING;
ath12k_dbg(ab, ATH12K_DBG_PCI, "request MSI one vector\n");
}
@@ -798,11 +790,11 @@ static int ath12k_pci_msi_alloc(struct ath12k_pci *ab_pci)
goto free_msi_vector;
}
- ab_pci->msi_ep_base_data = msi_desc->msg.data;
+ ab->msi.ep_base_data = msi_desc->msg.data;
if (msi_desc->pci.msi_attrib.is_64)
set_bit(ATH12K_PCI_FLAG_IS_MSI_64, &ab_pci->flags);
- ath12k_dbg(ab, ATH12K_DBG_PCI, "msi base data is %d\n", ab_pci->msi_ep_base_data);
+ ath12k_dbg(ab, ATH12K_DBG_PCI, "msi base data is %u\n", ab->msi.ep_base_data);
return 0;
@@ -820,6 +812,7 @@ static void ath12k_pci_msi_free(struct ath12k_pci *ab_pci)
static int ath12k_pci_config_msi_data(struct ath12k_pci *ab_pci)
{
+ struct ath12k_base *ab = ab_pci->ab;
struct msi_desc *msi_desc;
msi_desc = irq_get_msi_desc(ab_pci->pdev->irq);
@@ -829,10 +822,10 @@ static int ath12k_pci_config_msi_data(struct ath12k_pci *ab_pci)
return -EINVAL;
}
- ab_pci->msi_ep_base_data = msi_desc->msg.data;
+ ab->msi.ep_base_data = msi_desc->msg.data;
- ath12k_dbg(ab_pci->ab, ATH12K_DBG_PCI, "pci after request_irq msi_ep_base_data %d\n",
- ab_pci->msi_ep_base_data);
+ ath12k_dbg(ab, ATH12K_DBG_PCI, "pci after request_irq msi_ep_base_data %u\n",
+ ab->msi.ep_base_data);
return 0;
}
@@ -955,7 +948,7 @@ static void ath12k_pci_aspm_restore(struct ath12k_pci *ab_pci)
PCI_EXP_LNKCTL_ASPMC);
}
-static void ath12k_pci_cancel_workqueue(struct ath12k_base *ab)
+void ath12k_pci_cancel_workqueue(struct ath12k_base *ab)
{
int i;
@@ -969,7 +962,7 @@ static void ath12k_pci_cancel_workqueue(struct ath12k_base *ab)
}
}
-static void ath12k_pci_ce_irq_disable_sync(struct ath12k_base *ab)
+void ath12k_pci_ce_irq_disable_sync(struct ath12k_base *ab)
{
ath12k_pci_ce_irqs_disable(ab);
ath12k_pci_sync_ce_irqs(ab);
@@ -1030,15 +1023,14 @@ int ath12k_pci_get_user_msi_assignment(struct ath12k_base *ab, char *user_name,
int *num_vectors, u32 *user_base_data,
u32 *base_vector)
{
- struct ath12k_pci *ab_pci = ath12k_pci_priv(ab);
- const struct ath12k_msi_config *msi_config = ab_pci->msi_config;
+ const struct ath12k_msi_config *msi_config = ab->msi.config;
int idx;
for (idx = 0; idx < msi_config->total_users; idx++) {
if (strcmp(user_name, msi_config->users[idx].name) == 0) {
*num_vectors = msi_config->users[idx].num_vectors;
*base_vector = msi_config->users[idx].base_vector;
- *user_base_data = *base_vector + ab_pci->msi_ep_base_data;
+ *user_base_data = *base_vector + ab->msi.ep_base_data;
ath12k_dbg(ab, ATH12K_DBG_PCI,
"Assign MSI to user: %s, num_vectors: %d, user_base_data: %u, base_vector: %u\n",
diff --git a/drivers/net/wireless/ath/ath12k/pci.h b/drivers/net/wireless/ath/ath12k/pci.h
index 0e0e2020c6ae..47c8760536e4 100644
--- a/drivers/net/wireless/ath/ath12k/pci.h
+++ b/drivers/net/wireless/ath/ath12k/pci.h
@@ -76,6 +76,14 @@
#define QRTR_PCI_DOMAIN_NR_MASK GENMASK(7, 4)
#define QRTR_PCI_BUS_NUMBER_MASK GENMASK(3, 0)
+#define WINDOW_ENABLE_BIT 0x40000000
+#define WINDOW_REG_ADDRESS 0x310c
+#define WINDOW_REG_ADDRESS_QCC2072 0x3278
+#define WINDOW_VALUE_MASK GENMASK(24, 19)
+#define WINDOW_START 0x80000
+#define WINDOW_RANGE_MASK GENMASK(18, 0)
+#define WINDOW_STATIC_MASK GENMASK(31, 6)
+
struct ath12k_msi_user {
const char *name;
int num_vectors;
@@ -116,9 +124,7 @@ struct ath12k_pci {
struct ath12k_base *ab;
u16 dev_id;
char amss_path[100];
- u32 msi_ep_base_data;
struct mhi_controller *mhi_ctrl;
- const struct ath12k_msi_config *msi_config;
unsigned long mhi_state;
enum mhi_callback mhi_pre_cb;
u32 register_window;
@@ -177,4 +183,12 @@ void ath12k_pci_power_down(struct ath12k_base *ab, bool is_suspend);
int ath12k_pci_register_driver(const enum ath12k_device_family device_id,
struct ath12k_pci_driver *driver);
void ath12k_pci_unregister_driver(const enum ath12k_device_family device_id);
+irqreturn_t ath12k_pci_ext_interrupt_handler(int irq, void *arg);
+void ath12k_pci_ce_irq_disable_sync(struct ath12k_base *ab);
+void ath12k_pci_ce_irqs_enable(struct ath12k_base *ab);
+void ath12k_pci_sync_ce_irqs(struct ath12k_base *ab);
+void ath12k_pci_cancel_workqueue(struct ath12k_base *ab);
+void ath12k_pci_ce_workqueue(struct work_struct *work);
+void ath12k_pci_free_ce_irq(struct ath12k_base *ab, int num_ce);
+void ath12k_pci_free_ext_irq(struct ath12k_base *ab, int num_ext_irq_grp);
#endif /* ATH12K_PCI_H */
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/pci.c b/drivers/net/wireless/ath/ath12k/wifi7/pci.c
index 6c96b52dec13..bb617bb6b71a 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/pci.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/pci.c
@@ -28,9 +28,6 @@
#define TCSR_SOC_HW_VERSION_MAJOR_MASK GENMASK(11, 8)
#define TCSR_SOC_HW_VERSION_MINOR_MASK GENMASK(7, 4)
-#define WINDOW_REG_ADDRESS 0x310c
-#define WINDOW_REG_ADDRESS_QCC2072 0x3278
-
static const struct pci_device_id ath12k_wifi7_pci_id_table[] = {
{ PCI_VDEVICE(QCOM, QCN9274_DEVICE_ID) },
{ PCI_VDEVICE(QCOM, WCN7850_DEVICE_ID) },
@@ -106,7 +103,7 @@ static int ath12k_wifi7_pci_probe(struct pci_dev *pdev,
switch (pci_dev->device) {
case QCN9274_DEVICE_ID:
- ab_pci->msi_config = &ath12k_wifi7_msi_config[0];
+ ab->msi.config = &ath12k_wifi7_msi_config[ATH12K_MSI_CONFIG_PCI];
ab->static_window_map = true;
ab_pci->pci_ops = &ath12k_wifi7_pci_ops_qcn9274;
/*
@@ -133,7 +130,7 @@ static int ath12k_wifi7_pci_probe(struct pci_dev *pdev,
break;
case WCN7850_DEVICE_ID:
ab->id.bdf_search = ATH12K_BDF_SEARCH_BUS_AND_BOARD;
- ab_pci->msi_config = &ath12k_wifi7_msi_config[0];
+ ab->msi.config = &ath12k_wifi7_msi_config[ATH12K_MSI_CONFIG_PCI];
ab->static_window_map = false;
ab_pci->pci_ops = &ath12k_wifi7_pci_ops_wcn7850;
/*
@@ -157,7 +154,7 @@ static int ath12k_wifi7_pci_probe(struct pci_dev *pdev,
break;
case QCC2072_DEVICE_ID:
ab->id.bdf_search = ATH12K_BDF_SEARCH_BUS_AND_BOARD;
- ab_pci->msi_config = &ath12k_wifi7_msi_config[0];
+ ab->msi.config = &ath12k_wifi7_msi_config[ATH12K_MSI_CONFIG_PCI];
ab->static_window_map = false;
ab_pci->pci_ops = &ath12k_wifi7_pci_ops_wcn7850;
ab_pci->window_reg_addr = WINDOW_REG_ADDRESS_QCC2072;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 03/17] wifi: ath12k: Add hardware parameter for QCN6432
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
2026-10-08 10:23 ` [PATCH ath-next 01/17] dt-bindings: net: wireless: Add QCN6432 device tree binding documentation Aaradhana Sahu
2026-10-08 10:23 ` [PATCH ath-next 02/17] wifi: ath12k: Refactor PCI operations and MSI config structure Aaradhana Sahu
@ 2026-10-08 10:23 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 04/17] wifi: ath12k: Add hardware ring mask " Aaradhana Sahu
` (13 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:23 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Add hardware parameter (ath12k_hw_params) for WiFi device QCN6432.
Some hardware parameters, such as host_ce_config, target_ce_config,
and svc_to_ce_map, are identical between the QCN6432 and IPQ5332
devices. Therefore, use the same parameters for the QCN6432.
Additionally, certain hardware parameters like wmi_init and hw_ops
are the same between the QCN6432 and QCN9274 devices. So, use the
same parameters for the QCN6432.
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01275-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/core.h | 1 +
drivers/net/wireless/ath/ath12k/qmi.h | 1 +
drivers/net/wireless/ath/ath12k/wifi7/hw.c | 84 ++++++++++++++++++++++++++++++
3 files changed, 86 insertions(+)
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index 993aa3f350aa..d87c59f68c12 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -158,6 +158,7 @@ enum ath12k_hw_rev {
ATH12K_HW_IPQ5332_HW10,
ATH12K_HW_QCC2072_HW10,
ATH12K_HW_IPQ5424_HW10,
+ ATH12K_HW_QCN6432_HW10,
};
#define ATH12K_IRQ_NUM_MAX 57
diff --git a/drivers/net/wireless/ath/ath12k/qmi.h b/drivers/net/wireless/ath/ath12k/qmi.h
index 1b1c88906f1e..60d5811b1c87 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.h
+++ b/drivers/net/wireless/ath/ath12k/qmi.h
@@ -20,6 +20,7 @@
#define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_QCN9274 0x07
#define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_IPQ5332 0x2
+#define ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_QCN6432 0x60
#define ATH12K_QMI_WLANFW_MAX_TIMESTAMP_LEN_V01 32
#define ATH12K_QMI_RESP_LEN_MAX 8192
#define ATH12K_QMI_WLANFW_MAX_NUM_MEM_SEG_V01 52
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hw.c b/drivers/net/wireless/ath/ath12k/wifi7/hw.c
index aec7c652808c..f57adb2107df 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hw.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hw.c
@@ -901,6 +901,90 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
.max_client_dbs_sbs = 128,
},
+ .host_alloc_ml_id = true,
+ },
+ {
+ .name = "qcn6432 hw1.0",
+ .hw_rev = ATH12K_HW_QCN6432_HW10,
+ .fw = {
+ .dir = "QCN6432/hw1.0",
+ .board_size = 256 * 1024,
+ .cal_offset = 128 * 1024,
+ .m3_loader = ath12k_m3_fw_loader_remoteproc,
+ .download_aux_ucode = false,
+ },
+ .max_radios = 1,
+ .single_pdev_only = false,
+ .qmi_service_ins_id = ATH12K_QMI_WLFW_SERVICE_INS_ID_V01_QCN6432,
+ .internal_sleep_clock = false,
+
+ .hw_ops = &qcn9274_ops,
+ .ring_mask = &ath12k_wifi7_hw_ring_mask_ipq5332,
+
+ .host_ce_config = ath12k_wifi7_host_ce_config_ipq5332,
+ .ce_count = 12,
+ .target_ce_config = ath12k_wifi7_target_ce_config_wlan_ipq5332,
+ .target_ce_count = 12,
+ .svc_to_ce_map = ath12k_wifi7_target_service_to_ce_map_wlan_ipq5332,
+ .svc_to_ce_map_len = 18,
+
+ .rxdma1_enable = true,
+ .num_rxdma_per_pdev = 1,
+ .num_rxdma_dst_ring = 0,
+ .rx_mac_buf_ring = false,
+ .vdev_start_delay = false,
+
+ .interface_modes = BIT(NL80211_IFTYPE_STATION) |
+ BIT(NL80211_IFTYPE_AP) |
+ BIT(NL80211_IFTYPE_MESH_POINT) |
+ BIT(NL80211_IFTYPE_AP_VLAN),
+ .supports_monitor = true,
+ .supports_cong_ctrl_max_msdus = true,
+
+ .idle_ps = false,
+ .download_calib = true,
+ .supports_suspend = false,
+ .tcl_ring_retry = true,
+ .reoq_lut_support = false,
+ .supports_shadow_regs = false,
+
+ .num_tcl_banks = 48,
+ .max_tx_ring = 4,
+ .mhi_config = NULL,
+ .wmi_init = &ath12k_wifi7_wmi_init_qcn9274,
+
+ .qmi_cnss_feature_bitmap = BIT(CNSS_QDSS_CFG_MISS_V01),
+
+ .rfkill_pin = 0,
+ .rfkill_cfg = 0,
+ .rfkill_on_level = 0,
+
+ .rddm_size = 0,
+
+ .def_num_link = 0,
+ .max_mlo_peer = 256,
+
+ .otp_board_id_register = 0,
+
+ .supports_sta_ps = false,
+
+ .acpi_guid = NULL,
+ .supports_dynamic_smps_6ghz = false,
+ .iova_mask = 0,
+ .supports_aspm = false,
+
+ .ce_ie_addr = NULL,
+ .ce_remap = NULL,
+ .bdf_addr_offset = 0,
+
+ .current_cc_support = false,
+ .dp_primary_link_only = true,
+ .client = {
+ .max_client_single = 256,
+ .max_client_dbs = 128,
+ .max_client_dbs_sbs = 128,
+ },
+
.host_alloc_ml_id = true,
},
};
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 04/17] wifi: ath12k: Add hardware ring mask for QCN6432
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (2 preceding siblings ...)
2026-10-08 10:23 ` [PATCH ath-next 03/17] wifi: ath12k: Add hardware parameter for QCN6432 Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 05/17] wifi: ath12k: add hardware registers " Aaradhana Sahu
` (12 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Add hardware ring mask configuration for QCN6432 to support interrupt group
mappings for various hardware rings.
The QCN6432 requires a different ring mask configuration compared to
IPQ5332 and QCN9274, with support for up to 12 external IRQ groups
instead of the previous maximum of 11. Hence add a dedicated ring mask
structure that defines the interrupt group assignments for TX rings,
RX rings, RX monitor destination, RX error handling, RX WBM release,
REO status, Host2RXDMA communication, and TX monitor destination.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/hw.h | 2 +-
drivers/net/wireless/ath/ath12k/wifi7/hw.c | 52 +++++++++++++++++++++++++++++-
2 files changed, 52 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/hw.h b/drivers/net/wireless/ath/ath12k/hw.h
index 1e652dc0d247..2e585a42dd9b 100644
--- a/drivers/net/wireless/ath/ath12k/hw.h
+++ b/drivers/net/wireless/ath/ath12k/hw.h
@@ -127,7 +127,7 @@ enum ath12k_bus {
ATH12K_BUS_AHB,
};
-#define ATH12K_EXT_IRQ_GRP_NUM_MAX 11
+#define ATH12K_EXT_IRQ_GRP_NUM_MAX 12
struct hal_rx_desc;
struct hal_tcl_data_cmd;
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hw.c b/drivers/net/wireless/ath/ath12k/wifi7/hw.c
index f57adb2107df..408844024dd6 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hw.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hw.c
@@ -332,6 +332,56 @@ static const struct ath12k_hw_ring_mask ath12k_wifi7_hw_ring_mask_wcn7850 = {
},
};
+static const struct ath12k_hw_ring_mask ath12k_wifi7_hw_ring_mask_qcn6432 = {
+ .tx = {
+ ATH12K_TX_RING_MASK_0,
+ ATH12K_TX_RING_MASK_1,
+ ATH12K_TX_RING_MASK_2,
+ 0, 0, 0, 0, 0, 0, 0, 0,
+ ATH12K_TX_RING_MASK_3
+ },
+ .rx_mon_dest = {
+ 0, 0, 0, 0, 0, 0, 0, 0,
+ ATH12K_RX_MON_RING_MASK_0,
+ ATH12K_RX_MON_RING_MASK_1,
+ ATH12K_RX_MON_RING_MASK_2,
+ 0
+ },
+ .rx = {
+ 0, 0, 0, 0,
+ ATH12K_RX_RING_MASK_0,
+ ATH12K_RX_RING_MASK_1,
+ ATH12K_RX_RING_MASK_2,
+ ATH12K_RX_RING_MASK_3,
+ 0, 0, 0, 0
+ },
+ .rx_err = {
+ 0, 0, 0,
+ ATH12K_RX_ERR_RING_MASK_0,
+ 0, 0, 0, 0, 0, 0, 0, 0
+ },
+ .rx_wbm_rel = {
+ 0, 0, 0,
+ ATH12K_RX_WBM_REL_RING_MASK_0,
+ 0, 0, 0, 0, 0, 0, 0, 0
+ },
+ .reo_status = {
+ 0, 0, 0,
+ ATH12K_REO_STATUS_RING_MASK_0,
+ 0, 0, 0, 0, 0, 0, 0, 0
+ },
+ .host2rxdma = {
+ 0, 0,
+ ATH12K_HOST2RXDMA_RING_MASK_0,
+ 0, 0, 0, 0, 0, 0, 0, 0, 0
+ },
+ .tx_mon_dest = {
+ ATH12K_TX_MON_RING_MASK_0,
+ 0, 0, 0, 0, 0, 0, 0, 0, 0,
+ 0, 0
+ },
+};
+
static const struct ce_ie_addr ath12k_wifi7_ce_ie_addr_ipq5332 = {
.ie1_reg_addr = CE_HOST_IPQ5332_IE_ADDRESS - HAL_IPQ5332_CE_WFSS_REG_BASE,
.ie2_reg_addr = CE_HOST_IPQ5332_IE_2_ADDRESS - HAL_IPQ5332_CE_WFSS_REG_BASE,
@@ -919,7 +969,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
.internal_sleep_clock = false,
.hw_ops = &qcn9274_ops,
- .ring_mask = &ath12k_wifi7_hw_ring_mask_ipq5332,
+ .ring_mask = &ath12k_wifi7_hw_ring_mask_qcn6432,
.host_ce_config = ath12k_wifi7_host_ce_config_ipq5332,
.ce_count = 12,
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 05/17] wifi: ath12k: add hardware registers for QCN6432
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (3 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 04/17] wifi: ath12k: Add hardware ring mask " Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 06/17] wifi: ath12k: move multi MSI vector flag to ath12k_dev_flags Aaradhana Sahu
` (11 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Add hardware registers and populate the hw_regs field in
ath12k_wifi7_hw_ver_map for QCN6432.
Also populate the HAL operations, HAL descriptor size, and HAL parameters
using the same values as QCN9274.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/wifi7/hal.c | 7 ++
.../net/wireless/ath/ath12k/wifi7/hal_qcn9274.c | 85 ++++++++++++++++++++++
.../net/wireless/ath/ath12k/wifi7/hal_qcn9274.h | 1 +
3 files changed, 93 insertions(+)
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal.c b/drivers/net/wireless/ath/ath12k/wifi7/hal.c
index a0a1902fb491..7c468159085f 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hal.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hal.c
@@ -57,6 +57,13 @@ static const struct ath12k_hw_version_map ath12k_wifi7_hw_ver_map[] = {
.hal_params = &ath12k_hw_hal_params_ipq5332,
.hw_regs = &ipq5424_regs,
},
+ [ATH12K_HW_QCN6432_HW10] = {
+ .hal_ops = &hal_qcn9274_ops,
+ .hal_desc_sz = sizeof(struct hal_rx_desc_qcn9274_compact),
+ .tcl_to_wbm_rbm_map = ath12k_hal_tcl_to_wbm_rbm_map_qcn9274,
+ .hal_params = &ath12k_hw_hal_params_ipq5332,
+ .hw_regs = &qcn6432_regs,
+ },
};
int ath12k_wifi7_hal_init(struct ath12k_base *ab)
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
index 052b59265af8..34f6be922479 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.c
@@ -572,6 +572,91 @@ const struct ath12k_hw_regs ipq5424_regs = {
HAL_IPQ5424_CE_WFSS_REG_BASE,
};
+const struct ath12k_hw_regs qcn6432_regs = {
+ /* SW2TCL(x) R0 ring configuration address */
+ .tcl1_ring_id = 0x00000918,
+ .tcl1_ring_misc = 0x00000920,
+ .tcl1_ring_tp_addr_lsb = 0x0000092c,
+ .tcl1_ring_tp_addr_msb = 0x00000930,
+ .tcl1_ring_consumer_int_setup_ix0 = 0x00000940,
+ .tcl1_ring_consumer_int_setup_ix1 = 0x00000944,
+ .tcl1_ring_msi1_base_lsb = 0x00000958,
+ .tcl1_ring_msi1_base_msb = 0x0000095c,
+ .tcl1_ring_base_lsb = 0x00000910,
+ .tcl1_ring_base_msb = 0x00000914,
+ .tcl1_ring_msi1_data = 0x00000960,
+ .tcl2_ring_base_lsb = 0x00000988,
+ .tcl_ring_base_lsb = 0x00000b68,
+
+ /* TCL STATUS ring address */
+ .tcl_status_ring_base_lsb = 0x00000d48,
+
+ /* REO DEST ring address */
+ .reo2_ring_base = 0x00000578,
+ .reo1_misc_ctrl_addr = 0x00000b9c,
+ .reo1_sw_cookie_cfg0 = 0x0000006c,
+ .reo1_sw_cookie_cfg1 = 0x00000070,
+ .reo1_qdesc_lut_base0 = 0x00000074,
+ .reo1_qdesc_lut_base1 = 0x00000078,
+ .reo1_ring_base_lsb = 0x00000500,
+ .reo1_ring_base_msb = 0x00000504,
+ .reo1_ring_id = 0x00000508,
+ .reo1_ring_misc = 0x00000510,
+ .reo1_ring_hp_addr_lsb = 0x00000514,
+ .reo1_ring_hp_addr_msb = 0x00000518,
+ .reo1_ring_producer_int_setup = 0x00000524,
+ .reo1_ring_msi1_base_lsb = 0x00000548,
+ .reo1_ring_msi1_base_msb = 0x0000054c,
+ .reo1_ring_msi1_data = 0x00000550,
+ .reo1_aging_thres_ix0 = 0x00000b28,
+ .reo1_aging_thres_ix1 = 0x00000b2c,
+ .reo1_aging_thres_ix2 = 0x00000b30,
+ .reo1_aging_thres_ix3 = 0x00000b34,
+
+ /* REO Exception ring address */
+ .reo2_sw0_ring_base = 0x000008c0,
+
+ /* REO Reinject ring address */
+ .sw2reo_ring_base = 0x00000320,
+ .sw2reo1_ring_base = 0x00000398,
+
+ /* REO cmd ring address */
+ .reo_cmd_ring_base = 0x000002a8,
+
+ /* REO status ring address */
+ .reo_status_ring_base = 0x00000aa0,
+
+ /* WBM idle link ring address */
+ .wbm_idle_ring_base_lsb = 0x00000d3c,
+ .wbm_idle_ring_misc_addr = 0x00000d4c,
+ .wbm_r0_idle_list_cntl_addr = 0x00000240,
+ .wbm_r0_idle_list_size_addr = 0x00000244,
+ .wbm_scattered_ring_base_lsb = 0x00000250,
+ .wbm_scattered_ring_base_msb = 0x00000254,
+ .wbm_scattered_desc_head_info_ix0 = 0x00000260,
+ .wbm_scattered_desc_head_info_ix1 = 0x00000264,
+ .wbm_scattered_desc_tail_info_ix0 = 0x00000270,
+ .wbm_scattered_desc_tail_info_ix1 = 0x00000274,
+ .wbm_scattered_desc_ptr_hp_addr = 0x0000027c,
+
+ /* SW2WBM release ring address */
+ .wbm_sw_release_ring_base_lsb = 0x0000037c,
+
+ /* WBM2SW release ring address */
+ .wbm0_release_ring_base_lsb = 0x00000e08,
+ .wbm1_release_ring_base_lsb = 0x00000e80,
+
+ /* PCIe base address */
+ .pcie_qserdes_sysclk_en_sel = 0x01e0c0a8,
+ .pcie_pcs_osc_dtct_config_base = 0x01e0d45c,
+
+ /* CE base address */
+ .umac_ce0_src_reg_base = 0x01b80000,
+ .umac_ce0_dest_reg_base = 0x01b81000,
+ .umac_ce1_src_reg_base = 0x01b82000,
+ .umac_ce1_dest_reg_base = 0x01b83000,
+};
+
static inline
bool ath12k_hal_rx_desc_get_first_msdu_qcn9274(struct hal_rx_desc *desc)
{
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
index 03cf3792d523..5c593773109d 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hal_qcn9274.h
@@ -18,6 +18,7 @@ extern const struct ath12k_hw_regs qcn9274_v1_regs;
extern const struct ath12k_hw_regs qcn9274_v2_regs;
extern const struct ath12k_hw_regs ipq5332_regs;
extern const struct ath12k_hw_regs ipq5424_regs;
+extern const struct ath12k_hw_regs qcn6432_regs;
extern const struct ath12k_hal_tcl_to_wbm_rbm_map
ath12k_hal_tcl_to_wbm_rbm_map_qcn9274[DP_TCL_NUM_RING_MAX];
extern const struct ath12k_hw_hal_params ath12k_hw_hal_params_qcn9274;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 06/17] wifi: ath12k: move multi MSI vector flag to ath12k_dev_flags
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (4 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 05/17] wifi: ath12k: add hardware registers " Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 07/17] wifi: ath12k: Add hybrid_bus_type in ath12k_hw_params Aaradhana Sahu
` (10 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
QCN6432 uses MSI vectors, but although it is a PCIe device, it is
attached to the WCSS Q6 processor and registered as an AHB platform
device. As a result, it does not have a valid ab_pci context while
still reusing PCI IRQ APIs.
Move ATH12K_PCI_FLAG_MULTI_MSI_VECTORS from ath12k_pci_flags to
ath12k_dev_flags so it can be used without relying on PCI-specific context.
Rename it to ATH12K_FLAG_MULTI_MSI_VECTORS accordingly.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/core.h | 1 +
drivers/net/wireless/ath/ath12k/mhi.c | 4 ++--
drivers/net/wireless/ath/ath12k/pci.c | 22 ++++++++++------------
drivers/net/wireless/ath/ath12k/pci.h | 1 -
4 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index d87c59f68c12..eaea601ab32d 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -278,6 +278,7 @@ enum ath12k_dev_flags {
ATH12K_FLAG_QMI_FW_READY_COMPLETE,
ATH12K_FLAG_FTM_SEGMENTED,
ATH12K_FLAG_FIXED_MEM_REGION,
+ ATH12K_FLAG_MULTI_MSI_VECTORS,
};
struct ath12k_tx_conf {
diff --git a/drivers/net/wireless/ath/ath12k/mhi.c b/drivers/net/wireless/ath/ath12k/mhi.c
index ee87f00bc5de..56e697fbdad5 100644
--- a/drivers/net/wireless/ath/ath12k/mhi.c
+++ b/drivers/net/wireless/ath/ath12k/mhi.c
@@ -86,7 +86,7 @@ static int ath12k_mhi_get_msi(struct ath12k_pci *ab_pci)
msi_data = base_vector;
for (i = 0; i < num_vectors; i++) {
- if (test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
irq[i] = ath12k_pci_get_msi_irq(ab->dev,
msi_data++);
else
@@ -248,7 +248,7 @@ int ath12k_mhi_register(struct ath12k_pci *ab_pci)
goto free_controller;
}
- if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (!test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
mhi_ctrl->irq_flags = IRQF_SHARED | IRQF_NOBALANCING;
mhi_ctrl->iova_start = 0;
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index 736e40492b41..e6fe891e58b1 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -341,13 +341,12 @@ static void ath12k_pci_free_irq(struct ath12k_base *ab)
static void ath12k_pci_ce_irq_enable(struct ath12k_base *ab, u16 ce_id)
{
- struct ath12k_pci *ab_pci = ath12k_pci_priv(ab);
u32 irq_idx;
/* In case of one MSI vector, we handle irq enable/disable in a
* uniform way since we only have one irq
*/
- if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (!test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
return;
irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_id;
@@ -356,13 +355,12 @@ static void ath12k_pci_ce_irq_enable(struct ath12k_base *ab, u16 ce_id)
static void ath12k_pci_ce_irq_disable(struct ath12k_base *ab, u16 ce_id)
{
- struct ath12k_pci *ab_pci = ath12k_pci_priv(ab);
u32 irq_idx;
/* In case of one MSI vector, we handle irq enable/disable in a
* uniform way since we only have one irq
*/
- if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (!test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
return;
irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_id;
@@ -427,13 +425,13 @@ static irqreturn_t ath12k_pci_ce_interrupt_handler(int irq, void *arg)
static void ath12k_pci_ext_grp_disable(struct ath12k_ext_irq_grp *irq_grp)
{
- struct ath12k_pci *ab_pci = ath12k_pci_priv(irq_grp->ab);
+ struct ath12k_base *ab = irq_grp->ab;
int i;
/* In case of one MSI vector, we handle irq enable/disable
* in a uniform way since we only have one irq
*/
- if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (!test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
return;
for (i = 0; i < irq_grp->num_irq; i++)
@@ -462,13 +460,13 @@ static void __ath12k_pci_ext_irq_disable(struct ath12k_base *ab)
static void ath12k_pci_ext_grp_enable(struct ath12k_ext_irq_grp *irq_grp)
{
- struct ath12k_pci *ab_pci = ath12k_pci_priv(irq_grp->ab);
+ struct ath12k_base *ab = irq_grp->ab;
int i;
/* In case of one MSI vector, we handle irq enable/disable in a
* uniform way since we only have one irq
*/
- if (!test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (!test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
return;
for (i = 0; i < irq_grp->num_irq; i++)
@@ -626,7 +624,7 @@ static int ath12k_pci_ext_irq_config(struct ath12k_base *ab)
static int ath12k_pci_set_irq_affinity_hint(struct ath12k_pci *ab_pci,
const struct cpumask *m)
{
- if (test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab_pci->ab->dev_flags))
return 0;
return irq_set_affinity_and_hint(ab_pci->pdev->irq, m);
@@ -762,7 +760,7 @@ static int ath12k_pci_msi_alloc(struct ath12k_pci *ab_pci)
PCI_IRQ_MSI);
if (num_vectors == msi_config->total_vectors) {
- set_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags);
+ set_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags);
ab_pci->irq_flags = IRQF_SHARED;
} else {
num_vectors = pci_alloc_irq_vectors(ab_pci->pdev,
@@ -773,7 +771,7 @@ static int ath12k_pci_msi_alloc(struct ath12k_pci *ab_pci)
ret = -EINVAL;
goto reset_msi_config;
}
- clear_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags);
+ clear_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags);
ab->msi.config = &msi_config_one_msi;
ab_pci->irq_flags = IRQF_SHARED | IRQF_NOBALANCING;
ath12k_dbg(ab, ATH12K_DBG_PCI, "request MSI one vector\n");
@@ -1152,7 +1150,7 @@ int ath12k_pci_start(struct ath12k_base *ab)
set_bit(ATH12K_PCI_FLAG_INIT_DONE, &ab_pci->flags);
- if (test_bit(ATH12K_PCI_FLAG_MULTI_MSI_VECTORS, &ab_pci->flags))
+ if (test_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags))
ath12k_pci_aspm_restore(ab_pci);
else
ath12k_info(ab, "leaving PCI ASPM disabled to avoid MHI M2 problems\n");
diff --git a/drivers/net/wireless/ath/ath12k/pci.h b/drivers/net/wireless/ath/ath12k/pci.h
index 47c8760536e4..3097afb03432 100644
--- a/drivers/net/wireless/ath/ath12k/pci.h
+++ b/drivers/net/wireless/ath/ath12k/pci.h
@@ -100,7 +100,6 @@ enum ath12k_pci_flags {
ATH12K_PCI_FLAG_INIT_DONE,
ATH12K_PCI_FLAG_IS_MSI_64,
ATH12K_PCI_ASPM_RESTORE,
- ATH12K_PCI_FLAG_MULTI_MSI_VECTORS,
};
struct ath12k_pci_ops {
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 07/17] wifi: ath12k: Add hybrid_bus_type in ath12k_hw_params
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (5 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 06/17] wifi: ath12k: move multi MSI vector flag to ath12k_dev_flags Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 08/17] wifi: ath12k: Add hif operation support for QCN6432 Aaradhana Sahu
` (9 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
QCN6432 is a PCIe-based device attached to the WCSS Q6 processor,
but it is registered as a platform (AHB) device. It uses AHB APIs
for probe and boot. Because of this hybrid nature, it is called as
a hybrid bus device.
Introduce a hybrid_bus_type field in ath12k_hw_params to indicate the
hybrid nature of the device.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/hw.h | 6 ++++++
drivers/net/wireless/ath/ath12k/wifi7/hw.c | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/drivers/net/wireless/ath/ath12k/hw.h b/drivers/net/wireless/ath/ath12k/hw.h
index 2e585a42dd9b..84b9440b2c16 100644
--- a/drivers/net/wireless/ath/ath12k/hw.h
+++ b/drivers/net/wireless/ath/ath12k/hw.h
@@ -239,6 +239,12 @@ struct ath12k_hw_params {
} client;
bool host_alloc_ml_id;
+ /*
+ * True for devices with PCIe hardware registered as AHB platform devices.
+ * Such devices use AHB APIs for probe/boot but PCIe APIs for operation.
+ * Example: QCN6432 (PCIe device attached to Q6, registered as AHB).
+ */
+ bool hybrid_bus_type;
};
struct ath12k_hw_ops {
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hw.c b/drivers/net/wireless/ath/ath12k/wifi7/hw.c
index 408844024dd6..f91279477a20 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/hw.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/hw.c
@@ -497,6 +497,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = true,
+ .hybrid_bus_type = false,
},
{
.name = "wcn7850 hw2.0",
@@ -592,6 +593,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = false,
+ .hybrid_bus_type = false,
},
{
.name = "qcn9274 hw2.0",
@@ -683,6 +685,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = true,
+ .hybrid_bus_type = false,
},
{
.name = "ipq5332 hw1.0",
@@ -768,6 +771,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = true,
+ .hybrid_bus_type = false,
},
{
.name = "qcc2072 hw1.0",
@@ -864,6 +868,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = false,
+ .hybrid_bus_type = false,
},
{
.name = "ipq5424 hw1.0",
@@ -952,6 +957,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = true,
+ .hybrid_bus_type = false,
},
{
.name = "qcn6432 hw1.0",
@@ -1036,6 +1042,7 @@ static const struct ath12k_hw_params ath12k_wifi7_hw_params[] = {
},
.host_alloc_ml_id = true,
+ .hybrid_bus_type = true,
},
};
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 08/17] wifi: ath12k: Add hif operation support for QCN6432
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (6 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 07/17] wifi: ath12k: Add hybrid_bus_type in ath12k_hw_params Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 09/17] wifi: ath12k: add support for unified data-region memory allocation Aaradhana Sahu
` (8 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Add hif operations (ath12k_hif_ops) for the QCN6432 Wi-Fi driver.
Reuse existing hif operations such as power_up and power_down from
IPQ5332, as they are identical on QCN6432. Similarly, reuse operations
like irq_enable, irq_disable, get_user_msi_vector, and
map_service_to_pipe from QCN9274, since their behavior matches on
QCN6432.
Implement QCN6432-specific operations such as start, stop,
cmem_read32, cmem_write32, read32, write32, get_msi_address, and
config_static_window in a new pcic.c file.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Co-developed-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/Makefile | 2 +-
drivers/net/wireless/ath/ath12k/ahb.c | 23 ++++
drivers/net/wireless/ath/ath12k/ahb.h | 9 ++
drivers/net/wireless/ath/ath12k/core.c | 3 +
drivers/net/wireless/ath/ath12k/core.h | 2 +
drivers/net/wireless/ath/ath12k/hif.h | 30 ++++++
drivers/net/wireless/ath/ath12k/pcic.c | 156 ++++++++++++++++++++++++++++
drivers/net/wireless/ath/ath12k/pcic.h | 22 ++++
drivers/net/wireless/ath/ath12k/wifi7/ahb.c | 7 ++
9 files changed, 253 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/Makefile b/drivers/net/wireless/ath/ath12k/Makefile
index 3b39b2c33307..861ec85eebed 100644
--- a/drivers/net/wireless/ath/ath12k/Makefile
+++ b/drivers/net/wireless/ath/ath12k/Makefile
@@ -22,7 +22,7 @@ ath12k-y += core.o \
fw.o \
p2p.o
-ath12k-$(CONFIG_ATH12K_AHB) += ahb.o
+ath12k-$(CONFIG_ATH12K_AHB) += ahb.o pcic.o
obj-$(CONFIG_ATH12K) += wifi7/
diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index 85360365aa4b..b23a0e9dbf61 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -16,6 +16,8 @@
#include "ahb.h"
#include "debug.h"
#include "hif.h"
+#include "pci.h"
+#include "pcic.h"
#define ATH12K_IRQ_CE0_OFFSET 4
#define ATH12K_UPD_IRQ_WRD_LEN 18
@@ -761,6 +763,26 @@ const struct ath12k_hif_ops ath12k_ahb_hif_ops = {
};
EXPORT_SYMBOL(ath12k_ahb_hif_ops);
+const struct ath12k_hif_ops ath12k_ahb_hif_ops_qcn6432 = {
+ .start = ath12k_pcic_start,
+ .stop = ath12k_pcic_stop,
+ .cmem_read32 = ath12k_pcic_cmem_read32,
+ .cmem_write32 = ath12k_pcic_cmem_write32,
+ .power_down = ath12k_ahb_power_down,
+ .power_up = ath12k_ahb_power_up,
+ .read32 = ath12k_pcic_read32,
+ .write32 = ath12k_pcic_write32,
+ .irq_enable = ath12k_pci_ext_irq_enable,
+ .irq_disable = ath12k_pci_ext_irq_disable,
+ .get_msi_address = ath12k_pcic_get_msi_address,
+ .get_user_msi_vector = ath12k_pci_get_user_msi_assignment,
+ .map_service_to_pipe = ath12k_pci_map_service_to_pipe,
+ .ce_irq_enable = ath12k_pci_ce_irqs_enable,
+ .ce_irq_disable = ath12k_pci_ce_irq_disable_sync,
+ .config_static_window = ath12k_pcic_config_static_window,
+};
+EXPORT_SYMBOL(ath12k_ahb_hif_ops_qcn6432);
+
static irqreturn_t ath12k_userpd_irq_handler(int irq, void *data)
{
struct ath12k_base *ab = data;
@@ -1295,6 +1317,7 @@ static int ath12k_ahb_probe(struct platform_device *pdev)
ath12k_dbg(ab, ATH12K_DBG_AHB, "AHB device family id: %d\n", device_id);
ab_ahb->device_family_ops = &ath12k_ahb_family_drivers[device_id]->ops;
+ ab_ahb->reg_base = ath12k_ahb_family_drivers[device_id]->reg_base;
/* Call device specific probe. This is the callback that can
* be used to override any ops in future
diff --git a/drivers/net/wireless/ath/ath12k/ahb.h b/drivers/net/wireless/ath/ath12k/ahb.h
index ecc4054f8742..373dc3b92728 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.h
+++ b/drivers/net/wireless/ath/ath12k/ahb.h
@@ -11,6 +11,11 @@
#include <linux/platform_device.h>
#include "core.h"
+struct ath12k_ahb_reg_base {
+ u32 umac_base;
+ u32 ce_reg_base;
+};
+
#define ATH12K_AHB_RECOVERY_TIMEOUT (3 * HZ)
#define ATH12K_AHB_SMP2P_SMEM_MSG GENMASK(15, 0)
@@ -65,6 +70,7 @@ enum ath12k_ahb_userpd_irq {
struct ath12k_base;
extern const struct ath12k_hif_ops ath12k_ahb_hif_ops;
+extern const struct ath12k_hif_ops ath12k_ahb_hif_ops_qcn6432;
struct ath12k_ahb_device_family_ops {
int (*probe)(struct platform_device *pdev);
@@ -103,12 +109,15 @@ struct ath12k_ahb {
bool scm_auth_enabled;
struct ath12k_ahb_rproc_info *rproc_info;
bool supports_multipd;
+ u32 static_window_reg;
+ const struct ath12k_ahb_reg_base *reg_base;
};
struct ath12k_ahb_driver {
const char *name;
const struct of_device_id *id_table;
struct ath12k_ahb_device_family_ops ops;
+ const struct ath12k_ahb_reg_base *reg_base;
struct platform_driver driver;
};
diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
index e527b59ecba5..cc1c31e216bb 100644
--- a/drivers/net/wireless/ath/ath12k/core.c
+++ b/drivers/net/wireless/ath/ath12k/core.c
@@ -1316,6 +1316,9 @@ int ath12k_core_qmi_firmware_ready(struct ath12k_base *ab)
struct ath12k_hw_group *ag = ath12k_ab_to_ag(ab);
int ret, i;
+ if (ab->hw_params->hybrid_bus_type)
+ ath12k_hif_config_static_window(ab);
+
ret = ath12k_core_start_firmware(ab, ab->fw_mode);
if (ret) {
ath12k_err(ab, "failed to start firmware: %d\n", ret);
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index eaea601ab32d..293c7561b27a 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -1161,6 +1161,8 @@ struct ath12k_base {
struct {
const struct ath12k_msi_config *config;
u32 ep_base_data;
+ u32 addr_lo;
+ u32 addr_hi;
} msi;
/* must be last */
diff --git a/drivers/net/wireless/ath/ath12k/hif.h b/drivers/net/wireless/ath/ath12k/hif.h
index aecdb0c5f285..faeabd2c3d2a 100644
--- a/drivers/net/wireless/ath/ath12k/hif.h
+++ b/drivers/net/wireless/ath/ath12k/hif.h
@@ -12,6 +12,8 @@
struct ath12k_hif_ops {
u32 (*read32)(struct ath12k_base *ab, u32 address);
void (*write32)(struct ath12k_base *ab, u32 address, u32 data);
+ int (*cmem_read32)(struct ath12k_base *ab, u32 address, u32 *value);
+ int (*cmem_write32)(struct ath12k_base *ab, u32 address, u32 data);
void (*irq_enable)(struct ath12k_base *ab);
void (*irq_disable)(struct ath12k_base *ab);
int (*start)(struct ath12k_base *ab);
@@ -31,6 +33,7 @@ struct ath12k_hif_ops {
void (*ce_irq_disable)(struct ath12k_base *ab);
void (*get_ce_msi_idx)(struct ath12k_base *ab, u32 ce_id, u32 *msi_idx);
void (*coredump_download)(struct ath12k_base *ab);
+ void (*config_static_window)(struct ath12k_base *ab);
};
static inline int ath12k_hif_map_service_to_pipe(struct ath12k_base *ab, u16 service_id,
@@ -126,6 +129,24 @@ static inline u32 ath12k_hif_read32(struct ath12k_base *ab, u32 address)
return ab->hif.ops->read32(ab, address);
}
+static inline int ath12k_hif_cmem_read32(struct ath12k_base *ab, u32 address,
+ u32 *value)
+{
+ if (!ab->hif.ops->cmem_read32)
+ return -EOPNOTSUPP;
+
+ return ab->hif.ops->cmem_read32(ab, address, value);
+}
+
+static inline int ath12k_hif_cmem_write32(struct ath12k_base *ab, u32 address,
+ u32 data)
+{
+ if (!ab->hif.ops->cmem_write32)
+ return -EOPNOTSUPP;
+
+ return ab->hif.ops->cmem_write32(ab, address, data);
+}
+
static inline void ath12k_hif_write32(struct ath12k_base *ab, u32 address,
u32 data)
{
@@ -153,4 +174,13 @@ static inline void ath12k_hif_coredump_download(struct ath12k_base *ab)
if (ab->hif.ops->coredump_download)
ab->hif.ops->coredump_download(ab);
}
+
+static inline void ath12k_hif_config_static_window(struct ath12k_base *ab)
+{
+ if (!ab->hif.ops->config_static_window)
+ return;
+
+ ab->hif.ops->config_static_window(ab);
+}
+
#endif /* ATH12K_HIF_H */
diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
new file mode 100644
index 000000000000..e3c8476af459
--- /dev/null
+++ b/drivers/net/wireless/ath/ath12k/pcic.c
@@ -0,0 +1,156 @@
+// SPDX-License-Identifier: BSD-3-Clause-Clear
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+#include <linux/module.h>
+#include "ahb.h"
+#include "core.h"
+#include "debug.h"
+#include "hif.h"
+#include "hw.h"
+#include "pci.h"
+#include "pcic.h"
+
+void ath12k_pcic_config_static_window(struct ath12k_base *ab)
+{
+ struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
+ u32 umac_window = u32_get_bits(ab_ahb->reg_base->umac_base, WINDOW_VALUE_MASK);
+ u32 ce_window = u32_get_bits(ab_ahb->reg_base->ce_reg_base, WINDOW_VALUE_MASK);
+ u32 window;
+
+ window = (umac_window << 12) | (ce_window << 6);
+ writel_relaxed(WINDOW_ENABLE_BIT | window, ab->mem + WINDOW_REG_ADDRESS);
+ ab_ahb->static_window_reg = readl_relaxed(ab->mem + WINDOW_REG_ADDRESS);
+}
+
+static int ath12k_pcic_select_static_window(struct ath12k_base *ab, u32 addr)
+{
+ struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
+
+ u32 window_bits, new_window, reg_value;
+ const int max_retries = 10;
+ int i;
+
+ window_bits = u32_get_bits(addr, WINDOW_VALUE_MASK);
+
+ /* Update window bits [5:0], preserving other bits */
+ new_window = u32_replace_bits(ab_ahb->static_window_reg, window_bits, 0x3f);
+
+ if (new_window == ab_ahb->static_window_reg)
+ return 0;
+
+ reg_value = WINDOW_ENABLE_BIT | new_window;
+ writel_relaxed(reg_value, ab->mem + WINDOW_REG_ADDRESS);
+
+ /* Wait for the write to take effect */
+ for (i = 0; i < max_retries; i++) {
+ if (readl_relaxed(ab->mem + WINDOW_REG_ADDRESS) == reg_value) {
+ ab_ahb->static_window_reg = reg_value;
+ return 0;
+ }
+
+ usleep_range(1000, 2000);
+ }
+
+ ath12k_warn(ab, "failed to set static window for cmem init\n");
+ return -ETIMEDOUT;
+}
+
+int ath12k_pcic_cmem_read32(struct ath12k_base *ab, u32 addr, u32 *value)
+{
+ int ret;
+
+ if (!value)
+ return -EINVAL;
+
+ if (addr < WINDOW_START) {
+ *value = readl_relaxed(ab->mem + addr);
+ return 0;
+ }
+
+ ret = ath12k_pcic_select_static_window(ab, addr);
+ if (ret)
+ return ret;
+
+ *value = readl_relaxed(ab->mem + WINDOW_START + (addr & WINDOW_RANGE_MASK));
+ return 0;
+}
+
+int ath12k_pcic_cmem_write32(struct ath12k_base *ab, u32 addr, u32 value)
+{
+ int ret;
+
+ if (addr < WINDOW_START) {
+ writel_relaxed(value, ab->mem + addr);
+ return 0;
+ }
+
+ ret = ath12k_pcic_select_static_window(ab, addr);
+ if (ret)
+ return ret;
+
+ writel_relaxed(value, ab->mem + WINDOW_START + (addr & WINDOW_RANGE_MASK));
+ return 0;
+}
+
+static u32 ath12k_pcic_get_window_start(struct ath12k_base *ab, u32 offset)
+{
+ struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
+ u32 window_start;
+
+ /* If offset lies within DP register range, use 3rd window */
+ if ((offset ^ ab_ahb->reg_base->umac_base) <= WINDOW_RANGE_MASK)
+ window_start = 3 * WINDOW_START;
+ /* If offset lies within CE register range, use 2nd window */
+ else if ((offset ^ ab_ahb->reg_base->ce_reg_base) <= WINDOW_RANGE_MASK)
+ window_start = 2 * WINDOW_START;
+ else
+ window_start = WINDOW_START;
+
+ return window_start;
+}
+
+void ath12k_pcic_get_msi_address(struct ath12k_base *ab, u32 *msi_addr_lo,
+ u32 *msi_addr_hi)
+{
+ *msi_addr_lo = ab->msi.addr_lo;
+ *msi_addr_hi = ab->msi.addr_hi;
+}
+
+void ath12k_pcic_stop(struct ath12k_base *ab)
+{
+ ath12k_pci_ce_irq_disable_sync(ab);
+ timer_delete_sync(&ab->rx_replenish_retry);
+ ath12k_ce_cleanup_pipes(ab);
+}
+
+int ath12k_pcic_start(struct ath12k_base *ab)
+{
+ ath12k_pci_ce_irqs_enable(ab);
+ ath12k_ce_rx_post_buf(ab);
+ return 0;
+}
+
+u32 ath12k_pcic_read32(struct ath12k_base *ab, u32 offset)
+{
+ u32 window_start;
+
+ if (offset < WINDOW_START)
+ return readl_relaxed(ab->mem + offset);
+
+ window_start = ath12k_pcic_get_window_start(ab, offset);
+ return readl_relaxed(ab->mem + window_start + (offset & WINDOW_RANGE_MASK));
+}
+
+void ath12k_pcic_write32(struct ath12k_base *ab, u32 offset, u32 value)
+{
+ u32 window_start;
+
+ if (offset < WINDOW_START) {
+ writel_relaxed(value, ab->mem + offset);
+ return;
+ }
+
+ window_start = ath12k_pcic_get_window_start(ab, offset);
+ writel_relaxed(value, ab->mem + window_start + (offset & WINDOW_RANGE_MASK));
+}
diff --git a/drivers/net/wireless/ath/ath12k/pcic.h b/drivers/net/wireless/ath/ath12k/pcic.h
new file mode 100644
index 000000000000..f77091927039
--- /dev/null
+++ b/drivers/net/wireless/ath/ath12k/pcic.h
@@ -0,0 +1,22 @@
+/* SPDX-License-Identifier: BSD-3-Clause-Clear */
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+#ifndef _ATH12K_PCIC_H
+#define _ATH12K_PCIC_H
+
+#include <linux/types.h>
+
+struct ath12k_base;
+
+int ath12k_pcic_start(struct ath12k_base *ab);
+void ath12k_pcic_stop(struct ath12k_base *ab);
+void ath12k_pcic_write32(struct ath12k_base *ab, u32 offset, u32 value);
+u32 ath12k_pcic_read32(struct ath12k_base *ab, u32 offset);
+void ath12k_pcic_get_msi_address(struct ath12k_base *ab, u32 *msi_addr_lo,
+ u32 *msi_addr_hi);
+int ath12k_pcic_cmem_write32(struct ath12k_base *ab, u32 addr,
+ u32 value);
+int ath12k_pcic_cmem_read32(struct ath12k_base *ab, u32 addr, u32 *value);
+void ath12k_pcic_config_static_window(struct ath12k_base *ab);
+#endif /* _ATH12K_PCIC_H */
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
index 70372db6abae..bff48b2fe124 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
@@ -14,6 +14,7 @@
#include "hw.h"
#include "dp.h"
#include "core.h"
+#include "hal.h"
static const struct ath12k_ahb_desc ath12k_wifi7_ahb_desc[] = {
[ATH12K_HW_IPQ5332_HW10] = {
@@ -72,9 +73,15 @@ static int ath12k_wifi7_ahb_probe(struct platform_device *pdev)
return 0;
}
+static const struct ath12k_ahb_reg_base ath12k_wifi7_ahb_reg_base = {
+ .umac_base = HAL_SEQ_WCSS_UMAC_OFFSET,
+ .ce_reg_base = HAL_CE_WFSS_CE_REG_BASE,
+};
+
static struct ath12k_ahb_driver ath12k_wifi7_ahb_driver = {
.name = "ath12k_wifi7_ahb",
.id_table = ath12k_wifi7_ahb_of_match,
+ .reg_base = &ath12k_wifi7_ahb_reg_base,
.ops.probe = ath12k_wifi7_ahb_probe,
.ops.arch_init = ath12k_wifi7_arch_init,
.ops.arch_deinit = ath12k_wifi7_arch_deinit,
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 09/17] wifi: ath12k: add support for unified data-region memory allocation
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (7 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 08/17] wifi: ath12k: Add hif operation support for QCN6432 Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:35 ` sashiko-bot
2026-10-08 10:24 ` [PATCH ath-next 10/17] wifi: ath12k: move MSI config to pci.c Aaradhana Sahu
` (7 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
Add support for devices such as QCN6432 that provide the M3 and
calibration memory through a unified data-region reserved-memory
node. The QCN6432 device tree continues to provide separate
q6-region and mlo-global-mem regions, while the memory types
mapped to M3 and calibration memory are allocated sequentially from
data-region.
Track the allocated space using an offset and allocate each required
memory chunk from the unified region.
If the data-region lookup does not return a reserved-memory region,
fall back to the existing per-memory-type allocation scheme using the
named memory regions such as q6-region, m3-dump, and q6-caldb.
Introduce a helper ath12k_qmi_map_target_mem() to initialize and map QMI
target memory chunks.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/qmi.c | 83 +++++++++++++++++++++++++++++------
1 file changed, 70 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
index 817bd820623d..cc488cfe2b2f 100644
--- a/drivers/net/wireless/ath/ath12k/qmi.c
+++ b/drivers/net/wireless/ath/ath12k/qmi.c
@@ -2842,6 +2842,26 @@ static const char *ath12k_qmi_get_mem_reg_name(int mem_type)
}
}
+static int ath12k_qmi_map_target_mem(struct ath12k_base *ab, int idx,
+ phys_addr_t paddr, u32 size, u32 type)
+{
+ ab->qmi.target_mem[idx].paddr = paddr;
+
+ if (paddr) {
+ ab->qmi.target_mem[idx].v.ioaddr =
+ ioremap(ab->qmi.target_mem[idx].paddr, size);
+ if (!ab->qmi.target_mem[idx].v.ioaddr)
+ return -EIO;
+ } else {
+ ab->qmi.target_mem[idx].v.ioaddr = NULL;
+ }
+
+ ab->qmi.target_mem[idx].size = size;
+ ab->qmi.target_mem[idx].type = type;
+
+ return 0;
+}
+
static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
{
struct device_node *np = ab->dev->of_node;
@@ -2851,6 +2871,48 @@ static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
const char *rname;
int i, idx, ret;
+ ret = of_reserved_mem_region_to_resource_byname(np, "data-region", &res);
+ if (ret && ret != -ENODATA)
+ return ret;
+
+ if (!ret) {
+ avail_rmem_size = resource_size(&res);
+ for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
+ chunk = &ab->qmi.target_mem[i];
+
+ if (chunk->type == CALDB_MEM_REGION_TYPE) {
+ ret = ath12k_qmi_map_target_mem(ab, idx, 0, chunk->size,
+ chunk->type);
+ if (ret)
+ goto out;
+
+ idx++;
+ continue;
+ }
+
+ if (offset > avail_rmem_size ||
+ avail_rmem_size - offset < chunk->size) {
+ ath12k_err(ab, "failed to assign mem type %u req size %u avail size %zu\n",
+ chunk->type, chunk->size,
+ offset > avail_rmem_size ? 0 :
+ avail_rmem_size - offset);
+ ret = -EINVAL;
+ goto out;
+ }
+
+ ret = ath12k_qmi_map_target_mem(ab, idx, res.start + offset,
+ chunk->size, chunk->type);
+ if (ret)
+ goto out;
+
+ offset += chunk->size;
+ idx++;
+ }
+
+ ab->qmi.mem_seg_count = idx;
+ return 0;
+ }
+
for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
chunk = &ab->qmi.target_mem[i];
if (chunk->type == CALDB_MEM_REGION_TYPE) {
@@ -2860,10 +2922,11 @@ static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
* Once cold boot calibration is enabled add support to
* assign reserved memory from DT.
*/
- ab->qmi.target_mem[idx].paddr = 0;
- ab->qmi.target_mem[idx].v.ioaddr = NULL;
- ab->qmi.target_mem[idx].size = chunk->size;
- ab->qmi.target_mem[idx].type = chunk->type;
+ ret = ath12k_qmi_map_target_mem(ab, idx, 0, chunk->size,
+ chunk->type);
+ if (ret)
+ goto out;
+
idx++;
continue;
}
@@ -2904,16 +2967,10 @@ static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
goto out;
}
- ab->qmi.target_mem[idx].paddr = res.start;
- ab->qmi.target_mem[idx].v.ioaddr = ioremap(ab->qmi.target_mem[idx].paddr,
- chunk->size);
- if (!ab->qmi.target_mem[idx].v.ioaddr) {
- ret = -EIO;
+ ret = ath12k_qmi_map_target_mem(ab, idx, res.start, chunk->size,
+ chunk->type);
+ if (ret)
goto out;
- }
-
- ab->qmi.target_mem[idx].size = chunk->size;
- ab->qmi.target_mem[idx].type = chunk->type;
idx++;
}
ab->qmi.mem_seg_count = idx;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 09/17] wifi: ath12k: add support for unified data-region memory allocation
2026-10-08 10:24 ` [PATCH ath-next 09/17] wifi: ath12k: add support for unified data-region memory allocation Aaradhana Sahu
@ 2026-10-08 10:35 ` sashiko-bot
2026-10-12 7:25 ` Aaradhana Sahu
0 siblings, 1 reply; 30+ messages in thread
From: sashiko-bot @ 2026-10-08 10:35 UTC (permalink / raw)
To: Aaradhana Sahu; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] wifi: ath12k: qmi target mem data-region misallocation
--
commit 889e203c71e56c91154908ff956ce486dc098cf4
Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
wifi: ath12k: add support for unified data-region memory allocation
Add support for devices such as QCN6432 that provide the M3 and
calibration memory through a unified data-region reserved-memory node.
If the data-region is found, allocate each memory chunk from it sequentially.
> diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
> index 817bd820623d2..cc488cfe2b2fb 100644
> --- a/drivers/net/wireless/ath/ath12k/qmi.c
> +++ b/drivers/net/wireless/ath/ath12k/qmi.c
[ ... ]
> @@ -2851,6 +2871,48 @@ static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
> const char *rname;
> int i, idx, ret;
>
> + ret = of_reserved_mem_region_to_resource_byname(np, "data-region", &res);
> + if (ret && ret != -ENODATA)
> + return ret;
> +
> + if (!ret) {
> + avail_rmem_size = resource_size(&res);
> + for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
> + chunk = &ab->qmi.target_mem[i];
> +
> + if (chunk->type == CALDB_MEM_REGION_TYPE) {
> + ret = ath12k_qmi_map_target_mem(ab, idx, 0, chunk->size,
> + chunk->type);
[Severity: High]
The commit message indicates that calibration memory is allocated sequentially
from data-region. However, paddr 0 is passed here and the region's offset is
not consumed. Is CALDB intended to be allocated from the data-region or
mapped to 0?
> + if (ret)
> + goto out;
> +
> + idx++;
> + continue;
> + }
> +
> + if (offset > avail_rmem_size ||
> + avail_rmem_size - offset < chunk->size) {
> + ath12k_err(ab, "failed to assign mem type %u req size %u avail size %zu\n",
> + chunk->type, chunk->size,
> + offset > avail_rmem_size ? 0 :
> + avail_rmem_size - offset);
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + ret = ath12k_qmi_map_target_mem(ab, idx, res.start + offset,
> + chunk->size, chunk->type);
[Severity: High]
This loop maps every chunk type (other than CALDB) sequentially into the
data-region without filtering by chunk type.
Since the commit message states the device tree continues to provide
separate q6-region and mlo-global-mem regions, won't this incorrectly map
types like HOST_DDR_REGION_TYPE and MLO_GLOBAL_MEM_REGION_TYPE into the
data-region instead of their dedicated DT regions?
> + if (ret)
> + goto out;
> +
> + offset += chunk->size;
> + idx++;
> + }
> +
> + ab->qmi.mem_seg_count = idx;
> + return 0;
> + }
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-mpp_bringup-v1-0-2c5797b5e4ac@oss.qualcomm.com?part=9
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 09/17] wifi: ath12k: add support for unified data-region memory allocation
2026-10-08 10:35 ` sashiko-bot
@ 2026-10-12 7:25 ` Aaradhana Sahu
0 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-12 7:25 UTC (permalink / raw)
To: sashiko-reviews; +Cc: robh, devicetree, conor+dt
On 10/8/2026 4:05 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] wifi: ath12k: qmi target mem data-region misallocation
> --
>
> commit 889e203c71e56c91154908ff956ce486dc098cf4
> Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
>
> wifi: ath12k: add support for unified data-region memory allocation
>
> Add support for devices such as QCN6432 that provide the M3 and
> calibration memory through a unified data-region reserved-memory node.
> If the data-region is found, allocate each memory chunk from it sequentially.
>
>> diff --git a/drivers/net/wireless/ath/ath12k/qmi.c b/drivers/net/wireless/ath/ath12k/qmi.c
>> index 817bd820623d2..cc488cfe2b2fb 100644
>> --- a/drivers/net/wireless/ath/ath12k/qmi.c
>> +++ b/drivers/net/wireless/ath/ath12k/qmi.c
>
> [ ... ]
>
>> @@ -2851,6 +2871,48 @@ static int ath12k_qmi_assign_target_mem_chunk(struct ath12k_base *ab)
>> const char *rname;
>> int i, idx, ret;
>>
>> + ret = of_reserved_mem_region_to_resource_byname(np, "data-region", &res);
>> + if (ret && ret != -ENODATA)
>> + return ret;
>> +
>> + if (!ret) {
>> + avail_rmem_size = resource_size(&res);
>> + for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
>> + chunk = &ab->qmi.target_mem[i];
>> +
>> + if (chunk->type == CALDB_MEM_REGION_TYPE) {
>> + ret = ath12k_qmi_map_target_mem(ab, idx, 0, chunk->size,
>> + chunk->type);
>
> [Severity: High]
> The commit message indicates that calibration memory is allocated sequentially
> from data-region. However, paddr 0 is passed here and the region's offset is
> not consumed. Is CALDB intended to be allocated from the data-region or
> mapped to 0?
>
Since ath12k does not currently support cold boot calibration, the firmware is
expected to provide a paddr of 0 for the calibration memory in this case.
>> + if (ret)
>> + goto out;
>> +
>> + idx++;
>> + continue;
>> + }
>> +
>> + if (offset > avail_rmem_size ||
>> + avail_rmem_size - offset < chunk->size) {
>> + ath12k_err(ab, "failed to assign mem type %u req size %u avail size %zu\n",
>> + chunk->type, chunk->size,
>> + offset > avail_rmem_size ? 0 :
>> + avail_rmem_size - offset);
>> + ret = -EINVAL;
>> + goto out;
>> + }
>> +
>> + ret = ath12k_qmi_map_target_mem(ab, idx, res.start + offset,
>> + chunk->size, chunk->type);
>
> [Severity: High]
> This loop maps every chunk type (other than CALDB) sequentially into the
> data-region without filtering by chunk type.
>
> Since the commit message states the device tree continues to provide
> separate q6-region and mlo-global-mem regions, won't this incorrectly map
> types like HOST_DDR_REGION_TYPE and MLO_GLOBAL_MEM_REGION_TYPE into the
> data-region instead of their dedicated DT regions?
>
The data-region is defined for QCN6432, and MLO is not currently supported for
QCN6432 on the AHB platform. Therefore, the firmware is not expected to request
the MLO_GLOBAL_MEM_REGION_TYPE at present.
HOST_DDR_REGION_TYPE is expected to be allocated from the data-region. The intention
is to allocate firmware memory requests from the data-region, except for
MLO_GLOBAL_MEM_REGION_TYPE, which requires separate handling.
The MLO-specific memory allocation can be addressed as part of the MLO enablement series for
AHB devices.
>> + if (ret)
>> + goto out;
>> +
>> + offset += chunk->size;
>> + idx++;
>> + }
>> +
>> + ab->qmi.mem_seg_count = idx;
>> + return 0;
>> + }
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH ath-next 10/17] wifi: ath12k: move MSI config to pci.c
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (8 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 09/17] wifi: ath12k: add support for unified data-region memory allocation Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 11/17] wifi: ath12k: Add platform MSI support for CE Aaradhana Sahu
` (6 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
Move the ath12k_wifi7_msi_config array from wifi7/pci.c to pci.c
so it can be shared between QCN9274 and QCN6432 devices. Rename it to
ath12k_msi_config.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/pci.c | 14 ++++++++++++++
drivers/net/wireless/ath/ath12k/pci.h | 2 ++
drivers/net/wireless/ath/ath12k/wifi7/pci.c | 19 +++----------------
3 files changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index e6fe891e58b1..fe0939ca890c 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -40,6 +40,20 @@ static const struct ath12k_msi_config msi_config_one_msi = {
},
};
+/* TODO: revisit IRQ mapping for new SRNGs */
+const struct ath12k_msi_config ath12k_msi_config[] = {
+ {
+ .total_vectors = 16,
+ .total_users = 3,
+ .users = (const struct ath12k_msi_user[]) {
+ { .name = "MHI", .num_vectors = 3, .base_vector = 0 },
+ { .name = "CE", .num_vectors = 5, .base_vector = 3 },
+ { .name = "DP", .num_vectors = 8, .base_vector = 8 },
+ },
+ },
+};
+EXPORT_SYMBOL(ath12k_msi_config);
+
static const char *irq_name[ATH12K_IRQ_NUM_MAX] = {
"bhi",
"mhi-er0",
diff --git a/drivers/net/wireless/ath/ath12k/pci.h b/drivers/net/wireless/ath/ath12k/pci.h
index 3097afb03432..55cc875f9ce0 100644
--- a/drivers/net/wireless/ath/ath12k/pci.h
+++ b/drivers/net/wireless/ath/ath12k/pci.h
@@ -96,6 +96,8 @@ struct ath12k_msi_config {
const struct ath12k_msi_user *users;
};
+extern const struct ath12k_msi_config ath12k_msi_config[];
+
enum ath12k_pci_flags {
ATH12K_PCI_FLAG_INIT_DONE,
ATH12K_PCI_FLAG_IS_MSI_64,
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/pci.c b/drivers/net/wireless/ath/ath12k/wifi7/pci.c
index bb617bb6b71a..783c5d020f07 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/pci.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/pci.c
@@ -37,19 +37,6 @@ static const struct pci_device_id ath12k_wifi7_pci_id_table[] = {
MODULE_DEVICE_TABLE(pci, ath12k_wifi7_pci_id_table);
-/* TODO: revisit IRQ mapping for new SRNG's */
-static const struct ath12k_msi_config ath12k_wifi7_msi_config[] = {
- {
- .total_vectors = 16,
- .total_users = 3,
- .users = (struct ath12k_msi_user[]) {
- { .name = "MHI", .num_vectors = 3, .base_vector = 0 },
- { .name = "CE", .num_vectors = 5, .base_vector = 3 },
- { .name = "DP", .num_vectors = 8, .base_vector = 8 },
- },
- },
-};
-
static const struct ath12k_pci_ops ath12k_wifi7_pci_ops_qcn9274 = {
.wakeup = NULL,
.release = NULL,
@@ -103,7 +90,7 @@ static int ath12k_wifi7_pci_probe(struct pci_dev *pdev,
switch (pci_dev->device) {
case QCN9274_DEVICE_ID:
- ab->msi.config = &ath12k_wifi7_msi_config[ATH12K_MSI_CONFIG_PCI];
+ ab->msi.config = &ath12k_msi_config[ATH12K_MSI_CONFIG_PCI];
ab->static_window_map = true;
ab_pci->pci_ops = &ath12k_wifi7_pci_ops_qcn9274;
/*
@@ -130,7 +117,7 @@ static int ath12k_wifi7_pci_probe(struct pci_dev *pdev,
break;
case WCN7850_DEVICE_ID:
ab->id.bdf_search = ATH12K_BDF_SEARCH_BUS_AND_BOARD;
- ab->msi.config = &ath12k_wifi7_msi_config[ATH12K_MSI_CONFIG_PCI];
+ ab->msi.config = &ath12k_msi_config[ATH12K_MSI_CONFIG_PCI];
ab->static_window_map = false;
ab_pci->pci_ops = &ath12k_wifi7_pci_ops_wcn7850;
/*
@@ -154,7 +141,7 @@ static int ath12k_wifi7_pci_probe(struct pci_dev *pdev,
break;
case QCC2072_DEVICE_ID:
ab->id.bdf_search = ATH12K_BDF_SEARCH_BUS_AND_BOARD;
- ab->msi.config = &ath12k_wifi7_msi_config[ATH12K_MSI_CONFIG_PCI];
+ ab->msi.config = &ath12k_msi_config[ATH12K_MSI_CONFIG_PCI];
ab->static_window_map = false;
ab_pci->pci_ops = &ath12k_wifi7_pci_ops_wcn7850;
ab_pci->window_reg_addr = WINDOW_REG_ADDRESS_QCC2072;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 11/17] wifi: ath12k: Add platform MSI support for CE
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (9 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 10/17] wifi: ath12k: move MSI config to pci.c Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:41 ` sashiko-bot
2026-10-08 10:24 ` [PATCH ath-next 12/17] wifi: ath12k: Enable MSI interrupt support for DP interrupt Aaradhana Sahu
` (5 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
QCN6432 is attached through AHB but provides Copy Engine (CE) interrupts
using platform MSI vectors instead of dedicated platform IRQ lines. The
existing ath12k AHB interrupt setup only requests named CE IRQs from
the platform and therefore cannot configure CE interrupts on QCN6432.
Add support for configuring CE interrupts through platform MSI on
hybrid AHB devices. Introduce an IPCI MSI configuration for these
platforms, allocate MSI vectors from the platform MSI domain, and
register CE interrupt handlers using the allocated vectors.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Co-developed-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/ahb.c | 14 +++
drivers/net/wireless/ath/ath12k/ce.h | 4 +
drivers/net/wireless/ath/ath12k/core.h | 7 ++
drivers/net/wireless/ath/ath12k/pci.c | 9 ++
drivers/net/wireless/ath/ath12k/pcic.c | 155 +++++++++++++++++++++++++++++++++
drivers/net/wireless/ath/ath12k/pcic.h | 2 +
6 files changed, 191 insertions(+)
diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index b23a0e9dbf61..78367126f49f 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -550,6 +550,16 @@ static void ath12k_ahb_init_qmi_ce_config(struct ath12k_base *ab)
ab->qmi.service_ins_id = ab->hw_params->qmi_service_ins_id;
}
+static void ath12k_ahb_disable_irq(struct ath12k_base *ab)
+{
+ if (ab->hw_params->hybrid_bus_type) {
+ ath12k_pcic_free_irq(ab);
+ return;
+ }
+
+ ath12k_ahb_ce_irqs_disable(ab);
+}
+
static void ath12k_ahb_ce_workqueue(struct work_struct *work)
{
struct ath12k_ce_pipe *ce_pipe = from_work(ce_pipe, work, intr_wq);
@@ -690,6 +700,9 @@ static int ath12k_ahb_config_irq(struct ath12k_base *ab)
int irq, irq_idx, i;
int ret;
+ if (ab->hw_params->hybrid_bus_type)
+ return ath12k_pcic_config_irq(ab);
+
/* Configure CE irqs */
for (i = 0; i < ab->hw_params->ce_count; i++) {
struct ath12k_ce_pipe *ce_pipe = &ab->ce.ce_pipe[i];
@@ -1432,6 +1445,7 @@ static void ath12k_ahb_free_resources(struct ath12k_base *ab)
struct platform_device *pdev = ab->pdev;
struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
+ ath12k_ahb_disable_irq(ab);
ath12k_hal_srng_deinit(ab);
ath12k_ce_free_pipes(ab);
ath12k_ahb_resource_deinit(ab);
diff --git a/drivers/net/wireless/ath/ath12k/ce.h b/drivers/net/wireless/ath/ath12k/ce.h
index cd913a885470..c15ec0c32374 100644
--- a/drivers/net/wireless/ath/ath12k/ce.h
+++ b/drivers/net/wireless/ath/ath12k/ce.h
@@ -11,6 +11,9 @@
#define ATH12K_MSI_IRQ_CE0_OFFSET 3
+/* IRQ name buffer size for CE interrupts */
+#define ATH12K_CE_IRQ_NAME_LEN 32
+
/* Byte swap data words */
#define CE_ATTR_BYTE_SWAP_DATA 2
@@ -172,6 +175,7 @@ struct ath12k_ce_pipe {
struct ath12k_ce_ring *dest_ring;
struct ath12k_ce_ring *status_ring;
u64 timestamp;
+ char irq_name[ATH12K_CE_IRQ_NAME_LEN];
};
struct ath12k_ce {
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index 293c7561b27a..21332aeb0c22 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -164,6 +164,7 @@ enum ath12k_hw_rev {
#define ATH12K_IRQ_NUM_MAX 57
#define ATH12K_EXT_IRQ_NUM_MAX 16
#define ATH12K_MAX_TCL_RING_NUM 3
+#define ATH12K_MAX_MSI_VECTOR 32
struct ath12k_ext_irq_grp {
struct ath12k_base *ab;
@@ -189,6 +190,12 @@ enum ath12k_smbios_cc_type {
enum ath12k_msi_supported_hw {
ATH12K_MSI_CONFIG_PCI,
+
+ /*
+ * IPCI (Integrated PCI) configuration is used by AHB devices that
+ * support platform MSI.
+ */
+ ATH12K_MSI_CONFIG_IPCI,
};
struct ath12k_smbios_bdf {
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index fe0939ca890c..a26fdb3c0ad2 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -51,6 +51,15 @@ const struct ath12k_msi_config ath12k_msi_config[] = {
{ .name = "DP", .num_vectors = 8, .base_vector = 8 },
},
},
+ {
+ .total_vectors = 32,
+ .total_users = 3,
+ .users = (const struct ath12k_msi_user[]) {
+ { .name = "QDSS", .num_vectors = 1, .base_vector = 0 },
+ { .name = "CE", .num_vectors = 5, .base_vector = 1 },
+ { .name = "DP", .num_vectors = 15, .base_vector = 6 },
+ },
+ },
};
EXPORT_SYMBOL(ath12k_msi_config);
diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
index e3c8476af459..fea284c3707b 100644
--- a/drivers/net/wireless/ath/ath12k/pcic.c
+++ b/drivers/net/wireless/ath/ath12k/pcic.c
@@ -3,6 +3,7 @@
* Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
*/
#include <linux/module.h>
+#include <linux/msi.h>
#include "ahb.h"
#include "core.h"
#include "debug.h"
@@ -154,3 +155,157 @@ void ath12k_pcic_write32(struct ath12k_base *ab, u32 offset, u32 value)
window_start = ath12k_pcic_get_window_start(ab, offset);
writel_relaxed(value, ab->mem + window_start + (offset & WINDOW_RANGE_MASK));
}
+
+static void ath12k_pcic_ce_irq_disable(struct ath12k_base *ab, u16 ce_id)
+{
+ u32 irq_idx;
+
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + ce_id;
+ disable_irq_nosync(ab->irq_num[irq_idx]);
+}
+
+static irqreturn_t ath12k_pcic_ce_interrupt_handler(int irq, void *arg)
+{
+ struct ath12k_ce_pipe *ce_pipe = arg;
+ struct ath12k_base *ab = ce_pipe->ab;
+
+ if (!test_bit(ATH12K_FLAG_CE_IRQ_ENABLED, &ab->dev_flags))
+ return IRQ_HANDLED;
+
+ /* last interrupt received for this CE */
+ ce_pipe->timestamp = jiffies;
+
+ ath12k_pcic_ce_irq_disable(ab, ce_pipe->pipe_num);
+ queue_work(system_bh_wq, &ce_pipe->intr_wq);
+
+ return IRQ_HANDLED;
+}
+
+static int ath12k_pcic_ce_irq_config(struct ath12k_base *ab,
+ struct msi_desc **msi_desc, int num_msi)
+{
+ struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
+ int irq_idx, ret, i, vec_idx = 0;
+ u8 userpd_id = ab_ahb->userpd_id;
+ struct ath12k_ce_pipe *ce_pipe;
+ bool msi_info_captured = false;
+ struct msi_desc *desc;
+
+ for (i = 0; i < ab->hw_params->ce_count; i++) {
+ if (ath12k_ce_get_attr_flags(ab, i) & CE_ATTR_DIS_INTR)
+ continue;
+
+ ce_pipe = &ab->ce.ce_pipe[i];
+ desc = msi_desc[vec_idx];
+ INIT_WORK(&ce_pipe->intr_wq, ath12k_pci_ce_workqueue);
+ irq_idx = ATH12K_MSI_IRQ_CE0_OFFSET + i;
+
+ scnprintf(ce_pipe->irq_name, sizeof(ce_pipe->irq_name),
+ "pcic%u_wlan_ce_%u", userpd_id, i);
+ ret = request_irq(desc->irq, ath12k_pcic_ce_interrupt_handler,
+ IRQF_SHARED, ce_pipe->irq_name, ce_pipe);
+ if (ret) {
+ ath12k_warn(ab, "failed to request irq %d: %d\n", irq_idx, ret);
+ ath12k_pci_free_ce_irq(ab, i);
+ return ret;
+ }
+
+ ab->irq_num[irq_idx] = desc->irq;
+ ath12k_pcic_ce_irq_disable(ab, i);
+ vec_idx = (vec_idx + 1) % num_msi;
+
+ if (!msi_info_captured) {
+ ab->msi.addr_lo = desc->msg.address_lo;
+ ab->msi.addr_hi = desc->msg.address_hi;
+ msi_info_captured = true;
+ }
+ }
+
+ return 0;
+}
+
+static void ath12k_msi_msg_handler(struct msi_desc *desc, struct msi_msg *msg)
+{
+ desc->msg.address_lo = msg->address_lo;
+ desc->msg.address_hi = msg->address_hi;
+ desc->msg.data = msg->data;
+}
+
+static int ath12k_pcic_request_msi_irqs(struct ath12k_base *ab, int base_vector,
+ int num_vectors,
+ int (*irq_config)(struct ath12k_base *ab,
+ struct msi_desc **msi_desc,
+ int num_msi))
+{
+ struct msi_desc *msi_vecs[ATH12K_MAX_MSI_VECTOR];
+ struct platform_device *pdev = ab->pdev;
+ struct msi_desc *msi_desc;
+ int num_msi = 0, ret;
+
+ guard(msi_descs_lock)(&pdev->dev);
+
+ msi_for_each_desc(msi_desc, &pdev->dev, MSI_DESC_ALL) {
+ if (msi_desc->msi_index < base_vector ||
+ msi_desc->msi_index >= (num_vectors + base_vector))
+ continue;
+
+ if (num_msi >= ATH12K_MAX_MSI_VECTOR)
+ return -EOVERFLOW;
+
+ msi_vecs[num_msi++] = msi_desc;
+ }
+
+ if (!num_msi)
+ return -EINVAL;
+
+ ret = irq_config(ab, msi_vecs, num_msi);
+ if (ret) {
+ ath12k_warn(ab, "failed to config irq %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+int ath12k_pcic_config_irq(struct ath12k_base *ab)
+{
+ int user_base_data, base_vector, num_vectors;
+ struct platform_device *pdev = ab->pdev;
+ int ret;
+
+ ab->msi.config = &ath12k_msi_config[ATH12K_MSI_CONFIG_IPCI];
+
+ ret = platform_device_msi_init_and_alloc_irqs(&pdev->dev,
+ ab->msi.config->total_vectors,
+ ath12k_msi_msg_handler);
+ if (ret)
+ return ret;
+
+ ret = ath12k_pci_get_user_msi_assignment(ab, "CE", &num_vectors,
+ &user_base_data,
+ &base_vector);
+ if (ret)
+ goto free_msi;
+
+ ret = ath12k_pcic_request_msi_irqs(ab, base_vector, num_vectors,
+ ath12k_pcic_ce_irq_config);
+ if (ret) {
+ ath12k_err(ab, "failed to config CE irq\n");
+ goto free_msi;
+ }
+
+ set_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags);
+ return 0;
+
+free_msi:
+ platform_device_msi_free_irqs_all(&pdev->dev);
+ return ret;
+}
+
+void ath12k_pcic_free_irq(struct ath12k_base *ab)
+{
+ struct platform_device *pdev = ab->pdev;
+
+ ath12k_pci_free_ce_irq(ab, ab->hw_params->ce_count);
+ platform_device_msi_free_irqs_all(&pdev->dev);
+}
diff --git a/drivers/net/wireless/ath/ath12k/pcic.h b/drivers/net/wireless/ath/ath12k/pcic.h
index f77091927039..7b6c55043618 100644
--- a/drivers/net/wireless/ath/ath12k/pcic.h
+++ b/drivers/net/wireless/ath/ath12k/pcic.h
@@ -19,4 +19,6 @@ int ath12k_pcic_cmem_write32(struct ath12k_base *ab, u32 addr,
u32 value);
int ath12k_pcic_cmem_read32(struct ath12k_base *ab, u32 addr, u32 *value);
void ath12k_pcic_config_static_window(struct ath12k_base *ab);
+int ath12k_pcic_config_irq(struct ath12k_base *ab);
+void ath12k_pcic_free_irq(struct ath12k_base *ab);
#endif /* _ATH12K_PCIC_H */
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 11/17] wifi: ath12k: Add platform MSI support for CE
2026-10-08 10:24 ` [PATCH ath-next 11/17] wifi: ath12k: Add platform MSI support for CE Aaradhana Sahu
@ 2026-10-08 10:41 ` sashiko-bot
2026-10-13 11:00 ` Aaradhana Sahu
0 siblings, 1 reply; 30+ messages in thread
From: sashiko-bot @ 2026-10-08 10:41 UTC (permalink / raw)
To: Aaradhana Sahu; +Cc: conor+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Resource leak of non-devm MSIs and IRQs on ath12k_ahb_probe() error paths
--
commit ad41050e8b81bf8d1dd6e4fe6253604d235fd347
Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
wifi: ath12k: Add platform MSI support for CE
This commit adds support for configuring Copy Engine (CE) interrupts
through platform MSI on hybrid AHB devices like the QCN6432. It introduces
an IPCI MSI configuration, allocates MSI vectors from the platform MSI
domain, and registers CE interrupt handlers using the allocated vectors.
> diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
> --- a/drivers/net/wireless/ath/ath12k/pcic.c
> +++ b/drivers/net/wireless/ath/ath12k/pcic.c
[ ... ]
> @@ -154,3 +155,157 @@ void ath12k_pcic_write32(struct ath12k_base *ab, u32 offset, u32 value)
[ ... ]
> +static int ath12k_pcic_ce_irq_config(struct ath12k_base *ab,
> + struct msi_desc **msi_desc, int num_msi)
> +{
[ ... ]
> + scnprintf(ce_pipe->irq_name, sizeof(ce_pipe->irq_name),
> + "pcic%u_wlan_ce_%u", userpd_id, i);
> + ret = request_irq(desc->irq, ath12k_pcic_ce_interrupt_handler,
> + IRQF_SHARED, ce_pipe->irq_name, ce_pipe);
[Severity: High]
Does this leak the requested IRQ on the probe error path?
Since request_irq() is used here instead of devm_request_irq(), it requires
explicit cleanup. This function is called by ath12k_ahb_config_irq() during
ath12k_ahb_probe(). If a subsequent initialization step in probe fails
(such as arch_init or core_init), the error path jumps to labels like
err_deinit_arch or err_core_free.
However, the error path in ath12k_ahb_probe() does not appear to call
ath12k_ahb_disable_irq() or ath12k_pcic_free_irq() to free these IRQs.
If the device context (ab) is subsequently freed by ath12k_core_free()
while the interrupt handlers remain registered, could this lead to a
use-after-free panic if an interrupt fires?
> + if (ret) {
> + ath12k_warn(ab, "failed to request irq %d: %d\n", irq_idx, ret);
> + ath12k_pci_free_ce_irq(ab, i);
> + return ret;
> + }
[ ... ]
> +int ath12k_pcic_config_irq(struct ath12k_base *ab)
> +{
> + int user_base_data, base_vector, num_vectors;
> + struct platform_device *pdev = ab->pdev;
> + int ret;
> +
> + ab->msi.config = &ath12k_msi_config[ATH12K_MSI_CONFIG_IPCI];
> +
> + ret = platform_device_msi_init_and_alloc_irqs(&pdev->dev,
> + ab->msi.config->total_vectors,
> + ath12k_msi_msg_handler);
[Severity: High]
Similarly, does this platform MSI domain allocation get leaked on the
ath12k_ahb_probe() error path?
platform_device_msi_init_and_alloc_irqs() is not devres managed, so the
domain must be explicitly destroyed via platform_device_msi_free_irqs_all().
Because ath12k_ahb_probe() does not call the corresponding free routine when
it encounters an error after this point, are these MSI vectors leaked?
> + if (ret)
> + return ret;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-mpp_bringup-v1-0-2c5797b5e4ac@oss.qualcomm.com?part=11
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 11/17] wifi: ath12k: Add platform MSI support for CE
2026-10-08 10:41 ` sashiko-bot
@ 2026-10-13 11:00 ` Aaradhana Sahu
0 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-13 11:00 UTC (permalink / raw)
To: sashiko-reviews; +Cc: conor+dt, robh, devicetree
On 10/8/2026 4:11 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Resource leak of non-devm MSIs and IRQs on ath12k_ahb_probe() error paths
> --
>
> commit ad41050e8b81bf8d1dd6e4fe6253604d235fd347
> Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
>
> wifi: ath12k: Add platform MSI support for CE
>
> This commit adds support for configuring Copy Engine (CE) interrupts
> through platform MSI on hybrid AHB devices like the QCN6432. It introduces
> an IPCI MSI configuration, allocates MSI vectors from the platform MSI
> domain, and registers CE interrupt handlers using the allocated vectors.
>
>> diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
>> --- a/drivers/net/wireless/ath/ath12k/pcic.c
>> +++ b/drivers/net/wireless/ath/ath12k/pcic.c
> [ ... ]
>> @@ -154,3 +155,157 @@ void ath12k_pcic_write32(struct ath12k_base *ab, u32 offset, u32 value)
> [ ... ]
>> +static int ath12k_pcic_ce_irq_config(struct ath12k_base *ab,
>> + struct msi_desc **msi_desc, int num_msi)
>> +{
> [ ... ]
>> + scnprintf(ce_pipe->irq_name, sizeof(ce_pipe->irq_name),
>> + "pcic%u_wlan_ce_%u", userpd_id, i);
>> + ret = request_irq(desc->irq, ath12k_pcic_ce_interrupt_handler,
>> + IRQF_SHARED, ce_pipe->irq_name, ce_pipe);
>
> [Severity: High]
> Does this leak the requested IRQ on the probe error path?
>
> Since request_irq() is used here instead of devm_request_irq(), it requires
> explicit cleanup. This function is called by ath12k_ahb_config_irq() during
> ath12k_ahb_probe(). If a subsequent initialization step in probe fails
> (such as arch_init or core_init), the error path jumps to labels like
> err_deinit_arch or err_core_free.
>
> However, the error path in ath12k_ahb_probe() does not appear to call
> ath12k_ahb_disable_irq() or ath12k_pcic_free_irq() to free these IRQs.
> If the device context (ab) is subsequently freed by ath12k_core_free()
> while the interrupt handlers remain registered, could this lead to a
> use-after-free panic if an interrupt fires?
>
Thanks for pointing this out. I'll address this in the next version.
>> + if (ret) {
>> + ath12k_warn(ab, "failed to request irq %d: %d\n", irq_idx, ret);
>> + ath12k_pci_free_ce_irq(ab, i);
>> + return ret;
>> + }
> [ ... ]
>> +int ath12k_pcic_config_irq(struct ath12k_base *ab)
>> +{
>> + int user_base_data, base_vector, num_vectors;
>> + struct platform_device *pdev = ab->pdev;
>> + int ret;
>> +
>> + ab->msi.config = &ath12k_msi_config[ATH12K_MSI_CONFIG_IPCI];
>> +
>> + ret = platform_device_msi_init_and_alloc_irqs(&pdev->dev,
>> + ab->msi.config->total_vectors,
>> + ath12k_msi_msg_handler);
>
> [Severity: High]
> Similarly, does this platform MSI domain allocation get leaked on the
> ath12k_ahb_probe() error path?
>
> platform_device_msi_init_and_alloc_irqs() is not devres managed, so the
> domain must be explicitly destroyed via platform_device_msi_free_irqs_all().
> Because ath12k_ahb_probe() does not call the corresponding free routine when
> it encounters an error after this point, are these MSI vectors leaked?
>
Sure, I will address this in the next version.
>> + if (ret)
>> + return ret;
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH ath-next 12/17] wifi: ath12k: Enable MSI interrupt support for DP interrupt
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (10 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 11/17] wifi: ath12k: Add platform MSI support for CE Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:45 ` sashiko-bot
2026-10-08 10:24 ` [PATCH ath-next 13/17] wifi: ath12k: use CMEM write for PPT on hybrid bus devices Aaradhana Sahu
` (4 subsequent siblings)
16 siblings, 1 reply; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Configure and request external MSI interrupts for DP ring groups on the
QCN6432 platform.
Create a NAPI context for each active external interrupt group and
disable the corresponding IRQs while NAPI polling is in progress.
Re-enable the IRQs after completing the NAPI poll.
Handle allocation and cleanup of NAPI contexts and external IRQs during
configuration failure and driver removal. Also disable external DP
interrupts from the AHB IRQ disable path.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Co-developed-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/ahb.c | 1 +
drivers/net/wireless/ath/ath12k/core.h | 2 +
drivers/net/wireless/ath/ath12k/pci.c | 6 +-
drivers/net/wireless/ath/ath12k/pcic.c | 121 +++++++++++++++++++++++++++++++++
4 files changed, 129 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index 78367126f49f..892872f70b2f 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -558,6 +558,7 @@ static void ath12k_ahb_disable_irq(struct ath12k_base *ab)
}
ath12k_ahb_ce_irqs_disable(ab);
+ ath12k_ahb_ext_irq_disable(ab);
}
static void ath12k_ahb_ce_workqueue(struct work_struct *work)
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index 21332aeb0c22..bbbde9f05ea9 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -165,6 +165,7 @@ enum ath12k_hw_rev {
#define ATH12K_EXT_IRQ_NUM_MAX 16
#define ATH12K_MAX_TCL_RING_NUM 3
#define ATH12K_MAX_MSI_VECTOR 32
+#define ATH12K_EXT_IRQ_NAME_LEN 32
struct ath12k_ext_irq_grp {
struct ath12k_base *ab;
@@ -175,6 +176,7 @@ struct ath12k_ext_irq_grp {
bool napi_enabled;
struct napi_struct napi;
struct net_device *napi_ndev;
+ char irq_name[ATH12K_EXT_IRQ_NAME_LEN];
};
enum ath12k_smbios_cc_type {
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index a26fdb3c0ad2..4bb14a95aec9 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -348,11 +348,15 @@ void ath12k_pci_free_ext_irq(struct ath12k_base *ab, int num_ext_irq_grp)
for (i = 0; i < num_ext_irq_grp; i++) {
struct ath12k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i];
+ if (!irq_grp->napi_ndev)
+ continue;
+
for (j = 0; j < irq_grp->num_irq; j++)
free_irq(ab->irq_num[irq_grp->irqs[j]], irq_grp);
netif_napi_del(&irq_grp->napi);
free_netdev(irq_grp->napi_ndev);
+ irq_grp->napi_ndev = NULL;
}
}
@@ -1118,7 +1122,7 @@ void ath12k_pci_ext_irq_enable(struct ath12k_base *ab)
for (i = 0; i < ATH12K_EXT_IRQ_GRP_NUM_MAX; i++) {
struct ath12k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i];
- if (!irq_grp->napi_enabled) {
+ if (irq_grp->napi_ndev && !irq_grp->napi_enabled) {
napi_enable(&irq_grp->napi);
irq_grp->napi_enabled = true;
}
diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
index fea284c3707b..06178b4f20d1 100644
--- a/drivers/net/wireless/ath/ath12k/pcic.c
+++ b/drivers/net/wireless/ath/ath12k/pcic.c
@@ -181,6 +181,112 @@ static irqreturn_t ath12k_pcic_ce_interrupt_handler(int irq, void *arg)
return IRQ_HANDLED;
}
+static void ath12k_pcic_ext_grp_enable(struct ath12k_ext_irq_grp *irq_grp)
+{
+ int i;
+
+ for (i = 0; i < irq_grp->num_irq; i++)
+ enable_irq(irq_grp->ab->irq_num[irq_grp->irqs[i]]);
+}
+
+static int ath12k_pcic_ext_grp_napi_poll(struct napi_struct *napi, int budget)
+{
+ struct ath12k_ext_irq_grp *irq_grp = container_of(napi,
+ struct ath12k_ext_irq_grp,
+ napi);
+ struct ath12k_base *ab = irq_grp->ab;
+ int work_done;
+
+ work_done = ath12k_dp_service_srng(ab->dp, irq_grp, budget);
+ if (work_done < budget) {
+ if (likely(napi_complete_done(napi, work_done)))
+ ath12k_pcic_ext_grp_enable(irq_grp);
+ }
+
+ if (work_done > budget)
+ work_done = budget;
+
+ return work_done;
+}
+
+static int ath12k_pcic_ext_irq_config(struct ath12k_base *ab,
+ struct msi_desc **msi_desc, int num_msi)
+{
+ struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
+ struct ath12k_ext_irq_grp *irq_grp;
+ int j, i, k, vec_idx = 0, ret = 0;
+ u8 userpd_id = ab_ahb->userpd_id;
+ u32 num_irq, base_idx;
+ struct msi_desc *desc;
+
+ base_idx = ATH12K_MSI_IRQ_CE0_OFFSET + CE_COUNT_MAX;
+
+ for (i = 0; i < ATH12K_EXT_IRQ_GRP_NUM_MAX; i++) {
+ num_irq = 0;
+ desc = msi_desc[vec_idx];
+ irq_grp = &ab->ext_irq_grp[i];
+ irq_grp->ab = ab;
+ irq_grp->grp_id = i;
+
+ if (ab->hw_params->ring_mask->tx[i] ||
+ ab->hw_params->ring_mask->rx[i] ||
+ ab->hw_params->ring_mask->rx_err[i] ||
+ ab->hw_params->ring_mask->rx_wbm_rel[i] ||
+ ab->hw_params->ring_mask->reo_status[i] ||
+ ab->hw_params->ring_mask->host2rxdma[i] ||
+ ab->hw_params->ring_mask->rx_mon_dest[i]) {
+ num_irq = 1;
+ }
+
+ if (!num_irq)
+ continue;
+
+ irq_grp->napi_ndev = alloc_netdev_dummy(0);
+ if (!irq_grp->napi_ndev) {
+ ret = -ENOMEM;
+ goto fail_allocate;
+ }
+
+ netif_napi_add(irq_grp->napi_ndev, &irq_grp->napi,
+ ath12k_pcic_ext_grp_napi_poll);
+ irq_grp->num_irq = num_irq;
+ irq_grp->irqs[0] = base_idx + i;
+
+ for (j = 0; j < irq_grp->num_irq; j++) {
+ int irq_idx = irq_grp->irqs[j];
+
+ scnprintf(irq_grp->irq_name, sizeof(irq_grp->irq_name),
+ "pcic%u_wlan_dp_%u", userpd_id, i);
+ irq_set_status_flags(desc->irq, IRQ_DISABLE_UNLAZY);
+ ret = request_irq(desc->irq, ath12k_pci_ext_interrupt_handler,
+ IRQF_SHARED, irq_grp->irq_name, irq_grp);
+ if (ret) {
+ ath12k_err(ab, "failed request irq %d, for group %d : %d\n",
+ desc->irq, irq_grp->grp_id, ret);
+
+ for (k = 0; k < j; k++)
+ free_irq(ab->irq_num[irq_grp->irqs[k]], irq_grp);
+
+ netif_napi_del(&irq_grp->napi);
+ free_netdev(irq_grp->napi_ndev);
+ irq_grp->napi_ndev = NULL;
+ goto fail_allocate;
+ }
+
+ ab->irq_num[irq_idx] = desc->irq;
+ disable_irq_nosync(ab->irq_num[irq_idx]);
+ }
+
+ vec_idx = (vec_idx + 1) % num_msi;
+ }
+
+ return 0;
+
+fail_allocate:
+ ath12k_pci_free_ext_irq(ab, i);
+ return ret;
+}
+
static int ath12k_pcic_ce_irq_config(struct ath12k_base *ab,
struct msi_desc **msi_desc, int num_msi)
{
@@ -294,9 +400,23 @@ int ath12k_pcic_config_irq(struct ath12k_base *ab)
goto free_msi;
}
+ ret = ath12k_pci_get_user_msi_assignment(ab, "DP", &num_vectors,
+ &user_base_data, &base_vector);
+ if (ret)
+ goto free_ce_irq;
+
+ ret = ath12k_pcic_request_msi_irqs(ab, base_vector, num_vectors,
+ ath12k_pcic_ext_irq_config);
+ if (ret) {
+ ath12k_err(ab, "failed to config DP irq\n");
+ goto free_ce_irq;
+ }
+
set_bit(ATH12K_FLAG_MULTI_MSI_VECTORS, &ab->dev_flags);
return 0;
+free_ce_irq:
+ ath12k_pci_free_ce_irq(ab, ab->hw_params->ce_count);
free_msi:
platform_device_msi_free_irqs_all(&pdev->dev);
return ret;
@@ -307,5 +427,6 @@ void ath12k_pcic_free_irq(struct ath12k_base *ab)
struct platform_device *pdev = ab->pdev;
ath12k_pci_free_ce_irq(ab, ab->hw_params->ce_count);
+ ath12k_pci_free_ext_irq(ab, ATH12K_EXT_IRQ_GRP_NUM_MAX);
platform_device_msi_free_irqs_all(&pdev->dev);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 12/17] wifi: ath12k: Enable MSI interrupt support for DP interrupt
2026-10-08 10:24 ` [PATCH ath-next 12/17] wifi: ath12k: Enable MSI interrupt support for DP interrupt Aaradhana Sahu
@ 2026-10-08 10:45 ` sashiko-bot
2026-10-13 5:26 ` Aaradhana Sahu
0 siblings, 1 reply; 30+ messages in thread
From: sashiko-bot @ 2026-10-08 10:45 UTC (permalink / raw)
To: Aaradhana Sahu; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] ath12k: leaked IRQ disable depth when NAPI poll is aborted
- [Medium] ath12k: NAPI netdev and MSI IRQs leak on AHB probe failure
--
commit 05cbf53b4f5fb7b0ba611762ab10f0a7205ad37a
Author: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
wifi: ath12k: Enable MSI interrupt support for DP interrupt
Configure and request external MSI interrupts for DP ring groups on the
QCN6432 platform. Create a NAPI context for each active external interrupt
group and disable the corresponding IRQs while NAPI polling is in progress.
> diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
> index fea284c3707ba..06178b4f20d17 100644
> --- a/drivers/net/wireless/ath/ath12k/pcic.c
> +++ b/drivers/net/wireless/ath/ath12k/pcic.c
> @@ -181,6 +181,112 @@ static irqreturn_t ath12k_pcic_ce_interrupt_handler(int irq, void *arg)
> return IRQ_HANDLED;
> }
>
> +static void ath12k_pcic_ext_grp_enable(struct ath12k_ext_irq_grp *irq_grp)
> +{
> + int i;
> +
> + for (i = 0; i < irq_grp->num_irq; i++)
> + enable_irq(irq_grp->ab->irq_num[irq_grp->irqs[i]]);
> +}
> +
> +static int ath12k_pcic_ext_grp_napi_poll(struct napi_struct *napi, int budget)
> +{
> + struct ath12k_ext_irq_grp *irq_grp = container_of(napi,
> + struct ath12k_ext_irq_grp,
> + napi);
> + struct ath12k_base *ab = irq_grp->ab;
> + int work_done;
> +
> + work_done = ath12k_dp_service_srng(ab->dp, irq_grp, budget);
> + if (work_done < budget) {
> + if (likely(napi_complete_done(napi, work_done)))
> + ath12k_pcic_ext_grp_enable(irq_grp);
> + }
[Severity: Medium]
Can this leak the OS-level IRQ disable depth?
If napi_disable() interrupts a scheduled NAPI instance before it runs, or if
the poll uses its full budget, the networking core (__napi_poll in
net/core/dev.c) observes napi_disable_pending() and calls napi_complete()
directly without scheduling the driver's custom poll loop again.
Because the hardware IRQ handler (ath12k_pci_ext_interrupt_handler) uses
disable_irq_nosync() instead of masking the interrupt via device registers,
this skips the paired enable_irq() call here, leaving the OS-level IRQ disable
depth unbalanced.
The driver's teardown path (ath12k_pci_ext_irq_disable) further increments
the depth by blindly calling disable_irq_nosync(). Upon resume or
re-enablement, enable_irq() will only decrement the leaked depth by 1,
leaving the IRQ physically disabled permanently.
> +
> + if (work_done > budget)
> + work_done = budget;
> +
> + return work_done;
> +}
> +
> +static int ath12k_pcic_ext_irq_config(struct ath12k_base *ab,
> + struct msi_desc **msi_desc, int num_msi)
> +{
> + struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
> + struct ath12k_ext_irq_grp *irq_grp;
> + int j, i, k, vec_idx = 0, ret = 0;
> + u8 userpd_id = ab_ahb->userpd_id;
> + u32 num_irq, base_idx;
> + struct msi_desc *desc;
> +
> + base_idx = ATH12K_MSI_IRQ_CE0_OFFSET + CE_COUNT_MAX;
> +
> + for (i = 0; i < ATH12K_EXT_IRQ_GRP_NUM_MAX; i++) {
> + num_irq = 0;
> + desc = msi_desc[vec_idx];
> + irq_grp = &ab->ext_irq_grp[i];
> + irq_grp->ab = ab;
> + irq_grp->grp_id = i;
> +
> + if (ab->hw_params->ring_mask->tx[i] ||
> + ab->hw_params->ring_mask->rx[i] ||
> + ab->hw_params->ring_mask->rx_err[i] ||
> + ab->hw_params->ring_mask->rx_wbm_rel[i] ||
> + ab->hw_params->ring_mask->reo_status[i] ||
> + ab->hw_params->ring_mask->host2rxdma[i] ||
> + ab->hw_params->ring_mask->rx_mon_dest[i]) {
> + num_irq = 1;
> + }
> +
> + if (!num_irq)
> + continue;
> +
> + irq_grp->napi_ndev = alloc_netdev_dummy(0);
[Severity: Medium]
Does this dummy netdev and the associated MSI IRQs leak if probe fails?
For hybrid bus devices (e.g., QCN6432), ath12k_ahb_probe() delegates IRQ
configuration to ath12k_pcic_config_irq(), which explicitly allocates memory
for dummy NAPI netdevs (alloc_netdev_dummy()) and manually requests MSIs
without using devm_ variants.
If ath12k_ahb_probe() fails in subsequent initialization steps (such as
arch_init or ath12k_core_init), the error handling paths jump to labels
(err_deinit_arch, err_rproc_deconfigure) that appear to skip releasing these
resources by not calling ath12k_pcic_free_irq() or ath12k_ahb_disable_irq(),
leading to a permanent memory and IRQ leak on probe failure.
> + if (!irq_grp->napi_ndev) {
> + ret = -ENOMEM;
> + goto fail_allocate;
> + }
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-mpp_bringup-v1-0-2c5797b5e4ac@oss.qualcomm.com?part=12
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 12/17] wifi: ath12k: Enable MSI interrupt support for DP interrupt
2026-10-08 10:45 ` sashiko-bot
@ 2026-10-13 5:26 ` Aaradhana Sahu
0 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-13 5:26 UTC (permalink / raw)
To: sashiko-reviews; +Cc: devicetree, robh, conor+dt
On 10/8/2026 4:15 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] ath12k: leaked IRQ disable depth when NAPI poll is aborted
> - [Medium] ath12k: NAPI netdev and MSI IRQs leak on AHB probe failure
> --
>
> commit 05cbf53b4f5fb7b0ba611762ab10f0a7205ad37a
> Author: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
>
> wifi: ath12k: Enable MSI interrupt support for DP interrupt
>
> Configure and request external MSI interrupts for DP ring groups on the
> QCN6432 platform. Create a NAPI context for each active external interrupt
> group and disable the corresponding IRQs while NAPI polling is in progress.
>
>> diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
>> index fea284c3707ba..06178b4f20d17 100644
>> --- a/drivers/net/wireless/ath/ath12k/pcic.c
>> +++ b/drivers/net/wireless/ath/ath12k/pcic.c
>> @@ -181,6 +181,112 @@ static irqreturn_t ath12k_pcic_ce_interrupt_handler(int irq, void *arg)
>> return IRQ_HANDLED;
>> }
>>
>> +static void ath12k_pcic_ext_grp_enable(struct ath12k_ext_irq_grp *irq_grp)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < irq_grp->num_irq; i++)
>> + enable_irq(irq_grp->ab->irq_num[irq_grp->irqs[i]]);
>> +}
>> +
>> +static int ath12k_pcic_ext_grp_napi_poll(struct napi_struct *napi, int budget)
>> +{
>> + struct ath12k_ext_irq_grp *irq_grp = container_of(napi,
>> + struct ath12k_ext_irq_grp,
>> + napi);
>> + struct ath12k_base *ab = irq_grp->ab;
>> + int work_done;
>> +
>> + work_done = ath12k_dp_service_srng(ab->dp, irq_grp, budget);
>> + if (work_done < budget) {
>> + if (likely(napi_complete_done(napi, work_done)))
>> + ath12k_pcic_ext_grp_enable(irq_grp);
>> + }
>
> [Severity: Medium]
> Can this leak the OS-level IRQ disable depth?
>
> If napi_disable() interrupts a scheduled NAPI instance before it runs, or if
> the poll uses its full budget, the networking core (__napi_poll in
> net/core/dev.c) observes napi_disable_pending() and calls napi_complete()
> directly without scheduling the driver's custom poll loop again.
>
> Because the hardware IRQ handler (ath12k_pci_ext_interrupt_handler) uses
> disable_irq_nosync() instead of masking the interrupt via device registers,
> this skips the paired enable_irq() call here, leaving the OS-level IRQ disable
> depth unbalanced.
>
> The driver's teardown path (ath12k_pci_ext_irq_disable) further increments
> the depth by blindly calling disable_irq_nosync(). Upon resume or
> re-enablement, enable_irq() will only decrement the leaked depth by 1,
> leaving the IRQ physically disabled permanently.
>
This is handled by the ATH12K_FLAG_EXT_IRQ_ENABLED flag. The IRQ handler checks this flag
before disabling the IRQ and scheduling NAPI. During teardown, this flag is cleared using
test_and_clear_bit(), so subsequent IRQ handler calls will return without disabling the
IRQ or scheduling NAPI.
>> +
>> + if (work_done > budget)
>> + work_done = budget;
>> +
>> + return work_done;
>> +}
>> +
>> +static int ath12k_pcic_ext_irq_config(struct ath12k_base *ab,
>> + struct msi_desc **msi_desc, int num_msi)
>> +{
>> + struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
>> + struct ath12k_ext_irq_grp *irq_grp;
>> + int j, i, k, vec_idx = 0, ret = 0;
>> + u8 userpd_id = ab_ahb->userpd_id;
>> + u32 num_irq, base_idx;
>> + struct msi_desc *desc;
>> +
>> + base_idx = ATH12K_MSI_IRQ_CE0_OFFSET + CE_COUNT_MAX;
>> +
>> + for (i = 0; i < ATH12K_EXT_IRQ_GRP_NUM_MAX; i++) {
>> + num_irq = 0;
>> + desc = msi_desc[vec_idx];
>> + irq_grp = &ab->ext_irq_grp[i];
>> + irq_grp->ab = ab;
>> + irq_grp->grp_id = i;
>> +
>> + if (ab->hw_params->ring_mask->tx[i] ||
>> + ab->hw_params->ring_mask->rx[i] ||
>> + ab->hw_params->ring_mask->rx_err[i] ||
>> + ab->hw_params->ring_mask->rx_wbm_rel[i] ||
>> + ab->hw_params->ring_mask->reo_status[i] ||
>> + ab->hw_params->ring_mask->host2rxdma[i] ||
>> + ab->hw_params->ring_mask->rx_mon_dest[i]) {
>> + num_irq = 1;
>> + }
>> +
>> + if (!num_irq)
>> + continue;
>> +
>> + irq_grp->napi_ndev = alloc_netdev_dummy(0);
>
> [Severity: Medium]
> Does this dummy netdev and the associated MSI IRQs leak if probe fails?
>
> For hybrid bus devices (e.g., QCN6432), ath12k_ahb_probe() delegates IRQ
> configuration to ath12k_pcic_config_irq(), which explicitly allocates memory
> for dummy NAPI netdevs (alloc_netdev_dummy()) and manually requests MSIs
> without using devm_ variants.
>
> If ath12k_ahb_probe() fails in subsequent initialization steps (such as
> arch_init or ath12k_core_init), the error handling paths jump to labels
> (err_deinit_arch, err_rproc_deconfigure) that appear to skip releasing these
> resources by not calling ath12k_pcic_free_irq() or ath12k_ahb_disable_irq(),
> leading to a permanent memory and IRQ leak on probe failure.
>
Sure, I will address this in the next version.
>> + if (!irq_grp->napi_ndev) {
>> + ret = -ENOMEM;
>> + goto fail_allocate;
>> + }
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH ath-next 13/17] wifi: ath12k: use CMEM write for PPT on hybrid bus devices
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (11 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 12/17] wifi: ath12k: Enable MSI interrupt support for DP interrupt Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 14/17] wifi: ath12k: store and use MSI data per CE and DP interrupt group for QCN6432 Aaradhana Sahu
` (3 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
Use CMEM-specific write operations for Primary Page Table (PPT)
initialization on hybrid bus devices, which require special CMEM
access handling.
Propagate errors from CMEM writes during PPT initialization and
partner copy cache initialization. Abort MLO setup and perform
teardown if partner copy cache initialization fails.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/core.c | 7 +++++--
drivers/net/wireless/ath/ath12k/dp.c | 30 ++++++++++++++++++++++--------
drivers/net/wireless/ath/ath12k/dp.h | 2 +-
3 files changed, 28 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
index cc1c31e216bb..e9caa9216f77 100644
--- a/drivers/net/wireless/ath/ath12k/core.c
+++ b/drivers/net/wireless/ath/ath12k/core.c
@@ -1140,8 +1140,11 @@ static int ath12k_core_mlo_setup(struct ath12k_hw_group *ag)
if (ret)
return ret;
- for (i = 0; i < ag->num_devices; i++)
- ath12k_dp_partner_cc_init(ag->ab[i]);
+ for (i = 0; i < ag->num_devices; i++) {
+ ret = ath12k_dp_partner_cc_init(ag->ab[i]);
+ if (ret)
+ goto err_mlo_teardown;
+ }
ret = ath12k_mac_mlo_ready(ag);
if (ret)
diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
index 83f9edfabf69..6cf254b2d2a7 100644
--- a/drivers/net/wireless/ath/ath12k/dp.c
+++ b/drivers/net/wireless/ath/ath12k/dp.c
@@ -1307,8 +1307,8 @@ static int ath12k_dp_cmem_init(struct ath12k_base *ab,
enum ath12k_dp_desc_type type)
{
const struct ath12k_dp_profile_params *dp_params = &ab->profile_param->dp_params;
- u32 cmem_base;
- int i, start, end;
+ u32 cmem_base, val, addr;
+ int i, start, end, ret;
cmem_base = ab->qmi.dev_mem[ATH12K_QMI_DEVMEM_CMEM_INDEX].start;
@@ -1328,24 +1328,38 @@ static int ath12k_dp_cmem_init(struct ath12k_base *ab,
}
/* Write to PPT in CMEM */
- for (i = start; i < end; i++)
- ath12k_hif_write32(ab, cmem_base + ATH12K_PPT_ADDR_OFFSET(i),
- dp->spt_info[i].paddr >> ATH12K_SPT_4K_ALIGN_OFFSET);
+ for (i = start; i < end; i++) {
+ addr = cmem_base + ATH12K_PPT_ADDR_OFFSET(i);
+ val = dp->spt_info[i].paddr >> ATH12K_SPT_4K_ALIGN_OFFSET;
+
+ if (ab->hw_params->hybrid_bus_type) {
+ ret = ath12k_hif_cmem_write32(ab, addr, val);
+ if (ret)
+ return ret;
+ } else {
+ ath12k_hif_write32(ab, addr, val);
+ }
+ }
return 0;
}
-void ath12k_dp_partner_cc_init(struct ath12k_base *ab)
+int ath12k_dp_partner_cc_init(struct ath12k_base *ab)
{
struct ath12k_hw_group *ag = ab->ag;
- int i;
+ int i, ret;
for (i = 0; i < ag->num_devices; i++) {
if (ag->ab[i] == ab)
continue;
- ath12k_dp_cmem_init(ab, ath12k_ab_to_dp(ag->ab[i]), ATH12K_DP_RX_DESC);
+ ret = ath12k_dp_cmem_init(ab, ath12k_ab_to_dp(ag->ab[i]),
+ ATH12K_DP_RX_DESC);
+ if (ret)
+ return ret;
}
+
+ return 0;
}
static u32 ath12k_dp_get_num_spt_pages(struct ath12k_base *ab)
diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
index c53eac20b989..b3a00e7dbf56 100644
--- a/drivers/net/wireless/ath/ath12k/dp.h
+++ b/drivers/net/wireless/ath/ath12k/dp.h
@@ -731,7 +731,7 @@ ath12k_dp_rx_release_ring_size(const struct ath12k_dp_profile_params *p)
}
void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_link_vif *arvif);
-void ath12k_dp_partner_cc_init(struct ath12k_base *ab);
+int ath12k_dp_partner_cc_init(struct ath12k_base *ab);
int ath12k_dp_pdev_alloc(struct ath12k_base *ab);
void ath12k_dp_pdev_pre_alloc(struct ath12k *ar);
void ath12k_dp_pdev_free(struct ath12k_base *ab);
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 14/17] wifi: ath12k: store and use MSI data per CE and DP interrupt group for QCN6432
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (12 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 13/17] wifi: ath12k: use CMEM write for PPT on hybrid bus devices Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 15/17] wifi: ath12k: Derive QMI service instance ID per protection domain Aaradhana Sahu
` (2 subsequent siblings)
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Store MSI data values for each interrupt vector during configuration
and use them for ring setup on hybrid devices. Hybrid devices require
explicit MSI data values rather than calculated offsets.
Add ce_msi_data and dp_msi_data arrays to store values captured from
MSI descriptors. Use stored values for ring configuration on QCN6432,
ensuring hardware uses exact platform MSI allocated values.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Co-developed-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/ce.c | 7 ++++++-
drivers/net/wireless/ath/ath12k/core.h | 2 ++
drivers/net/wireless/ath/ath12k/dp.c | 9 +++++++--
drivers/net/wireless/ath/ath12k/pcic.c | 2 ++
4 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/ce.c b/drivers/net/wireless/ath/ath12k/ce.c
index c99e915e3885..cc8ed8451a2f 100644
--- a/drivers/net/wireless/ath/ath12k/ce.c
+++ b/drivers/net/wireless/ath/ath12k/ce.c
@@ -270,7 +270,12 @@ static void ath12k_ce_srng_msi_ring_params_setup(struct ath12k_base *ab, u32 ce_
ring_params->msi_addr = addr_lo;
ring_params->msi_addr |= (dma_addr_t)(((u64)addr_hi) << 32);
- ring_params->msi_data = (msi_data_idx % msi_data_count) + msi_data_start;
+
+ if (ab->hw_params->hybrid_bus_type)
+ ring_params->msi_data = ab->msi.ce_msi_data[ce_id];
+ else
+ ring_params->msi_data = (msi_data_idx % msi_data_count) + msi_data_start;
+
ring_params->flags |= HAL_SRNG_FLAGS_MSI_INTR;
}
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h
index bbbde9f05ea9..575139555dd7 100644
--- a/drivers/net/wireless/ath/ath12k/core.h
+++ b/drivers/net/wireless/ath/ath12k/core.h
@@ -1172,6 +1172,8 @@ struct ath12k_base {
u32 ep_base_data;
u32 addr_lo;
u32 addr_hi;
+ u32 ce_msi_data[CE_COUNT_MAX];
+ u32 dp_msi_data[ATH12K_EXT_IRQ_GRP_NUM_MAX];
} msi;
/* must be last */
diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c
index 6cf254b2d2a7..0f0800388935 100644
--- a/drivers/net/wireless/ath/ath12k/dp.c
+++ b/drivers/net/wireless/ath/ath12k/dp.c
@@ -225,8 +225,13 @@ static void ath12k_dp_srng_msi_setup(struct ath12k_base *ab,
ring_params->msi_addr = addr_lo;
ring_params->msi_addr |= (dma_addr_t)(((u64)addr_hi) << 32);
- ring_params->msi_data = (msi_group_number % msi_data_count)
- + msi_data_start;
+
+ if (ab->hw_params->hybrid_bus_type)
+ ring_params->msi_data = ab->msi.dp_msi_data[msi_group_number];
+ else
+ ring_params->msi_data = (msi_group_number % msi_data_count)
+ + msi_data_start;
+
ring_params->flags |= HAL_SRNG_FLAGS_MSI_INTR;
}
diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
index 06178b4f20d1..9fa727115f8d 100644
--- a/drivers/net/wireless/ath/ath12k/pcic.c
+++ b/drivers/net/wireless/ath/ath12k/pcic.c
@@ -274,6 +274,7 @@ static int ath12k_pcic_ext_irq_config(struct ath12k_base *ab,
}
ab->irq_num[irq_idx] = desc->irq;
+ ab->msi.dp_msi_data[i] = desc->msg.data;
disable_irq_nosync(ab->irq_num[irq_idx]);
}
@@ -317,6 +318,7 @@ static int ath12k_pcic_ce_irq_config(struct ath12k_base *ab,
}
ab->irq_num[irq_idx] = desc->irq;
+ ab->msi.ce_msi_data[i] = desc->msg.data;
ath12k_pcic_ce_irq_disable(ab, i);
vec_idx = (vec_idx + 1) % num_msi;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 15/17] wifi: ath12k: Derive QMI service instance ID per protection domain
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (13 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 14/17] wifi: ath12k: store and use MSI data per CE and DP interrupt group for QCN6432 Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device Aaradhana Sahu
2026-10-08 10:24 ` [PATCH ath-next 17/17] wifi: ath12k: Add QCN6432 AHB support Aaradhana Sahu
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu,
Sowmiya Sree Elavalagan
From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
IPQ5332 platform variants are supporting multiple Protection Domains
(PDs), each PD exposes its own instance of QMI services. The current
implementation uses a fixed qmi_service_ins_id from hw_params, which
results in multiple PDs sharing the same service instance ID.
Update ath12k_ahb_init_qmi_ce_config() to derive the QMI service
instance ID based on the user PD identifier. Offset the base
qmi_service_ins_id with (userpd_id - 1) to ensure each PD gets a
unique service instance.
This avoids QMI service instance conflicts and enables correct
operation on multi-PD targets.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/ahb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index 892872f70b2f..3872aeeb9ba7 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -542,12 +542,14 @@ static void ath12k_ahb_power_down(struct ath12k_base *ab, bool is_suspend)
static void ath12k_ahb_init_qmi_ce_config(struct ath12k_base *ab)
{
struct ath12k_qmi_ce_cfg *cfg = &ab->qmi.ce_cfg;
+ struct ath12k_ahb *ab_ahb = ath12k_ab_to_ahb(ab);
cfg->tgt_ce_len = ab->hw_params->target_ce_count;
cfg->tgt_ce = ab->hw_params->target_ce_config;
cfg->svc_to_ce_map_len = ab->hw_params->svc_to_ce_map_len;
cfg->svc_to_ce_map = ab->hw_params->svc_to_ce_map;
- ab->qmi.service_ins_id = ab->hw_params->qmi_service_ins_id;
+ ab->qmi.service_ins_id = ab->hw_params->qmi_service_ins_id +
+ (ab_ahb->userpd_id - ATH12K_AHB_USERPD_ID_0);
}
static void ath12k_ahb_disable_irq(struct ath12k_base *ab)
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (14 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 15/17] wifi: ath12k: Derive QMI service instance ID per protection domain Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
2026-10-08 10:43 ` sashiko-bot
2026-10-08 10:24 ` [PATCH ath-next 17/17] wifi: ath12k: Add QCN6432 AHB support Aaradhana Sahu
16 siblings, 1 reply; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
Currently, the userPD ID is hard-coded during AHB probe. This does not
work for multi-PD platforms where different devices can have different
userPD IDs even when they use the same compatible string.
Resolve the userPD ID based on the device address so that the correct ID
is assigned to each device. The userPD ID is used to determine the
firmware name and PAS ID for firmware authentication.
Also set the multi-PD support based on the AHB device descriptor.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/wifi7/ahb.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
index bff48b2fe124..86359ed1eeb2 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
@@ -16,6 +16,10 @@
#include "core.h"
#include "hal.h"
+static const struct ath12k_ahb_userpd_map ath12k_wifi7_ahb_userpd_map[] = {
+ { .io_start = 0x0c000000, .upd_id = ATH12K_AHB_USERPD_ID_0 },
+};
+
static const struct ath12k_ahb_desc ath12k_wifi7_ahb_desc[] = {
[ATH12K_HW_IPQ5332_HW10] = {
.hw_rev = ATH12K_HW_IPQ5332_HW10,
@@ -43,6 +47,26 @@ static const struct of_device_id ath12k_wifi7_ahb_of_match[] = {
MODULE_DEVICE_TABLE(of, ath12k_wifi7_ahb_of_match);
+static u32 ath12k_wifi7_ahb_get_userpd_id(struct ath12k_base *ab)
+{
+ const struct ath12k_ahb_userpd_map *map;
+ struct resource *res;
+ size_t i;
+
+ res = platform_get_resource(ab->pdev, IORESOURCE_MEM, 0);
+
+ for (i = 0; i < ARRAY_SIZE(ath12k_wifi7_ahb_userpd_map); i++) {
+ map = &ath12k_wifi7_ahb_userpd_map[i];
+
+ if (res) {
+ if (map->io_start == res->start)
+ return map->upd_id;
+ }
+ }
+
+ return 0;
+}
+
static int ath12k_wifi7_ahb_probe(struct platform_device *pdev)
{
const struct ath12k_ahb_desc *desc;
@@ -60,7 +84,8 @@ static int ath12k_wifi7_ahb_probe(struct platform_device *pdev)
ab->hw_rev = desc->hw_rev;
ab->hif.ops = desc->ops;
ab_ahb->scm_auth_enabled = desc->auth_enabled;
- ab_ahb->userpd_id = ATH12K_AHB_USERPD_ID_0;
+ ab_ahb->supports_multipd = desc->supports_multipd;
+ ab_ahb->userpd_id = ath12k_wifi7_ahb_get_userpd_id(ab);
if (!ab_ahb->userpd_id)
return -EOPNOTSUPP;
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device
2026-10-08 10:24 ` [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device Aaradhana Sahu
@ 2026-10-08 10:43 ` sashiko-bot
2026-10-12 9:30 ` Aaradhana Sahu
0 siblings, 1 reply; 30+ messages in thread
From: sashiko-bot @ 2026-10-08 10:43 UTC (permalink / raw)
To: Aaradhana Sahu; +Cc: conor+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] style: inefficient NULL check inside resource loop
--
commit 1ba3501c64845782d9fd054ea266b2485861b530
Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
wifi: ath12k: Resolve userPD ID per device
This commit resolves the userPD ID based on the device address rather than
hardcoding it during AHB probe, which is necessary for multi-PD platforms.
It also sets multi-PD support based on the AHB device descriptor.
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
> index bff48b2fe124d..86359ed1eeb2b 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
[ ... ]
> @@ -43,6 +47,26 @@ static const struct of_device_id ath12k_wifi7_ahb_of_match[] = {
>
> MODULE_DEVICE_TABLE(of, ath12k_wifi7_ahb_of_match);
>
> +static u32 ath12k_wifi7_ahb_get_userpd_id(struct ath12k_base *ab)
> +{
> + const struct ath12k_ahb_userpd_map *map;
> + struct resource *res;
> + size_t i;
> +
> + res = platform_get_resource(ab->pdev, IORESOURCE_MEM, 0);
> +
> + for (i = 0; i < ARRAY_SIZE(ath12k_wifi7_ahb_userpd_map); i++) {
> + map = &ath12k_wifi7_ahb_userpd_map[i];
> +
> + if (res) {
[Severity: Low]
This isn't a bug, but could the NULL check for res be moved outside the loop?
Since res is retrieved before the loop and does not change during the iteration
in ath12k_wifi7_ahb_get_userpd_id(), checking it on every pass is redundant.
Returning early if res is NULL might make this slightly cleaner.
> + if (map->io_start == res->start)
> + return map->upd_id;
> + }
> + }
> +
> + return 0;
> +}
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261008-mpp_bringup-v1-0-2c5797b5e4ac@oss.qualcomm.com?part=16
^ permalink raw reply [flat|nested] 30+ messages in thread* Re: [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device
2026-10-08 10:43 ` sashiko-bot
@ 2026-10-12 9:30 ` Aaradhana Sahu
0 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-12 9:30 UTC (permalink / raw)
To: sashiko-reviews; +Cc: conor+dt, robh, devicetree
On 10/8/2026 4:13 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] style: inefficient NULL check inside resource loop
> --
>
> commit 1ba3501c64845782d9fd054ea266b2485861b530
> Author: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
>
> wifi: ath12k: Resolve userPD ID per device
>
> This commit resolves the userPD ID based on the device address rather than
> hardcoding it during AHB probe, which is necessary for multi-PD platforms.
> It also sets multi-PD support based on the AHB device descriptor.
>
>> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
>> index bff48b2fe124d..86359ed1eeb2b 100644
>> --- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
>> +++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
>
> [ ... ]
>
>> @@ -43,6 +47,26 @@ static const struct of_device_id ath12k_wifi7_ahb_of_match[] = {
>>
>> MODULE_DEVICE_TABLE(of, ath12k_wifi7_ahb_of_match);
>>
>> +static u32 ath12k_wifi7_ahb_get_userpd_id(struct ath12k_base *ab)
>> +{
>> + const struct ath12k_ahb_userpd_map *map;
>> + struct resource *res;
>> + size_t i;
>> +
>> + res = platform_get_resource(ab->pdev, IORESOURCE_MEM, 0);
>> +
>> + for (i = 0; i < ARRAY_SIZE(ath12k_wifi7_ahb_userpd_map); i++) {
>> + map = &ath12k_wifi7_ahb_userpd_map[i];
>> +
>> + if (res) {
>
> [Severity: Low]
> This isn't a bug, but could the NULL check for res be moved outside the loop?
>
> Since res is retrieved before the loop and does not change during the iteration
> in ath12k_wifi7_ahb_get_userpd_id(), checking it on every pass is redundant.
> Returning early if res is NULL might make this slightly cleaner.
>
Thanks for the suggestion. I'll move the NULL check outside the loop and return
early if the resource is unavailable.
>> + if (map->io_start == res->start)
>> + return map->upd_id;
>> + }
>> + }
>> +
>> + return 0;
>> +}
>
^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH ath-next 17/17] wifi: ath12k: Add QCN6432 AHB support
2026-10-08 10:23 [PATCH ath-next 00/17] wifi: ath12k: Add support for QCN6432 Aaradhana Sahu
` (15 preceding siblings ...)
2026-10-08 10:24 ` [PATCH ath-next 16/17] wifi: ath12k: Resolve userPD ID per device Aaradhana Sahu
@ 2026-10-08 10:24 ` Aaradhana Sahu
16 siblings, 0 replies; 30+ messages in thread
From: Aaradhana Sahu @ 2026-10-08 10:24 UTC (permalink / raw)
To: Johannes Berg, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k, Aaradhana Sahu
Add AHB support for QCN6432 by adding its hardware descriptor and
device-tree compatible entry.
QCN6432 uses a hybrid bus where the CE memory is handled through the
PCI interface. Skip the CE remapping and cleanup in the AHB resource
initialization and deinitialization for hybrid bus devices.
Also add the UserPD mappings required for the QCN6432 devices.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Tested-on: QCN6432 hw1.0 AHB WLAN.WBE.1.6-01322-QCAHKSWPL_SILICONZ-1
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/ahb.c | 9 ++++++++-
drivers/net/wireless/ath/ath12k/wifi7/ahb.c | 11 +++++++++++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/ahb.c b/drivers/net/wireless/ath/ath12k/ahb.c
index 3872aeeb9ba7..04974a6b423d 100644
--- a/drivers/net/wireless/ath/ath12k/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/ahb.c
@@ -1210,6 +1210,9 @@ static int ath12k_ahb_resource_init(struct ath12k_base *ab)
ab->mem_len = resource_size(mem_res);
+ if (ab->hw_params->hybrid_bus_type)
+ return 0;
+
if (ab->hw_params->ce_remap) {
const struct ce_remap *ce_remap = ab->hw_params->ce_remap;
/* CE register space is moved out of WCSS and the space is not
@@ -1266,10 +1269,14 @@ static void ath12k_ahb_resource_deinit(struct ath12k_base *ab)
if (ab->mem)
devm_iounmap(ab->dev, ab->mem);
+ ab->mem = NULL;
+
+ if (ab->hw_params->hybrid_bus_type)
+ return;
+
if (ab->mem_ce)
iounmap(ab->mem_ce);
- ab->mem = NULL;
ab->mem_ce = NULL;
clk_disable_unprepare(ab_ahb->xo_clk);
diff --git a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
index 86359ed1eeb2..98e74bdf0112 100644
--- a/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
+++ b/drivers/net/wireless/ath/ath12k/wifi7/ahb.c
@@ -18,6 +18,8 @@
static const struct ath12k_ahb_userpd_map ath12k_wifi7_ahb_userpd_map[] = {
{ .io_start = 0x0c000000, .upd_id = ATH12K_AHB_USERPD_ID_0 },
+ { .io_start = 0x21e00000, .upd_id = ATH12K_AHB_USERPD_ID_1 },
+ { .io_start = 0x19e00000, .upd_id = ATH12K_AHB_USERPD_ID_2 },
};
static const struct ath12k_ahb_desc ath12k_wifi7_ahb_desc[] = {
@@ -33,6 +35,12 @@ static const struct ath12k_ahb_desc ath12k_wifi7_ahb_desc[] = {
.ops = &ath12k_ahb_hif_ops,
.supports_multipd = false,
},
+ [ATH12K_HW_QCN6432_HW10] = {
+ .hw_rev = ATH12K_HW_QCN6432_HW10,
+ .auth_enabled = true,
+ .ops = &ath12k_ahb_hif_ops_qcn6432,
+ .supports_multipd = true,
+ },
};
static const struct of_device_id ath12k_wifi7_ahb_of_match[] = {
@@ -42,6 +50,9 @@ static const struct of_device_id ath12k_wifi7_ahb_of_match[] = {
{ .compatible = "qcom,ipq5424-wifi",
.data = (void *)&ath12k_wifi7_ahb_desc[ATH12K_HW_IPQ5424_HW10],
},
+ { .compatible = "qcom,qcn6432-wifi",
+ .data = (void *)&ath12k_wifi7_ahb_desc[ATH12K_HW_QCN6432_HW10],
+ },
{ }
};
--
2.34.1
^ permalink raw reply related [flat|nested] 30+ messages in thread