Re: [PATCH net-next v6 05/10] r8152: fix up and down register settings for RTL8156/8156B/8157/8159

[sashiko-bot@kernel.org]

> The per-chip-family split was kept behaviour-neutral, so the new
> callbacks still carry the settings that the shared functions applied
> under tp->version range checks. Several of those were wrong or
> missing for the chips that now have functions of their own, and were
> invisible as long as one function served four chip families.
> 
> Per the datasheet:
> 
> - RTL8156/8156B need PLA_RCR1 BIT(3) cleared on up. The shared
>   function had this clear under "version >= RTL_VER_16", so the
>   RTL8156/8156B path never reached it.
> - RTL8156B (VER_13/15) need Clear_SDR enabled on up, which nothing
>   ever did for them.
> - RTL8157/8159 need USB_SPEED_OPTION's RG_PWRDN_EN and ALL_SPEED_OFF
>   cleared on up. The shared function had this under
> [ ... ]
> 
> Fixes: 195aae321c82 ("r8152: support new chips")
> Fixes: fd3c7d080df5 ("r8152: Add support for the RTL8157 hardware")
> Fixes: ad2a55b63b41 ("r8152: Add support for the RTL8159 chip")
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008081556.47901-1-nic_swsd@realtek.com?part=5