Re: [PATCH net-next v6 09/10] r8152: extract rtl_fc_pause_pkt_en() and apply it to RTL8156/8157/8159

[sashiko-bot@kernel.org]

> The flow-control configuration keeps the device from sending pause
> frames without limit. Only RTL8156B (VER_12/13/15) got the full
> sequence from r8156b_init(). RTL8156A (VER_10/11) toggled
> FC_PATCH_TASK in rtl8156_enable() without the FC timer and
> FLOW_CTRL_PATCH_OPT setup that has to precede it, and RTL8157/RTL8159
> (VER_16/17) got no flow-control configuration at all, so they could
> keep sending pause frames indefinitely.
> 
> Collect the per-family sequence into rtl_fc_pause_pkt_en() and call
> it for all of them.
> 
> - VER_10/11: the FC timer + FLOW_CTRL_PATCH_OPT sequence that
>   RTL8153B (VER_09) already runs from its pre_fw/post_fw hooks,
>   applied directly instead.
> 
> [ ... ]
> 
> Fixes: 195aae321c82 ("r8152: support new chips")
> Fixes: fd3c7d080df5 ("r8152: Add support for the RTL8157 hardware")
> Fixes: ad2a55b63b41 ("r8152: Add support for the RTL8159 chip")
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008081556.47901-1-nic_swsd@realtek.com?part=9