Re: [PATCH net-next v6 03/10] r8152: split RTL_VER_17 into QFN68 and QFN100 package variants

[sashiko-bot@kernel.org]

> RTL8159 is sold in QFN68 and QFN100 packages, and only QFN68 needs
> the u2phy backup-restore patch and enables UPS (in a later patch).
> There was previously no way to tell the two apart at runtime, since
> both used the same RTL_VER_17.
> 
> Split RTL_VER_17 into RTL_VER_17_QFN68 and RTL_VER_17_QFN100 and
> update every switch/case on RTL_VER_17 in the driver to handle both.
> Detect the package by reading the new PLA_PKG_DET register
> (0xdc48, masked with PKG_MASK = 0x1e) via a new __rtl_get_pkg_det()
> helper, called from __rtl_get_hw_ver() when the chip ID is 0x2020:
> pkg_det value 0x1e/0x1c selects QFN68, 0x18/0x1a selects QFN100, and
> any other value logs "Unknown package" and falls back to
> RTL_VER_UNKNOWN.
> 
> r8159_init() gains a QFN68-only write ("Enable u2phy backup restore
> patch", 0xb99c BIT(0)) that does not apply to QFN100.
> 
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008081556.47901-1-nic_swsd@realtek.com?part=3