Re: [PATCH net-next v4 5/6] eth: fbnic: report temperature and voltage alarms via hwmon

[sashiko-bot@kernel.org]

> Firmware reports the range a sensor has entered on every threshold
> crossing, including the one back into the normal range. Expose that as
> temp1_alarm and in0_alarm, so the alarm reflects a condition the
> hardware raised and an excursion that starts and ends between two sysfs
> reads is still caught. Each crossing wakes anything polling the
> attribute through hwmon_notify_event().
> 
> Each alarm is only visible if all of its thresholds are reported by the
> firmware. Voltage has no crit threshold, only min and max.
> 
> Firmware only reports a range when it changes, so a sensor already out of
> range when the driver attaches has nothing cached. The first alarm read
> resolves that via a sensor read, its response carrying the range.
> Old firmware that doesn't report a range leaves the alarm to be
> classified from the reading against the thresholds, with no range to
> notify on.
> 
> fbnic_hwmon_notify_event() runs from the mailbox IRQ, so it can race
> registration and teardown. Publish fbd->hwmon with WRITE_ONCE() only
> after a successful registration, clear it with WRITE_ONCE(NULL) followed
> by synchronize_irq() to drain any in-flight handler, and skip the
> notification when the read returns NULL.
> 
> Signed-off-by: Zinc Lim <limzhineng2@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014222225.2803660-1-limzhineng2@gmail.com?part=5