Re: [PATCH net-next v4 6/6] eth: fbnic: derive the alarm range on older firmware

[sashiko-bot@kernel.org]

> Firmware that predates range reporting uses the threshold event to flag
> that a limit was exceeded, with the attribute hardcoded to 1, rather than
> reporting which range the sensor entered. The range enum reserves that
> value as FBNIC_FW_TSENE_ALARM_DEPRECATED. It does not indicate which
> limit was crossed, so it is not cached and the alarm classifies a fresh
> reading on every sysfs read.
> 
> Such firmware re-arms the trip points around the range the reading
> landed in, so every crossing interrupts, including the one back to
> normal. The event carries the reading that tripped it, so derive the
> range from that, against the same capability response thresholds and
> boundaries firmware uses. The alarm then tracks crossings there too, and
> wakes anything polling the sysfs attribute.
> 
> An event can arrive before the capability response that carries those
> thresholds, since rx messages are parsed while polling for it. There is
> nothing to classify against yet, so the reading would come back as the
> normal range and stick there. Leave the range unknown and let the read
> path derive it once the thresholds are in.
> 
> Signed-off-by: Zinc Lim <limzhineng2@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014222225.2803660-1-limzhineng2@gmail.com?part=6