Re: [PATCH net-next v4 4/6] eth: fbnic: parse the alarm range reported by firmware

[sashiko-bot@kernel.org]

> Firmware reports which range a sensor is in: normal, below min, above
> max, above crit. It sends the range in an unsolicited event on every
> trip point crossing, including the crossing back into the normal range,
> and in the response to a sensor read. Parse both and keep the last
> reported range per sensor, so the driver holds a condition the hardware
> reported.
> 
> The range is cached from the mailbox thread in both cases, so an event
> and a read response cannot be applied out of the order firmware sent
> them. It is seeded alongside the rest of the sensor cache in
> fbnic_mbx_init(), before the mailbox interrupt is enabled, since an
> event can arrive as soon as it is.
> 
> Firmware predating range reporting sends ALARM_DEPRECATED for every
> threshold event and omits the range from the read response entirely.
> Neither is cached, as neither says which limit was crossed.
> 
> Subsequent patches in this series will consume the cached range.
> 
> Signed-off-by: Zinc Lim <limzhineng2@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014222225.2803660-1-limzhineng2@gmail.com?part=4