All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ahmed S. Darwish" <darwi@linutronix.de>,
	"Clark Williams" <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>
Cc: "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Frederic Weisbecker" <frederic@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Derek Barbosa" <debarbos@redhat.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@amutable.com>,
	"Daan De Meyer" <daan.j.demeyer@gmail.com>,
	"Luca Boccassi" <luca.boccassi@gmail.com>,
	linux-rt-devel@lists.linux.dev, debian-kernel@lists.debian.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 07/10] kconfig-checker: Introduce overlays schema
Date: Sat, 07 Nov 2026 09:20:29 +0000	[thread overview]
Message-ID: <sashiko-outbox-202762@kernel.org> (raw)
In-Reply-To: <20261106091922.7560-8-darwi@linutronix.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] kconfig-checker: overlay.yml example uses invalid expected value
  allow
--

commit a10c99db2994945ab80143ea62fe4f2801513046
Author: Ahmed S. Darwish <darwi@linutronix.de>

kconfig-checker: Introduce overlays schema

This commit introduces a JSON schema for kconfig-checker overlay files
that references base.yml without requiring expected and severity on every
rule.

> diff --git a/tools/kconfig-checker/schemas/overlay.yml b/tools/kconfig-checker/schemas/overlay.yml
> new file mode 100644
> index 0000000000000..4ac9a364a3441
> --- /dev/null
> +++ b/tools/kconfig-checker/schemas/overlay.yml
> @@ -0,0 +1,28 @@

[ ... ]

> +# and a custom-overlay.yml:
> +#
> +# rules:
> +#  - name: CONFIG_DRM
> +#    expected: allow

[Severity: Low]
Should this example use "expected: allowed" instead of "expected: allow"?
base.yml restricts expected to y, n, or allowed, so an overlay written
from this example fails schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106091922.7560-1-darwi@linutronix.de?part=7

  reply	other threads:[~2026-11-07  9:20 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  9:19 [PATCH v1 00/10] tools: Introduce a kernel configuration checker Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 01/10] kconfig-checker: Add schema for rule files Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09 12:40     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 02/10] kconfig-checker: Introduce PREEMPT_RT configuration rules Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 18:09     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 03/10] kconfig-checker: Add the configuration checker code Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 19:29     ` Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09 13:00     ` Ahmed S. Darwish
2026-11-12 22:56       ` Julian Braha
2026-11-06  9:19 ` [PATCH v1 04/10] kconfig: Introduce checkconfig target Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 20:07     ` Ahmed S. Darwish
2026-11-12 15:53       ` Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09  0:39     ` Nathan Chancellor
2026-11-09 13:18       ` Ahmed S. Darwish
2026-11-11  6:38         ` Nicolas Schier
2026-11-12 11:32           ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 05/10] Documentation: Describe kconfig-checker usage and design Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 06/10] kconfig-checker: Split schema to support component reuse Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 18:22     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 07/10] kconfig-checker: Introduce overlays schema Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot [this message]
2026-11-09 16:47     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 08/10] kconfig-checker: Add support for rule overlays Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 09/10] Documentation: Describe kconfig-checker overlays Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 16:50     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 10/10] kconfig: Introduce OVERLAY= for make checkconfig Ahmed S. Darwish
2026-11-11  6:38   ` Nicolas Schier
2026-11-12 11:45     ` Ahmed S. Darwish
2026-11-12 21:31       ` Ahmed S. Darwish
2026-11-08 18:59 ` [PATCH v1 00/10] tools: Introduce a kernel configuration checker Julian Braha
2026-11-09  0:37   ` Nathan Chancellor
2026-11-09 16:15     ` Ahmed S. Darwish
2026-11-09 16:52       ` Nathan Chancellor
2026-11-09 17:04         ` Ahmed S. Darwish
2026-11-09 15:49   ` Ahmed S. Darwish
2026-11-10 18:18     ` Julian Braha
2026-11-10 20:33       ` Ahmed S. Darwish
2026-11-11  6:38 ` Nicolas Schier
2026-11-12 12:36   ` Ahmed S. Darwish
2026-11-12 17:50     ` Nathan Chancellor
2026-11-12 19:14       ` Ahmed S. Darwish
2026-11-12 21:44         ` Nathan Chancellor
2026-11-12 23:14     ` Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-202762@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daan.j.demeyer@gmail.com \
    --cc=darwi@linutronix.de \
    --cc=debarbos@redhat.com \
    --cc=debian-kernel@lists.debian.org \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=luca.boccassi@gmail.com \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zbyszek@amutable.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.