Re: [PATCH v5 08/25] soundwire: amd: fix missing wake interrupt for ACP6.3 in POWER_OFF suspend

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] soundwire: amd: inaccurate Fixes: trailer in commit message
--

commit e0001eef73595d8c30441824baf09c46bbaf4fea
Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

> soundwire: amd: fix missing wake interrupt for ACP6.3 in POWER_OFF suspend
>
> On some OEM platforms based on ACP 6.3, with a SoundWire topology
> where the UAJ peripheral is on one instance and the speaker peripheral
> is on the other, wake events from the UAJ instance are silently lost
> every time it enters POWER_OFF runtime suspend (D3) while speaker
> playback keeps ACP in D0.
>
> On ACP6.3, unlike ACP7.0/7.1/7.2, there is no dedicated host wake
> interrupt path (no ACP_EXTERNAL_INTR_CNTL1 host wake mask bits and no
> PME wake mechanism). The wake event from a suspended SoundWire instance
> is delivered solely through the standard SoundWire interrupt bit in
> ACP_EXTERNAL_INTR_CNTL.
>
> In the POWER_OFF_MODE runtime suspend path, amd_deinit_sdw_manager()
> calls amd_disable_sdw_interrupts() which clears the SoundWire instance
> bit in ACP_EXTERNAL_INTR_CNTL. After this, the wake interrupt has no
> delivery path to the CPU.
>
> Fix this by re-enabling the SoundWire instance bit in
> ACP_EXTERNAL_INTR_CNTL after amd_deinit_sdw_manager() and
> amd_sdw_wake_enable() complete, when acp_rev is ACP63_PCI_REV_ID and
> wake_en_mask is set. The acp_sdw_lock mutex is held around the
> read-modify-write to prevent a race when both instances suspend or
> resume concurrently.
>
> Fixes: 86a4371b7697 ("soundwire: amd: fix for handling slave alerts after link is down")
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

[Severity: Low]
Does the Fixes: tag point to the right commit?  86a4371b7697 ("soundwire:
amd: fix for handling slave alerts after link is down") only added
cancel_work_sync() in amd_suspend() and did not touch
amd_suspend_runtime() or wake interrupt handling.

The AMD_SDW_POWER_OFF_MODE runtime suspend path calling
amd_deinit_sdw_manager() was introduced in 81ff58ff71ad ("soundwire: amd:
add runtime pm ops for AMD SoundWire manager driver"), and wake enablement
for that path was added in dcc48a73eae7 ("soundwire: amd: change the
soundwire wake enable/disable sequence").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107154659.3358223-1-Vijendar.Mukunda@amd.com?part=8