Re: [PATCH v5 16/25] soundwire: amd: pm_runtime guard in remove path

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] soundwire: amd: inaccurate Fixes tag in commit message for
  pm_runtime guard
--

commit 258769b3a1bdd79fbca74cfbf250109e984888bf
Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

> soundwire: amd: pm_runtime guard in remove path
>
> Guard pm_runtime_disable() so it is only called when runtime PM
> was actually enabled. amd_sdw_manager_start() calls pm_runtime_enable()
> only at the very end, after several fallible hardware init steps. If
> sdw_amd_startup() fails mid-loop (one manager started, the next fails
> before pm_runtime_enable()), sdw_amd_exit() triggers
> platform_device_unregister() for all managers. Calling
> pm_runtime_disable() on the partially-started manager finds
> disable_depth already at its initial value of 1, silently increments it
> to 2 and returns without a warning, so a later pm_runtime_enable() would
> only bring it back to 1 and leave runtime PM disabled. Use
> pm_runtime_enabled() to skip the call when it was never paired with an
> enable.
>
> Fixes: f93b697ed98e ("soundwire: amd: cancel pending slave status handling workqueue during remove sequence")
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

[Severity: Low]
Is the Fixes tag pointing to the right commit?

Commit f93b697ed98e ("soundwire: amd: cancel pending slave status handling
workqueue during remove sequence") only added cancel_work_sync() to
amd_sdw_manager_remove().  The unconditional pm_runtime_disable() in
amd_sdw_manager_remove() was introduced in 81ff58ff71ad ("soundwire: amd: add
runtime pm ops for AMD SoundWire manager driver"), and the synchronous
sdw_amd_startup() / amd_sdw_manager_start() sequence described here was added
in ed5e8741b8db ("soundwire: amd: refactor amd soundwire manager device node
creation").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107154659.3358223-1-Vijendar.Mukunda@amd.com?part=16