Re: [PATCH v5 05/25] soundwire: amd: fix missing wake interrupt and group wake-arming calls in runtime suspend

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] soundwire: amd: wrong Fixes trailer in amd_suspend_runtime()
  wake fix
--

commit 969fd0aabc344fd522f022214936cf6f2b366440
Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

> soundwire: amd: fix missing wake interrupt and group wake-arming calls in runtime suspend
>
> In amd_suspend_runtime() POWER_OFF_MODE, amd_sdw_wake_enable() was called
> before amd_deinit_sdw_manager(), causing the wake IRQ mask to be silently
> overwritten.
>
> amd_deinit_sdw_manager() calls amd_disable_sdw_interrupts() which writes
> 0x00 to ACP_SW_STATE_CHANGE_STATUS_MASK_8TO11, wiping
> AMD_SDW_WAKE_INTR_MASK (BIT(16)) set by amd_sdw_wake_enable(). Move
> amd_sdw_wake_enable() to after amd_deinit_sdw_manager() so the wake mask
> is armed after the interrupt-disable sequence and cannot be clobbered.
>
> Move amd_sdw_host_wake_enable() after amd_deinit_sdw_manager() as well,
> grouping both wake-arming calls together after the interrupt-disable
> sequence.
>
> Fixes: 86a4371b7697 ("soundwire: amd: fix for handling slave alerts after link is down")
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

[Severity: Low]
86a4371b7697 ("soundwire: amd: fix for handling slave alerts after link is
down") only added cancel_work_sync() calls to amd_suspend() and did not
touch amd_suspend_runtime() or wake interrupt masking.

The amd_sdw_wake_enable() call in the AMD_SDW_POWER_OFF_MODE branch of
amd_suspend_runtime() was placed before amd_deinit_sdw_manager() by
dcc48a73eae7 ("soundwire: amd: change the soundwire wake enable/disable
sequence").  Should the Fixes: tag point to that commit instead:

  Fixes: dcc48a73eae7 ("soundwire: amd: change the soundwire wake enable/disable sequence")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107154659.3358223-1-Vijendar.Mukunda@amd.com?part=5