From: sashiko-bot@kernel.org
To: "Dapeng Mi" <dapeng1.mi@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [Patch v2 2/5] perf c2c: Fix top-level histogram ownership check
Date: Mon, 09 Nov 2026 00:55:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-204263@kernel.org> (raw)
In-Reply-To: <20261109004402.1403713-3-dapeng1.mi@linux.intel.com>
> The function set_node_width() incorrectly determined whether a c2c
> histogram entry belonged to the top-level cacheline view by checking
> if &c2c.hists equals c2c_he->hists.
>
> This comparison is always false for top-level entries because
> c2c_he->hists is only assigned for lazily-created sub-histograms in
> he__get_c2c_hists(). Top-level entries are instead stored under
> he->hists, which points to the embedded struct hists inside c2c.hists.
>
> Add a dedicated helper, c2c_he__is_main_hist(), to check whether a
> c2c_hist_entry belongs to the top-level histogram tree and use it to
> update the node width accordingly for top-level cachelines view or
> per-cacheline view.
>
> Fixes: 7f834c2e84bb ("perf c2c report: Display node for cacheline address")
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109004402.1403713-1-dapeng1.mi@linux.intel.com?part=2
next prev parent reply other threads:[~2026-11-09 0:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 0:43 [Patch v2 0/5] perf: fix test error and improve c2c memory-region display Dapeng Mi
2026-11-09 0:43 ` [Patch v2 1/5] perf tests: Skip zero sample IP in object-code reading test Dapeng Mi
2026-11-09 0:55 ` sashiko-bot
2026-11-09 0:43 ` [Patch v2 2/5] perf c2c: Fix top-level histogram ownership check Dapeng Mi
2026-11-09 0:55 ` sashiko-bot [this message]
2026-11-09 0:44 ` [Patch v2 3/5] perf c2c: Show memory region in the per-cacheline view Dapeng Mi
2026-11-09 0:59 ` sashiko-bot
2026-11-09 0:44 ` [Patch v2 4/5] perf c2c: Show all memory regions in the region column Dapeng Mi
2026-11-09 0:59 ` sashiko-bot
2026-11-09 0:44 ` [Patch v2 5/5] perf c2c: Rename "Region" column to "Range" for consistency Dapeng Mi
2026-11-09 1:09 ` sashiko-bot
2026-11-09 1:32 ` Mi, Dapeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204263@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dapeng1.mi@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.