From: sashiko-bot@kernel.org
To: "Dapeng Mi" <dapeng1.mi@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [Patch v2 3/5] perf c2c: Show memory region in the per-cacheline view
Date: Mon, 09 Nov 2026 00:59:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-204267@kernel.org> (raw)
In-Reply-To: <20261109004402.1403713-4-dapeng1.mi@linux.intel.com>
> The memory-region column is currently displayed only in the top-level
> cacheline view; it is missing from the child per-cacheline view.
>
> Show the memory region in the per-cacheline view as well so the display
> is complete and consistent.
>
> For example, the per-cacheline view now shows entries such as:
>
> Cacheline 0xff11002f7ef47a00
> RmtHitm LclHitm L1 Hit L1 Miss N/A Off Region Node PA cnt
> 100.00% 0.00% 0.00% 0.00% 0.00% 0x10 Mem-0 0 1
>
> Also move the c2c.show_mem_region assignment before setup_coalesce() so
> the per-cacheline header is generated with the correct region layout.
>
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109004402.1403713-1-dapeng1.mi@linux.intel.com?part=3
next prev parent reply other threads:[~2026-11-09 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 0:43 [Patch v2 0/5] perf: fix test error and improve c2c memory-region display Dapeng Mi
2026-11-09 0:43 ` [Patch v2 1/5] perf tests: Skip zero sample IP in object-code reading test Dapeng Mi
2026-11-09 0:55 ` sashiko-bot
2026-11-09 0:43 ` [Patch v2 2/5] perf c2c: Fix top-level histogram ownership check Dapeng Mi
2026-11-09 0:55 ` sashiko-bot
2026-11-09 0:44 ` [Patch v2 3/5] perf c2c: Show memory region in the per-cacheline view Dapeng Mi
2026-11-09 0:59 ` sashiko-bot [this message]
2026-11-09 0:44 ` [Patch v2 4/5] perf c2c: Show all memory regions in the region column Dapeng Mi
2026-11-09 0:59 ` sashiko-bot
2026-11-09 0:44 ` [Patch v2 5/5] perf c2c: Rename "Region" column to "Range" for consistency Dapeng Mi
2026-11-09 1:09 ` sashiko-bot
2026-11-09 1:32 ` Mi, Dapeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204267@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dapeng1.mi@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.