From: sashiko-bot@kernel.org
To: "Gabriel Gama" <operatingsystemsdepression@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH 5/6] drm/gma500: Propagate SGX MMU setup and GEM pin failures
Date: Mon, 09 Nov 2026 06:06:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-204483@kernel.org> (raw)
In-Reply-To: <20261109055451.17458-6-operatingsystemsdepression@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/gma500: missing Fixes trailer for MMU error checks
--
commit 781534e30915fea9a7d73d13c97f11a95323ad77
Author: Gabriel Gama <operatingsystemsdepression@gmail.com>
> drm/gma500: Propagate SGX MMU setup and GEM pin failures
>
> Check the GEM GPU address and perform transactional MMU insertion before
> changing cache attributes or publishing the GTT mapping. On failure,
> release temporary pages without publishing a pin and return the error.
>
> Propagate stolen-memory mapping failures through probe cleanup before
> installing a hardware context. Existing cache-attribute error handling
> is unchanged. This depends on the preceding rollback fix.
>
> Signed-off-by: Gabriel Gama <operatingsystemsdepression@gmail.com>
[Severity: Low]
Since this fixes the unchecked psb_mmu_insert_pages() and
psb_mmu_insert_pfn_sequence() calls, should the commit message include a
Fixes tag?
Fixes: ae012bdc5799 ("drm/gma500: Hook up the MMU")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109055451.17458-1-operatingsystemsdepression@gmail.com?part=5
next prev parent reply other threads:[~2026-11-09 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 5:54 [RFC PATCH 0/6] drm/gma500: prepare GEM and MMU for 3D rendering and hybrid 2D Gabriel Gama
2026-11-09 5:54 ` [RFC PATCH 1/6] drm/gma500: use the common dumb-buffer size helper Gabriel Gama
2026-11-09 5:54 ` [RFC PATCH 2/6] drm/gma500: do not underflow an unpinned GEM object Gabriel Gama
2026-11-09 5:54 ` [RFC PATCH 3/6] drm/gma500: Fix SGX page-table cache-flush mapping lifetime Gabriel Gama
2026-11-09 6:00 ` sashiko-bot
2026-11-09 5:54 ` [RFC PATCH 4/6] drm/gma500: Make SGX MMU insertion checked and transactional Gabriel Gama
2026-11-09 5:54 ` [RFC PATCH 5/6] drm/gma500: Propagate SGX MMU setup and GEM pin failures Gabriel Gama
2026-11-09 6:06 ` sashiko-bot [this message]
2026-11-09 5:54 ` [RFC PATCH 6/6] drm/gma500: Add software-only KUnit coverage for SGX page tables Gabriel Gama
2026-11-09 6:07 ` sashiko-bot
2026-11-09 6:26 ` Operating System's Depression
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204483@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=operatingsystemsdepression@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.