From: sashiko-bot@kernel.org
To: "Zhengping Zhang" <zhengping.zhang@airoha.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 01/12] pinctrl: airoha: fix setting of GPIO direction
Date: Tue, 10 Nov 2026 09:53:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-206812@kernel.org> (raw)
In-Reply-To: <20261110094339.749110-2-zhengping.zhang@airoha.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] pinctrl: airoha: missing Fixes: trailer on GPIO direction fix
--
commit 6dcec8340cfdb81d9b7f8c972e7a3451fe15d376
Author: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> pinctrl: airoha: fix setting of GPIO direction
>
> The GPIO_CTRL registers have two bits per GPIO where the values 0x2 and
> 0x3 are reserved. It can happen that both bits in GPIO_CTRL of a GPIO
> are set when the pinctrl driver is probed (e.g. modified by bootloader),
> but the current code just clears the LSB. Thus when switching a certain
> GPIO to output, the updated GPIO_CTRL register can contain the reserved
> value 0x2 for that GPIO. This can result in not driving the GPIO pin at
> all.
>
> Always clear both bits per GPIO and just set the LSB when the GPIO is
> configured for output.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Signed-off-by: Zhengping Zhang <zhengping.zhang@airoha.com>
[Severity: Low]
Since this fixes the single-bit GPIO_CTRL mask introduced in
1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC") and later
moved into airoha_gpio_set_direction() by 62b1dd7eeaca ("pinctrl: airoha:
add set_direction() helper for gpio_chip"), should it include a Fixes:
tag?
Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110094339.749110-1-zhengping.zhang@airoha.com?part=1
next prev parent reply other threads:[~2026-11-10 9:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 9:43 [PATCH 00/12] pinctrl: airoha: configure GPIO muxes explicitly and fix pad mappings Zhengping Zhang
2026-11-10 9:43 ` [PATCH 01/12] pinctrl: airoha: fix setting of GPIO direction Zhengping Zhang
2026-11-10 9:53 ` sashiko-bot [this message]
2026-11-10 9:43 ` [PATCH 02/12] pinctrl: airoha: configure pin muxes on GPIO requests Zhengping Zhang
2026-11-10 10:14 ` sashiko-bot
2026-11-10 9:43 ` [PATCH 03/12] dt-bindings: pinctrl: airoha: describe all EN7581 GPIO mux groups Zhengping Zhang
2026-11-10 9:43 ` [PATCH 04/12] pinctrl: airoha: an7581: fix PHY LED GPIO group assignments Zhengping Zhang
2026-11-10 9:43 ` [PATCH 05/12] pinctrl: airoha: an7581: select force GPIO mode on GPIO requests Zhengping Zhang
2026-11-10 10:00 ` sashiko-bot
2026-11-10 9:43 ` [PATCH 06/12] dt-bindings: pinctrl: airoha: describe all AN7583 GPIO mux groups Zhengping Zhang
2026-11-10 9:43 ` [PATCH 07/12] pinctrl: airoha: an7583: fix SPI pin mux config Zhengping Zhang
2026-11-10 9:43 ` [PATCH 08/12] pinctrl: airoha: an7583: fix eMMC " Zhengping Zhang
2026-11-10 9:43 ` [PATCH 09/12] pinctrl: airoha: an7583: use force GPIO mode for GPIO requests Zhengping Zhang
2026-11-10 9:56 ` sashiko-bot
2026-11-10 9:43 ` [PATCH 10/12] dt-bindings: pinctrl: airoha: describe all EN7523 GPIO mux groups Zhengping Zhang
2026-11-10 9:43 ` [PATCH 11/12] pinctrl: airoha: en7523: use force GPIO mode for GPIO requests Zhengping Zhang
2026-11-10 9:43 ` [PATCH 12/12] MAINTAINERS: add myself as Airoha pinctrl co-maintainer Zhengping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206812@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhengping.zhang@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.