From: sashiko-bot@kernel.org
To: "Damon Ding" <damon.ding@rock-chips.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v6 12/18] drm/rockchip: analogix_dp: Unbind bridge when connector init fails
Date: Fri, 13 Nov 2026 08:36:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-212421@kernel.org> (raw)
In-Reply-To: <20261113082305.541652-13-damon.ding@rock-chips.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/rockchip: analogix_dp: missing Fixes trailer for commit
99a49ff5ef7a
--
commit cd9aa2dbf07af695fa219b5368a3d508991e9c28
Author: Damon Ding <damon.ding@rock-chips.com>
> drm/rockchip: analogix_dp: Unbind bridge when connector init fails
>
> The rockchip_dp_bind() returns without unwinding analogix_dp_bind()
> when drm_bridge_connector_init() fails. The aux device registered by
> analogix_dp_bind() is then left behind with a dangling drm_dev
> pointer, which could be accessed on later AUX transfers.
>
> Call analogix_dp_unbind() in the error path to release the aux device.
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
[Severity: Low]
This fixes the error path introduced by commit 99a49ff5ef7a ("drm/bridge:
analogix_dp: Apply drm_bridge_connector helper"). Should this include:
Fixes: 99a49ff5ef7a ("drm/bridge: analogix_dp: Apply drm_bridge_connector helper")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113082305.541652-1-damon.ding@rock-chips.com?part=12
next prev parent reply other threads:[~2026-11-13 8:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 8:22 [PATCH v6 00/18] Add HPD support for Rockchip Analogix DP Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 01/18] drm/bridge: Select VIDEOMODE_HELPERS for DRM_OF_DISPLAY_MODE_BRIDGE Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 02/18] drm/bridge: analogix_dp: Use bridge->next_bridge instead of plat_data field Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 03/18] drm/bridge: analogix_dp: Restrict forced connected status to panel endpoints Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 04/18] drm/bridge: analogix_dp: Return bitmask from analogix_dp_get_irq_type() Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 05/18] drm/bridge: analogix_dp: Check all negative return values for &analogix_dp_device.irq Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 06/18] drm/bridge: analogix_dp: Add IRQF_ONESHOT and simplify IRQ handling Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:40 ` sashiko-bot
2026-11-13 8:22 ` [PATCH v6 07/18] drm/bridge: analogix_dp: Extend clear_hotplug_interrupts to accept IRQ bitmask Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 08/18] drm/bridge: analogix_dp: Extend mute/unmute HPD interrupts to accept irq bitmask Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 09/18] drm/bridge: analogix_dp: Simplify analogix_dp_config_interrupt() Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 10/18] drm/bridge: analogix_dp: Use platform-specific HPD detection scheme Damon Ding
2026-11-13 8:22 ` [PATCH v6 11/18] drm/bridge: analogix_dp: Skip native HPD interrupt ops for GPIO HPD Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:22 ` [PATCH v6 12/18] drm/rockchip: analogix_dp: Unbind bridge when connector init fails Damon Ding
2026-11-13 8:22 ` Damon Ding
2026-11-13 8:36 ` sashiko-bot [this message]
2026-11-13 8:23 ` [PATCH v6 13/18] drm/exynos: exynos_dp: " Damon Ding
2026-11-13 8:23 ` Damon Ding
2026-11-13 8:48 ` sashiko-bot
2026-11-13 8:23 ` [PATCH v6 14/18] drm/bridge: analogix_dp: Move IRQ enable/disable to bind/unbind Damon Ding
2026-11-13 8:23 ` Damon Ding
2026-11-13 8:50 ` sashiko-bot
2026-11-13 8:23 ` [PATCH v6 15/18] drm/bridge: analogix_dp: Manage pm runtime and IRQ for native HPD pin detection Damon Ding
2026-11-13 8:23 ` Damon Ding
2026-11-13 8:23 ` [PATCH v6 16/18] drm/bridge: analogix_dp: Declare DRM_BRIDGE_OP_HPD for hotplug reporting Damon Ding
2026-11-13 8:23 ` Damon Ding
2026-11-13 8:44 ` sashiko-bot
2026-11-13 8:23 ` [PATCH v6 17/18] drm/bridge: analogix_dp: Handle HPD notification from downstream bridge Damon Ding
2026-11-13 8:23 ` Damon Ding
2026-11-13 8:49 ` sashiko-bot
2026-11-13 8:23 ` [PATCH v6 18/18] MAINTAINERS: Add entry for Analogix DP controller bridge Damon Ding
2026-11-13 8:23 ` Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-212421@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon.ding@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.