Re: [PATCH v6 16/18] drm/bridge: analogix_dp: Declare DRM_BRIDGE_OP_HPD for hotplug reporting

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/bridge: analogix_dp: HPD op set before
  force_connected_mode init
--

commit ad70afa663b2bf96d50d8e1fd67e15c99b7409dc
Author: Damon Ding <damon.ding@rock-chips.com>

drm/bridge: analogix_dp: Declare DRM_BRIDGE_OP_HPD for hotplug reporting

This commit declares DRM_BRIDGE_OP_HPD on the analogix_dp bridge when
hotplug detection is supported, implements empty hpd_enable/hpd_disable
callbacks, and replaces drm_helper_hpd_irq_event() with
drm_bridge_hpd_notify().

> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index d72b66be6874d..9f50163aecf9f 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

[ ... ]

> @@ -1634,6 +1647,8 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
>  	}
>  
>  	bridge->ops = DRM_BRIDGE_OP_EDID | DRM_BRIDGE_OP_DETECT;
> +	if (analogix_dp_supports_hpd(dp))
> +		bridge->ops |= DRM_BRIDGE_OP_HPD;
>  	bridge->of_node = dp->dev->of_node;
>  	bridge->type = DRM_MODE_CONNECTOR_eDP;
>  	ret = devm_drm_bridge_add(dp->dev, &dp->bridge);

[Severity: Medium]
Does calling analogix_dp_supports_hpd() here set DRM_BRIDGE_OP_HPD before
dp->force_connected_mode is initialized?

analogix_dp_supports_hpd() checks dp->force_connected_mode to exclude fixed
panels, but dp->force_connected_mode is only populated later in
analogix_dp_bind() when drm_bridge_attach() invokes
analogix_dp_bridge_attach().  On RK3576/RK3588 or boards with hpd_gpiod
connected to a fixed panel, bridge->ops gets DRM_BRIDGE_OP_HPD while the
subsequent analogix_dp_supports_hpd() check after drm_bridge_attach() skips
enable_irq(dp->irq), leaving the connector configured for HPD interrupts
that are never enabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113082305.541652-1-damon.ding@rock-chips.com?part=16