Re: [PATCH v6 06/18] drm/bridge: analogix_dp: Add IRQF_ONESHOT and simplify IRQ handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/bridge: analogix_dp: missing Fixes trailer for threaded IRQ
  race fix
--

commit 54e0c1601490164c97aa8bfcab7daa854142943a
Author: Damon Ding <damon.ding@rock-chips.com>

> drm/bridge: analogix_dp: Add IRQF_ONESHOT and simplify IRQ handling
>
> The threaded IRQ is requested without IRQF_ONESHOT, allowing hardirq to
> preempt the threaded handler. This creates a read-modify-write race on
> HPD interrupt mask registers between the hardirq mute and thread unmute
> operations.
>
> Add IRQF_ONESHOT to keep the IRQ line masked during thread execution,
> which eliminates the race and makes the per-event mute/unmute calls in
> hardirq and thread handlers redundant. Move interrupt status clearing
> to the beginning of the threaded handler, before
> drm_helper_hpd_irq_event(), to avoid losing events that arrive during
> the event handling.
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>

[Severity: Low]
This fixes the missing IRQF_ONESHOT flag, the racy HPD interrupt
mute/unmute sequence, and the late status clearing introduced when the
driver switched from a workqueue to a threaded IRQ handler.  Should this
include:

  Fixes: 7b4b7a8db439 ("drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113082305.541652-1-damon.ding@rock-chips.com?part=6