Re: [PATCH v1 06/12] perf annotate: Print the stats after the annotations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf test: missing DWARF feature check in annotate_stats.sh
  without libdw
--

commit a3aa8082d0e5c5ce9cb6c085dad08c8447fc23aa
Author: Arnaldo Carvalho de Melo <acme@redhat.com>

perf annotate: Print the stats after the annotations

This commit moves the printing of data type and instruction stats in
perf annotate to after the annotation loops and adds a shell test for
instruction stats.

> diff --git a/tools/perf/tests/shell/annotate_stats.sh b/tools/perf/tests/shell/annotate_stats.sh
> new file mode 100755
> index 0000000000000..82d2becdff141
> --- /dev/null
> +++ b/tools/perf/tests/shell/annotate_stats.sh

[ ... ]

> +if ! perf annotate --code-with-type --insn-stat -i "$perfdata" --stdio \
> +		--percent-limit 1 > "$perfout" 2>/dev/null; then
> +	echo "FAIL: perf annotate"
> +	cleanup
> +	exit 1
> +fi
> +
> +# The instruction stats are accounted while the instructions are
> +# displayed; printing them before the display loop shows zeros.
> +if ! grep -Eq '^total [1-9][0-9]*,' "$perfout"; then
> +	echo "FAIL: instruction stats not accounted"
> +	cleanup
> +	exit 1
> +fi

[Severity: Low]
Will this test fail with exit status 1 instead of skipping when perf is
built without libdw dwarf support (HAVE_LIBDW_SUPPORT)?

Unlike --data-type, --code-with-type does not exit early when
HAVE_LIBDW_SUPPORT is disabled.  Instead, debuginfo__new() returns NULL,
so annotation_line__print() skips __hist_entry__get_data_type() and
prints "total 0".  Checking "perf check feature -q dwarf" before running
the test, as in data_type_register.sh, would skip cleanly with exit
status 2.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113150555.1163049-1-acme@kernel.org?part=6