Re: [PATCH v7 11/23] media: qcom: camss: vfe: Add support for VFE 980 - sashiko-bot

From: sashiko-bot@kernel.org
To: "Wenmeng Liu" <wenmeng.liu@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, media-ci@linuxtv.org,
	vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v7 11/23] media: qcom: camss: vfe: Add support for VFE 980
Date: Sat, 14 Nov 2026 11:42:41 +0000	[thread overview]
Message-ID: <sashiko-outbox-214425@kernel.org> (raw)
In-Reply-To: <20261114-add-support-for-camss-on-sm8750-v7-11-8ff2a11835f6@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] media: qcom: camss: camss-vfe-980.c duplicates camss-vfe-1080.c
--

commit 29195d9029785533829d246888a075efe92d772a
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

media: qcom: camss: vfe: Add support for VFE 980

This commit adds hardware operations and SM8750 subdevice resource definitions
for VFE 980.

> diff --git a/drivers/media/platform/qcom/camss/camss-vfe-980.c b/drivers/media/platform/qcom/camss/camss-vfe-980.c
> new file mode 100644
> index 0000000000000..47f6c18190acf
> --- /dev/null
> +++ b/drivers/media/platform/qcom/camss/camss-vfe-980.c
> @@ -0,0 +1,213 @@
[ ... ]
> +/* VFE-980 Bus Register Base Addresses */
> +#define BUS_REG_BASE				(vfe_is_lite(vfe) ? 0x200 : 0x800)

[Severity: Low]
Could VFE 980 share the implementation in camss-vfe-1080.c instead of
duplicating the entire file?

Every register offset, client index, and callback in camss-vfe-980.c is
identical to camss-vfe-1080.c except for BUS_REG_BASE, which could be
selected based on vfe->camss->res->version (similar to camss-vfe-gen3.c).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-add-support-for-camss-on-sm8750-v7-0-8ff2a11835f6@oss.qualcomm.com?part=11

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy