Re: [PATCH v3 03/33] ecryptfs: don't leak the inode when a lookup can't open the lower file

[sashiko-bot@kernel.org]

> ecryptfs_lookup_interpose() opens the lower file of a regular file to
> read the size from the header. If that fails it marks the inode bad and
> returns, but a new inode is still I_NEW and nobody ever unlocks or puts
> it. So it leaks together with its lower inode, a concurrent lookup
> through another hard link waits for it forever and umount complains
> about busy inodes. The lower open fails e.g. with ETXTBSY while the
> lower file is executed. A cached inode is marked bad for all its other
> users instead.
> 
> Use iget_failed() for a new inode and iput() for a cached one.
> 
> Fixes: 3b06b3ebf441 ("eCryptfs: Fix new inode race condition")
> Cc: stable@vger.kernel.org
> Reported-by: Farhad Alemi <farhad.alemi@berkeley.edu>
> Closes: https://lore.kernel.org/r/CA+0ovCgYP920GT68hAJK6Trjyv1kGv2dZAuem4LEunycQ=POww@mail.gmail.com
> Acked-by: Tyler Hicks <code@tyhicks.com>
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-work-fs-sb_rdonly-v3-0-0be92bb73709@kernel.org?part=3