Re: [PATCH v3 28/33] gfs2: don't set SB_RDONLY on withdraw

[sashiko-bot@kernel.org]

> do_withdraw() sets SB_RDONLY from the withdraw work without holding
> s_umount, also on a frozen filesystem. FITHAW then fails because a
> withdrawn filesystem can't take the freeze glock. Emergency thaw and the
> gfs2 "freeze" sysfs file see SB_RDONLY and leave the s_writers rwsems
> locked. Writers hang and umount warns. And freezing after a withdraw
> fails and leaves the superblock frozen.
> 
> SDF_WITHDRAWN already stops all modifications, so stop setting
> SB_RDONLY. A few things have to come with that:
> 
> (1) gfs2_evict_inode() and gfs2_quota_sync() check gfs2_withdrawn()
>     next to sb_rdonly().
> (2) gfs2_write_inode() returns EIO once withdrawn because sync and
>     umount don't skip writeback for a read-only superblock anymore.
> (3) gfs2_do_thaw() thaws even if the freeze glock can't be taken again.
> [ ... ]
> 
> Fixes: 601ef0d52e96 ("gfs2: Force withdraw to replay journals and wait for it to finish")
> Fixes: b77b4a4815a9 ("gfs2: Rework freeze / thaw logic")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-work-fs-sb_rdonly-v3-0-0be92bb73709@kernel.org?part=28