All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] nvmem: Add byte-mask support for non-contiguous byte selection
@ 2026-11-17  6:04 Hongmei Xu
  2026-11-17  6:04 ` [PATCH v3 1/2] dt-bindings: nvmem: add byte-mask property " Hongmei Xu
  2026-11-17  6:04 ` [PATCH v3 2/2] nvmem: core: add byte-mask support for non-contiguous cell bytes Hongmei Xu
  0 siblings, 2 replies; 7+ messages in thread
From: Hongmei Xu @ 2026-11-17  6:04 UTC (permalink / raw)
  To: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Rafał Miłecki
  Cc: devicetree, linux-kernel, Hongmei Xu

Some hardware stores NVMEM cell data in non-contiguous bytes. For
example, a MAC address cell may span 7 physical bytes with one byte
unused, requiring the driver to skip that byte during readout.

The existing 'bits' property can only selects a contiguous range of
bits within a cell's declared region. This series adds a 'byte-mask'
property to the fixed-cell binding and implements it in the nvmem
core, allowing consumers to describe and read cells whose bytes are
non-contiguous within the NVMEM device.

An example: assume a MAC address is assembled from efuse registers
0xFFFF4320[31:0] (bytes 0-3), 0xFFFF4324[7:0] (byte 4), and
0xFFFF4324[23:16] (byte 6), with 0xFFFF4324[15:8] unused (byte 5).
Map the efuse region as an 8-byte nvmem device and define the cell
skipping byte 5:

  efuse: efuse@ffff4320 {
    compatible = "...";
    reg = <0x0 0xffff4320 0x0 0x8>;
    #address-cells = <1>;
    #size-cells = <1>;

    mac_addr: mac-addr@0 {
      reg = <0x0 0x6>;
      byte-mask = <0x5f>;
    };
  };

  With byte-mask = 0x5f (0101_1111), bytes 0-4 and 6 are selected
  (byte 5 is skipped), forming the 6-byte MAC address output.

Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
---
Changes in v3:
- Align cell->raw_len to word_size in byte-mask branch to avoid false
  unaligned error log
- Remove redundant nvmem_validate_byte_mask() call from
  nvmem_add_cells_from_dt(); validation already happens inside
  nvmem_cell_info_to_nvmem_cell_entry_nodup()
- Fix DT binding commit message: remove misleading "multiple reg
  entries" comparison
- Update cover letter description for bits property limitation
- Link to v2: https://patch.msgid.link/20261116-nvmem-byte-mask-for-split-macaddr-v2-0-96f4a0c08264@oss.qualcomm.com

Changes in v2:
- Move nvmem_validate_byte_mask() before the nbits block so byte_mask+nbits
   is rejected even when nbits is set (mutual exclusion bypass fix).
 - Run nvmem_validate_byte_mask() after fixup_dt_cell_info() in the DT path
   so the provider callback can adjust cell info before validation.
 - Set cell->raw_len = fls(byte_mask) instead of nvmem->size - cell->offset,
   limiting the physical read to only the bytes needed; avoids large
   allocations and read failures on providers with protected trailing regions
   (e.g. sec-qfprom).
 - Tighten the device-size check to ALIGN(fls(byte_mask), word_size) so
   word-alignment cannot push the read past the device end.
 - Zero-fill output bytes beyond the last selected byte with memset.
 - Simplify compaction loop guard from i < raw_len && i < 32 to i < raw_len
   since raw_len is now bounded by fls(byte_mask) <= 32.
- Link to v1: https://patch.msgid.link/20261113-nvmem-byte-mask-for-split-macaddr-v1-0-138f715f18c1@oss.qualcomm.com

---
Hongmei Xu (2):
      dt-bindings: nvmem: add byte-mask property for non-contiguous byte selection
      nvmem: core: add byte-mask support for non-contiguous cell bytes

 .../bindings/nvmem/layouts/fixed-cell.yaml         | 21 +++++
 drivers/nvmem/core.c                               | 95 ++++++++++++++++++++--
 include/linux/nvmem-provider.h                     |  8 ++
 3 files changed, 118 insertions(+), 6 deletions(-)
---
base-commit: d26955e57475434b59d43ba372b2a50d33d5e0ed
change-id: 20261110-nvmem-byte-mask-for-split-macaddr-a4698a128057

Best regards,
--  
Hongmei Xu <hongmei.xu@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-18  3:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  6:04 [PATCH v3 0/2] nvmem: Add byte-mask support for non-contiguous byte selection Hongmei Xu
2026-11-17  6:04 ` [PATCH v3 1/2] dt-bindings: nvmem: add byte-mask property " Hongmei Xu
2026-11-17  6:13   ` sashiko-bot
2026-11-17  8:45     ` Hongmei Xu
2026-11-17 15:29   ` Srinivas Kandagatla
2026-11-18  3:20     ` Hongmei Xu
2026-11-17  6:04 ` [PATCH v3 2/2] nvmem: core: add byte-mask support for non-contiguous cell bytes Hongmei Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.