All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: yy-Local-LLM <yogo.0917.sabu@gmail.com>, devicetree@vger.kernel.org
Cc: linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH RFC 2/6] irqchip: add the SiRF AT550 interrupt controller
Date: Tue, 17 Nov 2026 13:27:51 +0000	[thread overview]
Message-ID: <sashiko-outbox-218876@kernel.org> (raw)
In-Reply-To: <20261117-at550-rfc-v1-v1-2-5879573cb825@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] irqchip:at550: non-human handle in Signed-off-by trailer
- [Medium] irqchip:at550: missing IRQ_LEVEL flag in at550_irq_map()
--

commit d5dea66e73a21d9dc175a050a6d6978545bc229c
Author: yy-Local-LLM <yogo.0917.sabu@gmail.com>

> irqchip: add the SiRF AT550 interrupt controller
>
> Register the root controller through IRQCHIP_DECLARE and a linear
> domain. Validate the chip ID before writes, mask both banks during setup
> and route sources to IRQ. Keep dispatch bounded and leave the DSP mask
> registers alone. The register operations derive from the 6.12.60
> YPL514si bring-up. The device owner has now booted the 7.4-rc3 candidate
> through JWM on this upstream initialization path.
>
> Signed-off-by: yy-Local-LLM <yogo.0917.sabu@gmail.com>

[Severity: High]
The Author header and Signed-off-by trailer use the handle "yy-Local-LLM"
rather than a known real full human name, which does not comply with the
Developer's Certificate of Origin in
Documentation/process/submitting-patches.rst.

> diff --git a/drivers/irqchip/irq-at550.c b/drivers/irqchip/irq-at550.c
> new file mode 100644
> index 0000000000000..33eb18cd1e9ec
> --- /dev/null
> +++ b/drivers/irqchip/irq-at550.c
[ ... ]
> +static int at550_irq_map(struct irq_domain *domain, unsigned int irq,
> +			irq_hw_number_t hwirq)
> +{
> +	if (hwirq >= AT550_IRQ_COUNT)
> +		return -EINVAL;
> +	irq_set_chip_and_handler(irq, &at550_chip, handle_level_irq);
> +	irq_set_noprobe(irq);
> +	return 0;
> +}
> +
> +static const struct irq_domain_ops at550_domain_ops = {
> +	.map = at550_irq_map,
> +	.xlate = irq_domain_xlate_onecell,
> +};

[Severity: Medium]
Should at550_irq_map() also call irq_set_status_flags(irq, IRQ_LEVEL)?

Because at550_domain_ops uses irq_domain_xlate_onecell() and at550_chip has
no .irq_set_type callback, IRQ_LEVEL is never set on the descriptor.  If a
level interrupt fires while lazily disabled via disable_irq(),
handle_level_irq() masks the source and sets IRQS_PENDING, and a later
enable_irq() -> check_irq_resend() sees irq_settings_is_level(desc) as
false and schedules a software resend on top of the unmasked hardware line,
running the handler twice and reporting the interrupt as edge-triggered in
procfs and sysfs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-at550-rfc-v1-v1-0-5879573cb825@gmail.com?part=2

  reply	other threads:[~2026-11-17 13:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:06 [PATCH RFC 0/6] SiRF AT550 / YPL514si initial RAM-boot platform support yy-Local-LLM via B4 Relay
2026-11-17 13:06 ` yy-Local-LLM
2026-11-17 13:06 ` [PATCH RFC 1/6] dt-bindings: add SiRF AT550 and Yupiteru YPL514si descriptions yy-Local-LLM via B4 Relay
2026-11-17 13:06   ` yy-Local-LLM
2026-11-17 13:21   ` sashiko-bot
2026-11-17 17:28   ` Conor Dooley
2026-11-17 13:06 ` [PATCH RFC 2/6] irqchip: add the SiRF AT550 interrupt controller yy-Local-LLM via B4 Relay
2026-11-17 13:06   ` yy-Local-LLM
2026-11-17 13:27   ` sashiko-bot [this message]
2026-11-17 13:06 ` [PATCH RFC 3/6] clocksource: add the SiRF AT550 counter and match timer yy-Local-LLM via B4 Relay
2026-11-17 13:06   ` yy-Local-LLM
2026-11-17 13:43   ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 4/6] Input: add polled SiRF AT550 resistive touch support yy-Local-LLM via B4 Relay
2026-11-17 13:06   ` yy-Local-LLM
2026-11-17 13:38   ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 5/6] mmc: sdhci: add SiRF AT550 programmed-I/O support yy-Local-LLM via B4 Relay
2026-11-17 13:06   ` yy-Local-LLM
2026-11-17 13:46   ` sashiko-bot
2026-11-17 13:06 ` [PATCH RFC 6/6] ARM: add the SiRF AT550 platform and YPL514si board yy-Local-LLM via B4 Relay
2026-11-17 13:06   ` yy-Local-LLM
2026-11-17 13:17   ` Arnd Bergmann
2026-11-17 17:23     ` Conor Dooley
2026-11-17 14:05   ` sashiko-bot
2026-11-18  8:14   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218876@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yogo.0917.sabu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.